From bb8b442d32dbdb8521d610e10d8b248d938bd747 Mon Sep 17 00:00:00 2001 From: "djm@openbsd.org" Date: Fri, 16 Jan 2015 15:55:07 +0000 Subject: upstream commit regression: incorrect error message on otherwise-successful ssh-keygen -A. Reported by Dmitry Orlov, via deraadt@ --- ssh-keygen.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ssh-keygen.c b/ssh-keygen.c index 9f6106d47..22f491cd4 100644 --- a/ssh-keygen.c +++ b/ssh-keygen.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ssh-keygen.c,v 1.253 2015/01/16 06:40:12 deraadt Exp $ */ +/* $OpenBSD: ssh-keygen.c,v 1.254 2015/01/16 15:55:07 djm Exp $ */ /* * Author: Tatu Ylonen * Copyright (c) 1994 Tatu Ylonen , Espoo, Finland @@ -1009,8 +1009,8 @@ do_gen_all_hostkeys(struct passwd *pw) first = 0; continue; } - if (!sshkey_write(public, f)) { - fprintf(stderr, "write key failed\n"); + if ((r = sshkey_write(public, f)) != 0) { + fprintf(stderr, "write key failed: %s\n", ssh_err(r)); fclose(f); sshkey_free(public); first = 0; -- cgit v1.2.3