diff options
author | iphydf <iphydf@users.noreply.github.com> | 2018-08-26 19:08:34 +0000 |
---|---|---|
committer | iphydf <iphydf@users.noreply.github.com> | 2018-08-26 20:23:27 +0000 |
commit | 5352f483016949073556a1f9ac488051fe96c308 (patch) | |
tree | 8aa122ace1a7d8ae12117e67a01fa20ab574bbd8 | |
parent | 01e2cc55cbb5fd0d89d7624124674307266ef4ee (diff) |
Make the tsan build fail instead of swallowing its errors.
We'll make it non-required, but we want to know about these failures so
we are incentivised to fix them.
-rwxr-xr-x | .circleci/cmake-asan | 4 | ||||
-rwxr-xr-x | .circleci/cmake-tsan | 5 |
2 files changed, 7 insertions, 2 deletions
diff --git a/.circleci/cmake-asan b/.circleci/cmake-asan index 49220cbe..39ec81b8 100755 --- a/.circleci/cmake-asan +++ b/.circleci/cmake-asan | |||
@@ -24,5 +24,9 @@ cd _build | |||
24 | 24 | ||
25 | ninja install -j$(nproc) | 25 | ninja install -j$(nproc) |
26 | 26 | ||
27 | export ASAN_OPTIONS="detect_invalid_pointer_pairs=1" | ||
28 | export ASAN_OPTIONS="$ASAN_OPTIONS,detect_stack_use_after_return=1" | ||
29 | export ASAN_OPTIONS="$ASAN_OPTIONS,strict_init_order=1" | ||
30 | export ASAN_OPTIONS="$ASAN_OPTIONS,strict_string_checks=1" | ||
27 | ctest -j50 --output-on-failure || | 31 | ctest -j50 --output-on-failure || |
28 | ctest -j50 --output-on-failure --rerun-failed | 32 | ctest -j50 --output-on-failure --rerun-failed |
diff --git a/.circleci/cmake-tsan b/.circleci/cmake-tsan index 65ccc437..5d4453ff 100755 --- a/.circleci/cmake-tsan +++ b/.circleci/cmake-tsan | |||
@@ -24,6 +24,7 @@ cd _build | |||
24 | 24 | ||
25 | ninja install -j$(nproc) | 25 | ninja install -j$(nproc) |
26 | 26 | ||
27 | export TSAN_OPTIONS="halt_on_error=1" | ||
28 | export TSAN_OPTIONS="$TSAN_OPTIONS,second_deadlock_stack=1" | ||
27 | ctest -j50 --output-on-failure || | 29 | ctest -j50 --output-on-failure || |
28 | ctest -j50 --output-on-failure --rerun-failed || | 30 | ctest -j50 --output-on-failure --rerun-failed |
29 | true # TODO(iphydf): remove this line once the data races are fixed. | ||