diff options
author | zugz (tox) <mbays+tox@sdf.org> | 2018-11-17 21:33:46 +0100 |
---|---|---|
committer | zugz (tox) <mbays+tox@sdf.org> | 2019-01-12 22:38:51 +0100 |
commit | a4bca35a1a6e17187f821dbbdfe02798f7f1469e (patch) | |
tree | 3de607d558683b9d980f63c1ead00556e89248df | |
parent | 91ff39599d97d610321970161ba6410f3bdd9b51 (diff) |
Add some const qualifiers
(Implementing suggestions of sudden6)
-rw-r--r-- | toxcore/group.c | 75 | ||||
-rw-r--r-- | toxcore/tox.c | 87 |
2 files changed, 80 insertions, 82 deletions
diff --git a/toxcore/group.c b/toxcore/group.c index d0609b1a..101c1196 100644 --- a/toxcore/group.c +++ b/toxcore/group.c | |||
@@ -251,7 +251,7 @@ int32_t conference_by_id(const Group_Chats *g_c, const uint8_t *id) | |||
251 | * | 251 | * |
252 | * TODO(irungentoo): make this more efficient. | 252 | * TODO(irungentoo): make this more efficient. |
253 | */ | 253 | */ |
254 | static int get_peer_index(Group_c *g, uint16_t peer_number) | 254 | static int get_peer_index(const Group_c *g, uint16_t peer_number) |
255 | { | 255 | { |
256 | for (uint32_t i = 0; i < g->numpeers; ++i) { | 256 | for (uint32_t i = 0; i < g->numpeers; ++i) { |
257 | if (g->group[i].peer_number == peer_number) { | 257 | if (g->group[i].peer_number == peer_number) { |
@@ -283,7 +283,6 @@ typedef enum Groupchat_Closest { | |||
283 | 283 | ||
284 | static int add_to_closest(Group_Chats *g_c, uint32_t groupnumber, const uint8_t *real_pk, const uint8_t *temp_pk) | 284 | static int add_to_closest(Group_Chats *g_c, uint32_t groupnumber, const uint8_t *real_pk, const uint8_t *temp_pk) |
285 | { | 285 | { |
286 | // TODO(zugz): this can be const. Similarly throughout the file. | ||
287 | Group_c *g = get_group_c(g_c, groupnumber); | 286 | Group_c *g = get_group_c(g_c, groupnumber); |
288 | 287 | ||
289 | if (!g) { | 288 | if (!g) { |
@@ -365,7 +364,7 @@ static int add_to_closest(Group_Chats *g_c, uint32_t groupnumber, const uint8_t | |||
365 | return 0; | 364 | return 0; |
366 | } | 365 | } |
367 | 366 | ||
368 | static unsigned int pk_in_closest_peers(Group_c *g, uint8_t *real_pk) | 367 | static unsigned int pk_in_closest_peers(const Group_c *g, uint8_t *real_pk) |
369 | { | 368 | { |
370 | unsigned int i; | 369 | unsigned int i; |
371 | 370 | ||
@@ -388,7 +387,7 @@ static int add_conn_to_groupchat(Group_Chats *g_c, int friendcon_id, uint32_t gr | |||
388 | static void remove_conn_reason(Group_Chats *g_c, uint32_t groupnumber, uint16_t i, uint8_t reason); | 387 | static void remove_conn_reason(Group_Chats *g_c, uint32_t groupnumber, uint16_t i, uint8_t reason); |
389 | 388 | ||
390 | static int send_packet_online(Friend_Connections *fr_c, int friendcon_id, uint16_t group_num, uint8_t type, | 389 | static int send_packet_online(Friend_Connections *fr_c, int friendcon_id, uint16_t group_num, uint8_t type, |
391 | uint8_t *id); | 390 | const uint8_t *id); |
392 | 391 | ||
393 | static int connect_to_closest(Group_Chats *g_c, uint32_t groupnumber, void *userdata) | 392 | static int connect_to_closest(Group_Chats *g_c, uint32_t groupnumber, void *userdata) |
394 | { | 393 | { |
@@ -458,7 +457,7 @@ static int connect_to_closest(Group_Chats *g_c, uint32_t groupnumber, void *user | |||
458 | return 0; | 457 | return 0; |
459 | } | 458 | } |
460 | 459 | ||
461 | static int get_frozen_index(Group_c *g, uint16_t peer_number) | 460 | static int get_frozen_index(const Group_c *g, uint16_t peer_number) |
462 | { | 461 | { |
463 | for (uint32_t i = 0; i < g->numfrozen; ++i) { | 462 | for (uint32_t i = 0; i < g->numfrozen; ++i) { |
464 | if (g->frozen[i].peer_number == peer_number) { | 463 | if (g->frozen[i].peer_number == peer_number) { |
@@ -485,7 +484,7 @@ static bool delete_frozen(Group_c *g, uint32_t frozen_index) | |||
485 | g->frozen[frozen_index] = g->frozen[g->numfrozen]; | 484 | g->frozen[frozen_index] = g->frozen[g->numfrozen]; |
486 | } | 485 | } |
487 | 486 | ||
488 | Group_Peer *frozen_temp = (Group_Peer *)realloc(g->frozen, sizeof(Group_Peer) * (g->numfrozen)); | 487 | Group_Peer *const frozen_temp = (Group_Peer *)realloc(g->frozen, sizeof(Group_Peer) * (g->numfrozen)); |
489 | 488 | ||
490 | if (frozen_temp == nullptr) { | 489 | if (frozen_temp == nullptr) { |
491 | return false; | 490 | return false; |
@@ -567,13 +566,13 @@ static void delete_any_peer_with_pk(Group_Chats *g_c, uint32_t groupnumber, cons | |||
567 | return; | 566 | return; |
568 | } | 567 | } |
569 | 568 | ||
570 | int prev_peer_index = peer_in_chat(g, real_pk); | 569 | const int prev_peer_index = peer_in_chat(g, real_pk); |
571 | 570 | ||
572 | if (prev_peer_index >= 0) { | 571 | if (prev_peer_index >= 0) { |
573 | delpeer(g_c, groupnumber, prev_peer_index, userdata, false); | 572 | delpeer(g_c, groupnumber, prev_peer_index, userdata, false); |
574 | } | 573 | } |
575 | 574 | ||
576 | int prev_frozen_index = frozen_in_chat(g, real_pk); | 575 | const int prev_frozen_index = frozen_in_chat(g, real_pk); |
577 | 576 | ||
578 | if (prev_frozen_index >= 0) { | 577 | if (prev_frozen_index >= 0) { |
579 | delete_frozen(g, prev_frozen_index); | 578 | delete_frozen(g, prev_frozen_index); |
@@ -1139,7 +1138,7 @@ int del_groupchat(Group_Chats *g_c, uint32_t groupnumber, bool leave_permanently | |||
1139 | */ | 1138 | */ |
1140 | int group_peer_pubkey(const Group_Chats *g_c, uint32_t groupnumber, int peernumber, uint8_t *pk, bool frozen) | 1139 | int group_peer_pubkey(const Group_Chats *g_c, uint32_t groupnumber, int peernumber, uint8_t *pk, bool frozen) |
1141 | { | 1140 | { |
1142 | Group_c *g = get_group_c(g_c, groupnumber); | 1141 | const Group_c *g = get_group_c(g_c, groupnumber); |
1143 | 1142 | ||
1144 | if (!g) { | 1143 | if (!g) { |
1145 | return -1; | 1144 | return -1; |
@@ -1164,7 +1163,7 @@ int group_peer_pubkey(const Group_Chats *g_c, uint32_t groupnumber, int peernumb | |||
1164 | */ | 1163 | */ |
1165 | int group_peername_size(const Group_Chats *g_c, uint32_t groupnumber, int peernumber, bool frozen) | 1164 | int group_peername_size(const Group_Chats *g_c, uint32_t groupnumber, int peernumber, bool frozen) |
1166 | { | 1165 | { |
1167 | Group_c *g = get_group_c(g_c, groupnumber); | 1166 | const Group_c *g = get_group_c(g_c, groupnumber); |
1168 | 1167 | ||
1169 | if (!g) { | 1168 | if (!g) { |
1170 | return -1; | 1169 | return -1; |
@@ -1193,7 +1192,7 @@ int group_peername_size(const Group_Chats *g_c, uint32_t groupnumber, int peernu | |||
1193 | */ | 1192 | */ |
1194 | int group_peername(const Group_Chats *g_c, uint32_t groupnumber, int peernumber, uint8_t *name, bool frozen) | 1193 | int group_peername(const Group_Chats *g_c, uint32_t groupnumber, int peernumber, uint8_t *name, bool frozen) |
1195 | { | 1194 | { |
1196 | Group_c *g = get_group_c(g_c, groupnumber); | 1195 | const Group_c *g = get_group_c(g_c, groupnumber); |
1197 | 1196 | ||
1198 | if (!g) { | 1197 | if (!g) { |
1199 | return -1; | 1198 | return -1; |
@@ -1224,7 +1223,7 @@ int group_peername(const Group_Chats *g_c, uint32_t groupnumber, int peernumber, | |||
1224 | int group_frozen_last_active(const Group_Chats *g_c, uint32_t groupnumber, int peernumber, | 1223 | int group_frozen_last_active(const Group_Chats *g_c, uint32_t groupnumber, int peernumber, |
1225 | uint64_t *last_active) | 1224 | uint64_t *last_active) |
1226 | { | 1225 | { |
1227 | Group_c *g = get_group_c(g_c, groupnumber); | 1226 | const Group_c *g = get_group_c(g_c, groupnumber); |
1228 | 1227 | ||
1229 | if (!g) { | 1228 | if (!g) { |
1230 | return -1; | 1229 | return -1; |
@@ -1251,7 +1250,7 @@ int group_frozen_last_active(const Group_Chats *g_c, uint32_t groupnumber, int p | |||
1251 | int group_names(const Group_Chats *g_c, uint32_t groupnumber, uint8_t names[][MAX_NAME_LENGTH], uint16_t lengths[], | 1250 | int group_names(const Group_Chats *g_c, uint32_t groupnumber, uint8_t names[][MAX_NAME_LENGTH], uint16_t lengths[], |
1252 | uint16_t length, bool frozen) | 1251 | uint16_t length, bool frozen) |
1253 | { | 1252 | { |
1254 | Group_c *g = get_group_c(g_c, groupnumber); | 1253 | const Group_c *g = get_group_c(g_c, groupnumber); |
1255 | 1254 | ||
1256 | if (!g) { | 1255 | if (!g) { |
1257 | return -1; | 1256 | return -1; |
@@ -1274,7 +1273,7 @@ int group_names(const Group_Chats *g_c, uint32_t groupnumber, uint8_t names[][MA | |||
1274 | */ | 1273 | */ |
1275 | int group_number_peers(const Group_Chats *g_c, uint32_t groupnumber, bool frozen) | 1274 | int group_number_peers(const Group_Chats *g_c, uint32_t groupnumber, bool frozen) |
1276 | { | 1275 | { |
1277 | Group_c *g = get_group_c(g_c, groupnumber); | 1276 | const Group_c *g = get_group_c(g_c, groupnumber); |
1278 | 1277 | ||
1279 | if (!g) { | 1278 | if (!g) { |
1280 | return -1; | 1279 | return -1; |
@@ -1291,7 +1290,7 @@ int group_number_peers(const Group_Chats *g_c, uint32_t groupnumber, bool frozen | |||
1291 | */ | 1290 | */ |
1292 | int group_peernumber_is_ours(const Group_Chats *g_c, uint32_t groupnumber, int peernumber) | 1291 | int group_peernumber_is_ours(const Group_Chats *g_c, uint32_t groupnumber, int peernumber) |
1293 | { | 1292 | { |
1294 | Group_c *g = get_group_c(g_c, groupnumber); | 1293 | const Group_c *g = get_group_c(g_c, groupnumber); |
1295 | 1294 | ||
1296 | if (!g) { | 1295 | if (!g) { |
1297 | return -1; | 1296 | return -1; |
@@ -1712,7 +1711,7 @@ static int group_name_send(const Group_Chats *g_c, uint32_t groupnumber, const u | |||
1712 | */ | 1711 | */ |
1713 | static bool group_leave(const Group_Chats *g_c, uint32_t groupnumber, bool permanent) | 1712 | static bool group_leave(const Group_Chats *g_c, uint32_t groupnumber, bool permanent) |
1714 | { | 1713 | { |
1715 | Group_c *g = get_group_c(g_c, groupnumber); | 1714 | const Group_c *g = get_group_c(g_c, groupnumber); |
1716 | 1715 | ||
1717 | if (!g) { | 1716 | if (!g) { |
1718 | return false; | 1717 | return false; |
@@ -1769,7 +1768,7 @@ int group_title_send(const Group_Chats *g_c, uint32_t groupnumber, const uint8_t | |||
1769 | */ | 1768 | */ |
1770 | int group_title_get_size(const Group_Chats *g_c, uint32_t groupnumber) | 1769 | int group_title_get_size(const Group_Chats *g_c, uint32_t groupnumber) |
1771 | { | 1770 | { |
1772 | Group_c *g = get_group_c(g_c, groupnumber); | 1771 | const Group_c *g = get_group_c(g_c, groupnumber); |
1773 | 1772 | ||
1774 | if (!g) { | 1773 | if (!g) { |
1775 | return -1; | 1774 | return -1; |
@@ -1791,7 +1790,7 @@ int group_title_get_size(const Group_Chats *g_c, uint32_t groupnumber) | |||
1791 | */ | 1790 | */ |
1792 | int group_title_get(const Group_Chats *g_c, uint32_t groupnumber, uint8_t *title) | 1791 | int group_title_get(const Group_Chats *g_c, uint32_t groupnumber, uint8_t *title) |
1793 | { | 1792 | { |
1794 | Group_c *g = get_group_c(g_c, groupnumber); | 1793 | const Group_c *g = get_group_c(g_c, groupnumber); |
1795 | 1794 | ||
1796 | if (!g) { | 1795 | if (!g) { |
1797 | return -1; | 1796 | return -1; |
@@ -1929,7 +1928,7 @@ static void handle_friend_invite_packet(Messenger *m, uint32_t friendnumber, con | |||
1929 | * returns index on success | 1928 | * returns index on success |
1930 | * returns -1 on failure. | 1929 | * returns -1 on failure. |
1931 | */ | 1930 | */ |
1932 | static int friend_in_close(Group_c *g, int friendcon_id) | 1931 | static int friend_in_close(const Group_c *g, int friendcon_id) |
1933 | { | 1932 | { |
1934 | unsigned int i; | 1933 | unsigned int i; |
1935 | 1934 | ||
@@ -1950,7 +1949,7 @@ static int friend_in_close(Group_c *g, int friendcon_id) | |||
1950 | 1949 | ||
1951 | /* return number of connected close connections. | 1950 | /* return number of connected close connections. |
1952 | */ | 1951 | */ |
1953 | static unsigned int count_close_connected(Group_c *g) | 1952 | static unsigned int count_close_connected(const Group_c *g) |
1954 | { | 1953 | { |
1955 | unsigned int i, count = 0; | 1954 | unsigned int i, count = 0; |
1956 | 1955 | ||
@@ -1964,7 +1963,7 @@ static unsigned int count_close_connected(Group_c *g) | |||
1964 | } | 1963 | } |
1965 | 1964 | ||
1966 | static int send_packet_online(Friend_Connections *fr_c, int friendcon_id, uint16_t group_num, uint8_t type, | 1965 | static int send_packet_online(Friend_Connections *fr_c, int friendcon_id, uint16_t group_num, uint8_t type, |
1967 | uint8_t *id) | 1966 | const uint8_t *id) |
1968 | { | 1967 | { |
1969 | uint8_t packet[1 + ONLINE_PACKET_DATA_SIZE]; | 1968 | uint8_t packet[1 + ONLINE_PACKET_DATA_SIZE]; |
1970 | group_num = net_htons(group_num); | 1969 | group_num = net_htons(group_num); |
@@ -2045,7 +2044,7 @@ static int handle_packet_rejoin(Group_Chats *g_c, int friendcon_id, const uint8_ | |||
2045 | 2044 | ||
2046 | const int32_t groupnum = get_group_num(g_c, *data, data + 1); | 2045 | const int32_t groupnum = get_group_num(g_c, *data, data + 1); |
2047 | 2046 | ||
2048 | Group_c *g = get_group_c(g_c, groupnum); | 2047 | const Group_c *g = get_group_c(g_c, groupnum); |
2049 | 2048 | ||
2050 | if (!g) { | 2049 | if (!g) { |
2051 | return -1; | 2050 | return -1; |
@@ -2099,7 +2098,7 @@ static unsigned int send_peer_query(Group_Chats *g_c, int friendcon_id, uint16_t | |||
2099 | */ | 2098 | */ |
2100 | static unsigned int send_peers(Group_Chats *g_c, uint32_t groupnumber, int friendcon_id, uint16_t group_num) | 2099 | static unsigned int send_peers(Group_Chats *g_c, uint32_t groupnumber, int friendcon_id, uint16_t group_num) |
2101 | { | 2100 | { |
2102 | Group_c *g = get_group_c(g_c, groupnumber); | 2101 | const Group_c *g = get_group_c(g_c, groupnumber); |
2103 | 2102 | ||
2104 | if (!g) { | 2103 | if (!g) { |
2105 | return 0; | 2104 | return 0; |
@@ -2222,7 +2221,7 @@ static void handle_direct_packet(Group_Chats *g_c, uint32_t groupnumber, const u | |||
2222 | 2221 | ||
2223 | switch (data[0]) { | 2222 | switch (data[0]) { |
2224 | case PEER_INTRODUCED_ID: { | 2223 | case PEER_INTRODUCED_ID: { |
2225 | Group_c *g = get_group_c(g_c, groupnumber); | 2224 | const Group_c *g = get_group_c(g_c, groupnumber); |
2226 | 2225 | ||
2227 | if (!g) { | 2226 | if (!g) { |
2228 | return; | 2227 | return; |
@@ -2234,7 +2233,7 @@ static void handle_direct_packet(Group_Chats *g_c, uint32_t groupnumber, const u | |||
2234 | break; | 2233 | break; |
2235 | 2234 | ||
2236 | case PEER_QUERY_ID: { | 2235 | case PEER_QUERY_ID: { |
2237 | Group_c *g = get_group_c(g_c, groupnumber); | 2236 | const Group_c *g = get_group_c(g_c, groupnumber); |
2238 | 2237 | ||
2239 | if (!g) { | 2238 | if (!g) { |
2240 | return; | 2239 | return; |
@@ -2256,7 +2255,7 @@ static void handle_direct_packet(Group_Chats *g_c, uint32_t groupnumber, const u | |||
2256 | break; | 2255 | break; |
2257 | 2256 | ||
2258 | case PEER_TITLE_ID: { | 2257 | case PEER_TITLE_ID: { |
2259 | Group_c *g = get_group_c(g_c, groupnumber); | 2258 | const Group_c *g = get_group_c(g_c, groupnumber); |
2260 | 2259 | ||
2261 | if (!g) { | 2260 | if (!g) { |
2262 | break; | 2261 | break; |
@@ -2279,7 +2278,7 @@ static void handle_direct_packet(Group_Chats *g_c, uint32_t groupnumber, const u | |||
2279 | static unsigned int send_message_all_close(const Group_Chats *g_c, uint32_t groupnumber, const uint8_t *data, | 2278 | static unsigned int send_message_all_close(const Group_Chats *g_c, uint32_t groupnumber, const uint8_t *data, |
2280 | uint16_t length, int receiver) | 2279 | uint16_t length, int receiver) |
2281 | { | 2280 | { |
2282 | Group_c *g = get_group_c(g_c, groupnumber); | 2281 | const Group_c *g = get_group_c(g_c, groupnumber); |
2283 | 2282 | ||
2284 | if (!g) { | 2283 | if (!g) { |
2285 | return 0; | 2284 | return 0; |
@@ -2314,7 +2313,7 @@ static unsigned int send_lossy_all_close(const Group_Chats *g_c, uint32_t groupn | |||
2314 | uint16_t length, | 2313 | uint16_t length, |
2315 | int receiver) | 2314 | int receiver) |
2316 | { | 2315 | { |
2317 | Group_c *g = get_group_c(g_c, groupnumber); | 2316 | const Group_c *g = get_group_c(g_c, groupnumber); |
2318 | 2317 | ||
2319 | if (!g) { | 2318 | if (!g) { |
2320 | return 0; | 2319 | return 0; |
@@ -2561,7 +2560,7 @@ static void handle_message_packet_group(Group_Chats *g_c, uint32_t groupnumber, | |||
2561 | return; | 2560 | return; |
2562 | } | 2561 | } |
2563 | 2562 | ||
2564 | Group_c *g = get_group_c(g_c, groupnumber); | 2563 | const Group_c *g = get_group_c(g_c, groupnumber); |
2565 | 2564 | ||
2566 | if (!g) { | 2565 | if (!g) { |
2567 | return; | 2566 | return; |
@@ -2741,7 +2740,7 @@ static int g_handle_packet(void *object, int friendcon_id, const uint8_t *data, | |||
2741 | uint16_t groupnumber; | 2740 | uint16_t groupnumber; |
2742 | memcpy(&groupnumber, data + 1, sizeof(uint16_t)); | 2741 | memcpy(&groupnumber, data + 1, sizeof(uint16_t)); |
2743 | groupnumber = net_ntohs(groupnumber); | 2742 | groupnumber = net_ntohs(groupnumber); |
2744 | Group_c *g = get_group_c(g_c, groupnumber); | 2743 | const Group_c *g = get_group_c(g_c, groupnumber); |
2745 | 2744 | ||
2746 | if (!g) { | 2745 | if (!g) { |
2747 | return -1; | 2746 | return -1; |
@@ -2781,7 +2780,7 @@ static int g_handle_packet(void *object, int friendcon_id, const uint8_t *data, | |||
2781 | * | 2780 | * |
2782 | * TODO(irungentoo): test this | 2781 | * TODO(irungentoo): test this |
2783 | */ | 2782 | */ |
2784 | static unsigned int lossy_packet_not_received(Group_c *g, int peer_index, uint16_t message_number) | 2783 | static unsigned int lossy_packet_not_received(const Group_c *g, int peer_index, uint16_t message_number) |
2785 | { | 2784 | { |
2786 | if (peer_index == -1) { | 2785 | if (peer_index == -1) { |
2787 | // TODO(sudden6): invalid return value | 2786 | // TODO(sudden6): invalid return value |
@@ -2852,7 +2851,7 @@ static int handle_lossy(void *object, int friendcon_id, const uint8_t *data, uin | |||
2852 | peer_number = net_ntohs(peer_number); | 2851 | peer_number = net_ntohs(peer_number); |
2853 | message_number = net_ntohs(message_number); | 2852 | message_number = net_ntohs(message_number); |
2854 | 2853 | ||
2855 | Group_c *g = get_group_c(g_c, groupnumber); | 2854 | const Group_c *g = get_group_c(g_c, groupnumber); |
2856 | 2855 | ||
2857 | if (!g) { | 2856 | if (!g) { |
2858 | return -1; | 2857 | return -1; |
@@ -2921,7 +2920,7 @@ int group_set_object(const Group_Chats *g_c, uint32_t groupnumber, void *object) | |||
2921 | */ | 2920 | */ |
2922 | int group_peer_set_object(const Group_Chats *g_c, uint32_t groupnumber, int peernumber, void *object) | 2921 | int group_peer_set_object(const Group_Chats *g_c, uint32_t groupnumber, int peernumber, void *object) |
2923 | { | 2922 | { |
2924 | Group_c *g = get_group_c(g_c, groupnumber); | 2923 | const Group_c *g = get_group_c(g_c, groupnumber); |
2925 | 2924 | ||
2926 | if (!g) { | 2925 | if (!g) { |
2927 | return -1; | 2926 | return -1; |
@@ -2942,7 +2941,7 @@ int group_peer_set_object(const Group_Chats *g_c, uint32_t groupnumber, int peer | |||
2942 | */ | 2941 | */ |
2943 | void *group_get_object(const Group_Chats *g_c, uint32_t groupnumber) | 2942 | void *group_get_object(const Group_Chats *g_c, uint32_t groupnumber) |
2944 | { | 2943 | { |
2945 | Group_c *g = get_group_c(g_c, groupnumber); | 2944 | const Group_c *g = get_group_c(g_c, groupnumber); |
2946 | 2945 | ||
2947 | if (!g) { | 2946 | if (!g) { |
2948 | return nullptr; | 2947 | return nullptr; |
@@ -2958,7 +2957,7 @@ void *group_get_object(const Group_Chats *g_c, uint32_t groupnumber) | |||
2958 | */ | 2957 | */ |
2959 | void *group_peer_get_object(const Group_Chats *g_c, uint32_t groupnumber, int peernumber) | 2958 | void *group_peer_get_object(const Group_Chats *g_c, uint32_t groupnumber, int peernumber) |
2960 | { | 2959 | { |
2961 | Group_c *g = get_group_c(g_c, groupnumber); | 2960 | const Group_c *g = get_group_c(g_c, groupnumber); |
2962 | 2961 | ||
2963 | if (!g) { | 2962 | if (!g) { |
2964 | return nullptr; | 2963 | return nullptr; |
@@ -3101,7 +3100,7 @@ static uint8_t *save_conf(const Group_c *g, uint8_t *data) | |||
3101 | host_to_lendian_bytes16(data, g->peer_number); | 3100 | host_to_lendian_bytes16(data, g->peer_number); |
3102 | data += sizeof(uint16_t); | 3101 | data += sizeof(uint16_t); |
3103 | 3102 | ||
3104 | uint8_t *numsaved_location = data; | 3103 | uint8_t *const numsaved_location = data; |
3105 | data += sizeof(uint32_t); | 3104 | data += sizeof(uint32_t); |
3106 | 3105 | ||
3107 | *data = g->title_len; | 3106 | *data = g->title_len; |
@@ -3133,7 +3132,7 @@ static uint32_t conferences_section_size(const Group_Chats *g_c) | |||
3133 | uint32_t len = 0; | 3132 | uint32_t len = 0; |
3134 | 3133 | ||
3135 | for (uint16_t i = 0; i < g_c->num_chats; ++i) { | 3134 | for (uint16_t i = 0; i < g_c->num_chats; ++i) { |
3136 | Group_c *g = get_group_c(g_c, i); | 3135 | const Group_c *g = get_group_c(g_c, i); |
3137 | 3136 | ||
3138 | if (!g || g->status != GROUPCHAT_STATUS_CONNECTED) { | 3137 | if (!g || g->status != GROUPCHAT_STATUS_CONNECTED) { |
3139 | continue; | 3138 | continue; |
@@ -3156,7 +3155,7 @@ uint8_t *conferences_save(const Group_Chats *g_c, uint8_t *data) | |||
3156 | data = state_write_section_header(data, STATE_COOKIE_TYPE, len, STATE_TYPE_CONFERENCES); | 3155 | data = state_write_section_header(data, STATE_COOKIE_TYPE, len, STATE_TYPE_CONFERENCES); |
3157 | 3156 | ||
3158 | for (uint16_t i = 0; i < g_c->num_chats; ++i) { | 3157 | for (uint16_t i = 0; i < g_c->num_chats; ++i) { |
3159 | Group_c *g = get_group_c(g_c, i); | 3158 | const Group_c *g = get_group_c(g_c, i); |
3160 | 3159 | ||
3161 | if (!g || g->status != GROUPCHAT_STATUS_CONNECTED) { | 3160 | if (!g || g->status != GROUPCHAT_STATUS_CONNECTED) { |
3162 | continue; | 3161 | continue; |
diff --git a/toxcore/tox.c b/toxcore/tox.c index d848102e..d59094af 100644 --- a/toxcore/tox.c +++ b/toxcore/tox.c | |||
@@ -330,7 +330,7 @@ bool tox_version_is_compatible(uint32_t major, uint32_t minor, uint32_t patch) | |||
330 | 330 | ||
331 | static State_Load_Status state_load_callback(void *outer, const uint8_t *data, uint32_t length, uint16_t type) | 331 | static State_Load_Status state_load_callback(void *outer, const uint8_t *data, uint32_t length, uint16_t type) |
332 | { | 332 | { |
333 | Tox *tox = (Tox *)outer; | 333 | const Tox *tox = (const Tox *)outer; |
334 | State_Load_Status status = STATE_LOAD_STATUS_CONTINUE; | 334 | State_Load_Status status = STATE_LOAD_STATUS_CONTINUE; |
335 | 335 | ||
336 | if (messenger_load_state_section(tox->m, data, length, type, &status) | 336 | if (messenger_load_state_section(tox->m, data, length, type, &status) |
@@ -356,7 +356,7 @@ static State_Load_Status state_load_callback(void *outer, const uint8_t *data, u | |||
356 | static int tox_load(Tox *tox, const uint8_t *data, uint32_t length) | 356 | static int tox_load(Tox *tox, const uint8_t *data, uint32_t length) |
357 | { | 357 | { |
358 | uint32_t data32[2]; | 358 | uint32_t data32[2]; |
359 | uint32_t cookie_len = sizeof(data32); | 359 | const uint32_t cookie_len = sizeof(data32); |
360 | 360 | ||
361 | if (length < cookie_len) { | 361 | if (length < cookie_len) { |
362 | return -1; | 362 | return -1; |
@@ -637,7 +637,7 @@ bool tox_bootstrap(Tox *tox, const char *host, uint16_t port, const uint8_t *pub | |||
637 | 637 | ||
638 | IP_Port *root; | 638 | IP_Port *root; |
639 | 639 | ||
640 | int32_t count = net_getipport(host, &root, TOX_SOCK_DGRAM); | 640 | const int32_t count = net_getipport(host, &root, TOX_SOCK_DGRAM); |
641 | 641 | ||
642 | if (count == -1) { | 642 | if (count == -1) { |
643 | net_freeipport(root); | 643 | net_freeipport(root); |
@@ -713,8 +713,7 @@ Tox_Connection tox_self_get_connection_status(const Tox *tox) | |||
713 | { | 713 | { |
714 | const Messenger *m = tox->m; | 714 | const Messenger *m = tox->m; |
715 | 715 | ||
716 | // TODO(zugz): this can be const. Similarly throughout the file. | 716 | const unsigned int ret = onion_connection_status(m->onion_c); |
717 | unsigned int ret = onion_connection_status(m->onion_c); | ||
718 | 717 | ||
719 | if (ret == 2) { | 718 | if (ret == 2) { |
720 | return TOX_CONNECTION_UDP; | 719 | return TOX_CONNECTION_UDP; |
@@ -913,7 +912,7 @@ uint32_t tox_friend_add(Tox *tox, const uint8_t *address, const uint8_t *message | |||
913 | } | 912 | } |
914 | 913 | ||
915 | Messenger *m = tox->m; | 914 | Messenger *m = tox->m; |
916 | int32_t ret = m_addfriend(m, address, message, length); | 915 | const int32_t ret = m_addfriend(m, address, message, length); |
917 | 916 | ||
918 | if (ret >= 0) { | 917 | if (ret >= 0) { |
919 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_ADD_OK); | 918 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_ADD_OK); |
@@ -932,7 +931,7 @@ uint32_t tox_friend_add_norequest(Tox *tox, const uint8_t *public_key, Tox_Err_F | |||
932 | } | 931 | } |
933 | 932 | ||
934 | Messenger *m = tox->m; | 933 | Messenger *m = tox->m; |
935 | int32_t ret = m_addfriend_norequest(m, public_key); | 934 | const int32_t ret = m_addfriend_norequest(m, public_key); |
936 | 935 | ||
937 | if (ret >= 0) { | 936 | if (ret >= 0) { |
938 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_ADD_OK); | 937 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_ADD_OK); |
@@ -946,7 +945,7 @@ uint32_t tox_friend_add_norequest(Tox *tox, const uint8_t *public_key, Tox_Err_F | |||
946 | bool tox_friend_delete(Tox *tox, uint32_t friend_number, Tox_Err_Friend_Delete *error) | 945 | bool tox_friend_delete(Tox *tox, uint32_t friend_number, Tox_Err_Friend_Delete *error) |
947 | { | 946 | { |
948 | Messenger *m = tox->m; | 947 | Messenger *m = tox->m; |
949 | int ret = m_delfriend(m, friend_number); | 948 | const int ret = m_delfriend(m, friend_number); |
950 | 949 | ||
951 | // TODO(irungentoo): handle if realloc fails? | 950 | // TODO(irungentoo): handle if realloc fails? |
952 | if (ret == -1) { | 951 | if (ret == -1) { |
@@ -966,7 +965,7 @@ uint32_t tox_friend_by_public_key(const Tox *tox, const uint8_t *public_key, Tox | |||
966 | } | 965 | } |
967 | 966 | ||
968 | const Messenger *m = tox->m; | 967 | const Messenger *m = tox->m; |
969 | int32_t ret = getfriend_id(m, public_key); | 968 | const int32_t ret = getfriend_id(m, public_key); |
970 | 969 | ||
971 | if (ret == -1) { | 970 | if (ret == -1) { |
972 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_BY_PUBLIC_KEY_NOT_FOUND); | 971 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_BY_PUBLIC_KEY_NOT_FOUND); |
@@ -1004,7 +1003,7 @@ bool tox_friend_exists(const Tox *tox, uint32_t friend_number) | |||
1004 | uint64_t tox_friend_get_last_online(const Tox *tox, uint32_t friend_number, Tox_Err_Friend_Get_Last_Online *error) | 1003 | uint64_t tox_friend_get_last_online(const Tox *tox, uint32_t friend_number, Tox_Err_Friend_Get_Last_Online *error) |
1005 | { | 1004 | { |
1006 | const Messenger *m = tox->m; | 1005 | const Messenger *m = tox->m; |
1007 | uint64_t timestamp = m_get_last_online(m, friend_number); | 1006 | const uint64_t timestamp = m_get_last_online(m, friend_number); |
1008 | 1007 | ||
1009 | if (timestamp == UINT64_MAX) { | 1008 | if (timestamp == UINT64_MAX) { |
1010 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_GET_LAST_ONLINE_FRIEND_NOT_FOUND); | 1009 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_GET_LAST_ONLINE_FRIEND_NOT_FOUND); |
@@ -1033,7 +1032,7 @@ void tox_self_get_friend_list(const Tox *tox, uint32_t *friend_list) | |||
1033 | size_t tox_friend_get_name_size(const Tox *tox, uint32_t friend_number, Tox_Err_Friend_Query *error) | 1032 | size_t tox_friend_get_name_size(const Tox *tox, uint32_t friend_number, Tox_Err_Friend_Query *error) |
1034 | { | 1033 | { |
1035 | const Messenger *m = tox->m; | 1034 | const Messenger *m = tox->m; |
1036 | int ret = m_get_name_size(m, friend_number); | 1035 | const int ret = m_get_name_size(m, friend_number); |
1037 | 1036 | ||
1038 | if (ret == -1) { | 1037 | if (ret == -1) { |
1039 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_QUERY_FRIEND_NOT_FOUND); | 1038 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_QUERY_FRIEND_NOT_FOUND); |
@@ -1052,7 +1051,7 @@ bool tox_friend_get_name(const Tox *tox, uint32_t friend_number, uint8_t *name, | |||
1052 | } | 1051 | } |
1053 | 1052 | ||
1054 | const Messenger *m = tox->m; | 1053 | const Messenger *m = tox->m; |
1055 | int ret = getname(m, friend_number, name); | 1054 | const int ret = getname(m, friend_number, name); |
1056 | 1055 | ||
1057 | if (ret == -1) { | 1056 | if (ret == -1) { |
1058 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_QUERY_FRIEND_NOT_FOUND); | 1057 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_QUERY_FRIEND_NOT_FOUND); |
@@ -1071,7 +1070,7 @@ void tox_callback_friend_name(Tox *tox, tox_friend_name_cb *callback) | |||
1071 | size_t tox_friend_get_status_message_size(const Tox *tox, uint32_t friend_number, Tox_Err_Friend_Query *error) | 1070 | size_t tox_friend_get_status_message_size(const Tox *tox, uint32_t friend_number, Tox_Err_Friend_Query *error) |
1072 | { | 1071 | { |
1073 | const Messenger *m = tox->m; | 1072 | const Messenger *m = tox->m; |
1074 | int ret = m_get_statusmessage_size(m, friend_number); | 1073 | const int ret = m_get_statusmessage_size(m, friend_number); |
1075 | 1074 | ||
1076 | if (ret == -1) { | 1075 | if (ret == -1) { |
1077 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_QUERY_FRIEND_NOT_FOUND); | 1076 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_QUERY_FRIEND_NOT_FOUND); |
@@ -1114,7 +1113,7 @@ Tox_User_Status tox_friend_get_status(const Tox *tox, uint32_t friend_number, To | |||
1114 | { | 1113 | { |
1115 | const Messenger *m = tox->m; | 1114 | const Messenger *m = tox->m; |
1116 | 1115 | ||
1117 | int ret = m_get_userstatus(m, friend_number); | 1116 | const int ret = m_get_userstatus(m, friend_number); |
1118 | 1117 | ||
1119 | if (ret == USERSTATUS_INVALID) { | 1118 | if (ret == USERSTATUS_INVALID) { |
1120 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_QUERY_FRIEND_NOT_FOUND); | 1119 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_QUERY_FRIEND_NOT_FOUND); |
@@ -1134,7 +1133,7 @@ Tox_Connection tox_friend_get_connection_status(const Tox *tox, uint32_t friend_ | |||
1134 | { | 1133 | { |
1135 | const Messenger *m = tox->m; | 1134 | const Messenger *m = tox->m; |
1136 | 1135 | ||
1137 | int ret = m_get_friend_connectionstatus(m, friend_number); | 1136 | const int ret = m_get_friend_connectionstatus(m, friend_number); |
1138 | 1137 | ||
1139 | if (ret == -1) { | 1138 | if (ret == -1) { |
1140 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_QUERY_FRIEND_NOT_FOUND); | 1139 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_QUERY_FRIEND_NOT_FOUND); |
@@ -1153,7 +1152,7 @@ void tox_callback_friend_connection_status(Tox *tox, tox_friend_connection_statu | |||
1153 | bool tox_friend_get_typing(const Tox *tox, uint32_t friend_number, Tox_Err_Friend_Query *error) | 1152 | bool tox_friend_get_typing(const Tox *tox, uint32_t friend_number, Tox_Err_Friend_Query *error) |
1154 | { | 1153 | { |
1155 | const Messenger *m = tox->m; | 1154 | const Messenger *m = tox->m; |
1156 | int ret = m_get_istyping(m, friend_number); | 1155 | const int ret = m_get_istyping(m, friend_number); |
1157 | 1156 | ||
1158 | if (ret == -1) { | 1157 | if (ret == -1) { |
1159 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_QUERY_FRIEND_NOT_FOUND); | 1158 | SET_ERROR_PARAMETER(error, TOX_ERR_FRIEND_QUERY_FRIEND_NOT_FOUND); |
@@ -1264,7 +1263,7 @@ bool tox_file_control(Tox *tox, uint32_t friend_number, uint32_t file_number, To | |||
1264 | Tox_Err_File_Control *error) | 1263 | Tox_Err_File_Control *error) |
1265 | { | 1264 | { |
1266 | Messenger *m = tox->m; | 1265 | Messenger *m = tox->m; |
1267 | int ret = file_control(m, friend_number, file_number, control); | 1266 | const int ret = file_control(m, friend_number, file_number, control); |
1268 | 1267 | ||
1269 | if (ret == 0) { | 1268 | if (ret == 0) { |
1270 | SET_ERROR_PARAMETER(error, TOX_ERR_FILE_CONTROL_OK); | 1269 | SET_ERROR_PARAMETER(error, TOX_ERR_FILE_CONTROL_OK); |
@@ -1313,7 +1312,7 @@ bool tox_file_seek(Tox *tox, uint32_t friend_number, uint32_t file_number, uint6 | |||
1313 | Tox_Err_File_Seek *error) | 1312 | Tox_Err_File_Seek *error) |
1314 | { | 1313 | { |
1315 | Messenger *m = tox->m; | 1314 | Messenger *m = tox->m; |
1316 | int ret = file_seek(m, friend_number, file_number, position); | 1315 | const int ret = file_seek(m, friend_number, file_number, position); |
1317 | 1316 | ||
1318 | if (ret == 0) { | 1317 | if (ret == 0) { |
1319 | SET_ERROR_PARAMETER(error, TOX_ERR_FILE_SEEK_OK); | 1318 | SET_ERROR_PARAMETER(error, TOX_ERR_FILE_SEEK_OK); |
@@ -1365,7 +1364,7 @@ bool tox_file_get_file_id(const Tox *tox, uint32_t friend_number, uint32_t file_ | |||
1365 | } | 1364 | } |
1366 | 1365 | ||
1367 | const Messenger *m = tox->m; | 1366 | const Messenger *m = tox->m; |
1368 | int ret = file_get_id(m, friend_number, file_number, file_id); | 1367 | const int ret = file_get_id(m, friend_number, file_number, file_id); |
1369 | 1368 | ||
1370 | if (ret == 0) { | 1369 | if (ret == 0) { |
1371 | SET_ERROR_PARAMETER(error, TOX_ERR_FILE_GET_OK); | 1370 | SET_ERROR_PARAMETER(error, TOX_ERR_FILE_GET_OK); |
@@ -1398,7 +1397,7 @@ uint32_t tox_file_send(Tox *tox, uint32_t friend_number, uint32_t kind, uint64_t | |||
1398 | } | 1397 | } |
1399 | 1398 | ||
1400 | Messenger *m = tox->m; | 1399 | Messenger *m = tox->m; |
1401 | long int file_num = new_filesender(m, friend_number, kind, file_size, file_id, filename, filename_length); | 1400 | const long int file_num = new_filesender(m, friend_number, kind, file_size, file_id, filename, filename_length); |
1402 | 1401 | ||
1403 | if (file_num >= 0) { | 1402 | if (file_num >= 0) { |
1404 | SET_ERROR_PARAMETER(error, TOX_ERR_FILE_SEND_OK); | 1403 | SET_ERROR_PARAMETER(error, TOX_ERR_FILE_SEND_OK); |
@@ -1431,7 +1430,7 @@ bool tox_file_send_chunk(Tox *tox, uint32_t friend_number, uint32_t file_number, | |||
1431 | size_t length, Tox_Err_File_Send_Chunk *error) | 1430 | size_t length, Tox_Err_File_Send_Chunk *error) |
1432 | { | 1431 | { |
1433 | Messenger *m = tox->m; | 1432 | Messenger *m = tox->m; |
1434 | int ret = file_data(m, friend_number, file_number, position, data, length); | 1433 | const int ret = file_data(m, friend_number, file_number, position, data, length); |
1435 | 1434 | ||
1436 | if (ret == 0) { | 1435 | if (ret == 0) { |
1437 | SET_ERROR_PARAMETER(error, TOX_ERR_FILE_SEND_CHUNK_OK); | 1436 | SET_ERROR_PARAMETER(error, TOX_ERR_FILE_SEND_CHUNK_OK); |
@@ -1520,7 +1519,7 @@ void tox_callback_conference_peer_list_changed(Tox *tox, tox_conference_peer_lis | |||
1520 | uint32_t tox_conference_new(Tox *tox, Tox_Err_Conference_New *error) | 1519 | uint32_t tox_conference_new(Tox *tox, Tox_Err_Conference_New *error) |
1521 | { | 1520 | { |
1522 | Messenger *m = tox->m; | 1521 | Messenger *m = tox->m; |
1523 | int ret = add_groupchat(m->conferences_object, GROUPCHAT_TYPE_TEXT); | 1522 | const int ret = add_groupchat(m->conferences_object, GROUPCHAT_TYPE_TEXT); |
1524 | 1523 | ||
1525 | if (ret == -1) { | 1524 | if (ret == -1) { |
1526 | SET_ERROR_PARAMETER(error, TOX_ERR_CONFERENCE_NEW_INIT); | 1525 | SET_ERROR_PARAMETER(error, TOX_ERR_CONFERENCE_NEW_INIT); |
@@ -1534,7 +1533,7 @@ uint32_t tox_conference_new(Tox *tox, Tox_Err_Conference_New *error) | |||
1534 | bool tox_conference_delete(Tox *tox, uint32_t conference_number, Tox_Err_Conference_Delete *error) | 1533 | bool tox_conference_delete(Tox *tox, uint32_t conference_number, Tox_Err_Conference_Delete *error) |
1535 | { | 1534 | { |
1536 | Messenger *m = tox->m; | 1535 | Messenger *m = tox->m; |
1537 | int ret = del_groupchat(m->conferences_object, conference_number, true); | 1536 | const int ret = del_groupchat(m->conferences_object, conference_number, true); |
1538 | 1537 | ||
1539 | if (ret == -1) { | 1538 | if (ret == -1) { |
1540 | SET_ERROR_PARAMETER(error, TOX_ERR_CONFERENCE_DELETE_CONFERENCE_NOT_FOUND); | 1539 | SET_ERROR_PARAMETER(error, TOX_ERR_CONFERENCE_DELETE_CONFERENCE_NOT_FOUND); |
@@ -1548,7 +1547,7 @@ bool tox_conference_delete(Tox *tox, uint32_t conference_number, Tox_Err_Confere | |||
1548 | uint32_t tox_conference_peer_count(const Tox *tox, uint32_t conference_number, Tox_Err_Conference_Peer_Query *error) | 1547 | uint32_t tox_conference_peer_count(const Tox *tox, uint32_t conference_number, Tox_Err_Conference_Peer_Query *error) |
1549 | { | 1548 | { |
1550 | const Messenger *m = tox->m; | 1549 | const Messenger *m = tox->m; |
1551 | int ret = group_number_peers(m->conferences_object, conference_number, false); | 1550 | const int ret = group_number_peers(m->conferences_object, conference_number, false); |
1552 | 1551 | ||
1553 | if (ret == -1) { | 1552 | if (ret == -1) { |
1554 | SET_ERROR_PARAMETER(error, TOX_ERR_CONFERENCE_PEER_QUERY_CONFERENCE_NOT_FOUND); | 1553 | SET_ERROR_PARAMETER(error, TOX_ERR_CONFERENCE_PEER_QUERY_CONFERENCE_NOT_FOUND); |
@@ -1563,7 +1562,7 @@ size_t tox_conference_peer_get_name_size(const Tox *tox, uint32_t conference_num | |||
1563 | Tox_Err_Conference_Peer_Query *error) | 1562 | Tox_Err_Conference_Peer_Query *error) |
1564 | { | 1563 | { |
1565 | const Messenger *m = tox->m; | 1564 | const Messenger *m = tox->m; |
1566 | int ret = group_peername_size(m->conferences_object, conference_number, peer_number, false); | 1565 | const int ret = group_peername_size(m->conferences_object, conference_number, peer_number, false); |
1567 | 1566 | ||
1568 | switch (ret) { | 1567 | switch (ret) { |
1569 | case -1: | 1568 | case -1: |
@@ -1583,7 +1582,7 @@ bool tox_conference_peer_get_name(const Tox *tox, uint32_t conference_number, ui | |||
1583 | Tox_Err_Conference_Peer_Query *error) | 1582 | Tox_Err_Conference_Peer_Query *error) |
1584 | { | 1583 | { |
1585 | const Messenger *m = tox->m; | 1584 | const Messenger *m = tox->m; |
1586 | int ret = group_peername(m->conferences_object, conference_number, peer_number, name, false); | 1585 | const int ret = group_peername(m->conferences_object, conference_number, peer_number, name, false); |
1587 | 1586 | ||
1588 | switch (ret) { | 1587 | switch (ret) { |
1589 | case -1: | 1588 | case -1: |
@@ -1603,7 +1602,7 @@ bool tox_conference_peer_get_public_key(const Tox *tox, uint32_t conference_numb | |||
1603 | uint8_t *public_key, Tox_Err_Conference_Peer_Query *error) | 1602 | uint8_t *public_key, Tox_Err_Conference_Peer_Query *error) |
1604 | { | 1603 | { |
1605 | const Messenger *m = tox->m; | 1604 | const Messenger *m = tox->m; |
1606 | int ret = group_peer_pubkey(m->conferences_object, conference_number, peer_number, public_key, false); | 1605 | const int ret = group_peer_pubkey(m->conferences_object, conference_number, peer_number, public_key, false); |
1607 | 1606 | ||
1608 | switch (ret) { | 1607 | switch (ret) { |
1609 | case -1: | 1608 | case -1: |
@@ -1623,7 +1622,7 @@ bool tox_conference_peer_number_is_ours(const Tox *tox, uint32_t conference_numb | |||
1623 | Tox_Err_Conference_Peer_Query *error) | 1622 | Tox_Err_Conference_Peer_Query *error) |
1624 | { | 1623 | { |
1625 | const Messenger *m = tox->m; | 1624 | const Messenger *m = tox->m; |
1626 | int ret = group_peernumber_is_ours(m->conferences_object, conference_number, peer_number); | 1625 | const int ret = group_peernumber_is_ours(m->conferences_object, conference_number, peer_number); |
1627 | 1626 | ||
1628 | switch (ret) { | 1627 | switch (ret) { |
1629 | case -1: | 1628 | case -1: |
@@ -1647,7 +1646,7 @@ uint32_t tox_conference_offline_peer_count(const Tox *tox, uint32_t conference_n | |||
1647 | Tox_Err_Conference_Peer_Query *error) | 1646 | Tox_Err_Conference_Peer_Query *error) |
1648 | { | 1647 | { |
1649 | const Messenger *m = tox->m; | 1648 | const Messenger *m = tox->m; |
1650 | int ret = group_number_peers(m->conferences_object, conference_number, true); | 1649 | const int ret = group_number_peers(m->conferences_object, conference_number, true); |
1651 | 1650 | ||
1652 | if (ret == -1) { | 1651 | if (ret == -1) { |
1653 | SET_ERROR_PARAMETER(error, TOX_ERR_CONFERENCE_PEER_QUERY_CONFERENCE_NOT_FOUND); | 1652 | SET_ERROR_PARAMETER(error, TOX_ERR_CONFERENCE_PEER_QUERY_CONFERENCE_NOT_FOUND); |
@@ -1663,7 +1662,7 @@ size_t tox_conference_offline_peer_get_name_size(const Tox *tox, uint32_t confer | |||
1663 | Tox_Err_Conference_Peer_Query *error) | 1662 | Tox_Err_Conference_Peer_Query *error) |
1664 | { | 1663 | { |
1665 | const Messenger *m = tox->m; | 1664 | const Messenger *m = tox->m; |
1666 | int ret = group_peername_size(m->conferences_object, conference_number, offline_peer_number, true); | 1665 | const int ret = group_peername_size(m->conferences_object, conference_number, offline_peer_number, true); |
1667 | 1666 | ||
1668 | switch (ret) { | 1667 | switch (ret) { |
1669 | case -1: | 1668 | case -1: |
@@ -1684,7 +1683,7 @@ bool tox_conference_offline_peer_get_name(const Tox *tox, uint32_t conference_nu | |||
1684 | Tox_Err_Conference_Peer_Query *error) | 1683 | Tox_Err_Conference_Peer_Query *error) |
1685 | { | 1684 | { |
1686 | const Messenger *m = tox->m; | 1685 | const Messenger *m = tox->m; |
1687 | int ret = group_peername(m->conferences_object, conference_number, offline_peer_number, name, true); | 1686 | const int ret = group_peername(m->conferences_object, conference_number, offline_peer_number, name, true); |
1688 | 1687 | ||
1689 | switch (ret) { | 1688 | switch (ret) { |
1690 | case -1: | 1689 | case -1: |
@@ -1705,7 +1704,7 @@ bool tox_conference_offline_peer_get_public_key(const Tox *tox, uint32_t confere | |||
1705 | uint8_t *public_key, Tox_Err_Conference_Peer_Query *error) | 1704 | uint8_t *public_key, Tox_Err_Conference_Peer_Query *error) |
1706 | { | 1705 | { |
1707 | const Messenger *m = tox->m; | 1706 | const Messenger *m = tox->m; |
1708 | int ret = group_peer_pubkey(m->conferences_object, conference_number, offline_peer_number, public_key, true); | 1707 | const int ret = group_peer_pubkey(m->conferences_object, conference_number, offline_peer_number, public_key, true); |
1709 | 1708 | ||
1710 | switch (ret) { | 1709 | switch (ret) { |
1711 | case -1: | 1710 | case -1: |
@@ -1727,7 +1726,7 @@ uint64_t tox_conference_offline_peer_get_last_active(const Tox *tox, uint32_t co | |||
1727 | { | 1726 | { |
1728 | const Messenger *m = tox->m; | 1727 | const Messenger *m = tox->m; |
1729 | uint64_t last_active = UINT64_MAX; | 1728 | uint64_t last_active = UINT64_MAX; |
1730 | int ret = group_frozen_last_active(m->conferences_object, conference_number, offline_peer_number, &last_active); | 1729 | const int ret = group_frozen_last_active(m->conferences_object, conference_number, offline_peer_number, &last_active); |
1731 | 1730 | ||
1732 | switch (ret) { | 1731 | switch (ret) { |
1733 | case -1: | 1732 | case -1: |
@@ -1747,7 +1746,7 @@ bool tox_conference_invite(Tox *tox, uint32_t friend_number, uint32_t conference | |||
1747 | Tox_Err_Conference_Invite *error) | 1746 | Tox_Err_Conference_Invite *error) |
1748 | { | 1747 | { |
1749 | Messenger *m = tox->m; | 1748 | Messenger *m = tox->m; |
1750 | int ret = invite_friend(m->conferences_object, friend_number, conference_number); | 1749 | const int ret = invite_friend(m->conferences_object, friend_number, conference_number); |
1751 | 1750 | ||
1752 | switch (ret) { | 1751 | switch (ret) { |
1753 | case -1: | 1752 | case -1: |
@@ -1771,7 +1770,7 @@ uint32_t tox_conference_join(Tox *tox, uint32_t friend_number, const uint8_t *co | |||
1771 | Tox_Err_Conference_Join *error) | 1770 | Tox_Err_Conference_Join *error) |
1772 | { | 1771 | { |
1773 | Messenger *m = tox->m; | 1772 | Messenger *m = tox->m; |
1774 | int ret = join_groupchat(m->conferences_object, friend_number, GROUPCHAT_TYPE_TEXT, cookie, length); | 1773 | const int ret = join_groupchat(m->conferences_object, friend_number, GROUPCHAT_TYPE_TEXT, cookie, length); |
1775 | 1774 | ||
1776 | switch (ret) { | 1775 | switch (ret) { |
1777 | case -1: | 1776 | case -1: |
@@ -1840,7 +1839,7 @@ bool tox_conference_send_message(Tox *tox, uint32_t conference_number, Tox_Messa | |||
1840 | size_t tox_conference_get_title_size(const Tox *tox, uint32_t conference_number, Tox_Err_Conference_Title *error) | 1839 | size_t tox_conference_get_title_size(const Tox *tox, uint32_t conference_number, Tox_Err_Conference_Title *error) |
1841 | { | 1840 | { |
1842 | const Messenger *m = tox->m; | 1841 | const Messenger *m = tox->m; |
1843 | int ret = group_title_get_size(m->conferences_object, conference_number); | 1842 | const int ret = group_title_get_size(m->conferences_object, conference_number); |
1844 | 1843 | ||
1845 | switch (ret) { | 1844 | switch (ret) { |
1846 | case -1: | 1845 | case -1: |
@@ -1860,7 +1859,7 @@ bool tox_conference_get_title(const Tox *tox, uint32_t conference_number, uint8_ | |||
1860 | Tox_Err_Conference_Title *error) | 1859 | Tox_Err_Conference_Title *error) |
1861 | { | 1860 | { |
1862 | const Messenger *m = tox->m; | 1861 | const Messenger *m = tox->m; |
1863 | int ret = group_title_get(m->conferences_object, conference_number, title); | 1862 | const int ret = group_title_get(m->conferences_object, conference_number, title); |
1864 | 1863 | ||
1865 | switch (ret) { | 1864 | switch (ret) { |
1866 | case -1: | 1865 | case -1: |
@@ -1880,7 +1879,7 @@ bool tox_conference_set_title(Tox *tox, uint32_t conference_number, const uint8_ | |||
1880 | Tox_Err_Conference_Title *error) | 1879 | Tox_Err_Conference_Title *error) |
1881 | { | 1880 | { |
1882 | Messenger *m = tox->m; | 1881 | Messenger *m = tox->m; |
1883 | int ret = group_title_send(m->conferences_object, conference_number, title, length); | 1882 | const int ret = group_title_send(m->conferences_object, conference_number, title, length); |
1884 | 1883 | ||
1885 | switch (ret) { | 1884 | switch (ret) { |
1886 | case -1: | 1885 | case -1: |
@@ -1909,7 +1908,7 @@ size_t tox_conference_get_chatlist_size(const Tox *tox) | |||
1909 | void tox_conference_get_chatlist(const Tox *tox, uint32_t *chatlist) | 1908 | void tox_conference_get_chatlist(const Tox *tox, uint32_t *chatlist) |
1910 | { | 1909 | { |
1911 | const Messenger *m = tox->m; | 1910 | const Messenger *m = tox->m; |
1912 | size_t list_size = tox_conference_get_chatlist_size(tox); | 1911 | const size_t list_size = tox_conference_get_chatlist_size(tox); |
1913 | copy_chatlist(m->conferences_object, chatlist, list_size); | 1912 | copy_chatlist(m->conferences_object, chatlist, list_size); |
1914 | } | 1913 | } |
1915 | 1914 | ||
@@ -1917,7 +1916,7 @@ Tox_Conference_Type tox_conference_get_type(const Tox *tox, uint32_t conference_ | |||
1917 | Tox_Err_Conference_Get_Type *error) | 1916 | Tox_Err_Conference_Get_Type *error) |
1918 | { | 1917 | { |
1919 | const Messenger *m = tox->m; | 1918 | const Messenger *m = tox->m; |
1920 | int ret = group_get_type(m->conferences_object, conference_number); | 1919 | const int ret = group_get_type(m->conferences_object, conference_number); |
1921 | 1920 | ||
1922 | if (ret == -1) { | 1921 | if (ret == -1) { |
1923 | SET_ERROR_PARAMETER(error, TOX_ERR_CONFERENCE_GET_TYPE_CONFERENCE_NOT_FOUND); | 1922 | SET_ERROR_PARAMETER(error, TOX_ERR_CONFERENCE_GET_TYPE_CONFERENCE_NOT_FOUND); |
@@ -1946,7 +1945,7 @@ uint32_t tox_conference_by_id(const Tox *tox, const uint8_t *id, Tox_Err_Confere | |||
1946 | return UINT32_MAX; | 1945 | return UINT32_MAX; |
1947 | } | 1946 | } |
1948 | 1947 | ||
1949 | int32_t ret = conference_by_id(tox->m->conferences_object, id); | 1948 | const int32_t ret = conference_by_id(tox->m->conferences_object, id); |
1950 | 1949 | ||
1951 | if (ret == -1) { | 1950 | if (ret == -1) { |
1952 | SET_ERROR_PARAMETER(error, TOX_ERR_CONFERENCE_BY_ID_NOT_FOUND); | 1951 | SET_ERROR_PARAMETER(error, TOX_ERR_CONFERENCE_BY_ID_NOT_FOUND); |
@@ -2031,7 +2030,7 @@ bool tox_friend_send_lossy_packet(Tox *tox, uint32_t friend_number, const uint8_ | |||
2031 | return 0; | 2030 | return 0; |
2032 | } | 2031 | } |
2033 | 2032 | ||
2034 | int ret = m_send_custom_lossy_packet(m, friend_number, data, length); | 2033 | const int ret = m_send_custom_lossy_packet(m, friend_number, data, length); |
2035 | 2034 | ||
2036 | set_custom_packet_error(ret, error); | 2035 | set_custom_packet_error(ret, error); |
2037 | 2036 | ||
@@ -2062,7 +2061,7 @@ bool tox_friend_send_lossless_packet(Tox *tox, uint32_t friend_number, const uin | |||
2062 | return 0; | 2061 | return 0; |
2063 | } | 2062 | } |
2064 | 2063 | ||
2065 | int ret = send_custom_lossless_packet(m, friend_number, data, length); | 2064 | const int ret = send_custom_lossless_packet(m, friend_number, data, length); |
2066 | 2065 | ||
2067 | set_custom_packet_error(ret, error); | 2066 | set_custom_packet_error(ret, error); |
2068 | 2067 | ||
@@ -2089,7 +2088,7 @@ void tox_self_get_dht_id(const Tox *tox, uint8_t *dht_id) | |||
2089 | uint16_t tox_self_get_udp_port(const Tox *tox, Tox_Err_Get_Port *error) | 2088 | uint16_t tox_self_get_udp_port(const Tox *tox, Tox_Err_Get_Port *error) |
2090 | { | 2089 | { |
2091 | const Messenger *m = tox->m; | 2090 | const Messenger *m = tox->m; |
2092 | uint16_t port = net_htons(net_port(m->net)); | 2091 | const uint16_t port = net_htons(net_port(m->net)); |
2093 | 2092 | ||
2094 | if (port) { | 2093 | if (port) { |
2095 | SET_ERROR_PARAMETER(error, TOX_ERR_GET_PORT_OK); | 2094 | SET_ERROR_PARAMETER(error, TOX_ERR_GET_PORT_OK); |