diff options
author | iphydf <iphydf@users.noreply.github.com> | 2018-01-25 03:06:09 +0000 |
---|---|---|
committer | iphydf <iphydf@users.noreply.github.com> | 2018-01-25 09:22:19 +0000 |
commit | a640ed106a74347e08c10e62d7ec9eee9e90e43b (patch) | |
tree | a01702ecb07ff1cebd9a914ccbf90dba315d7e99 | |
parent | 67cf3951633dd4c8444c6460ac94310e382f82f3 (diff) |
Remove dead return statement.
Turning this code:
```c
if (cond) { ... return 0; }
if (!cond) { ... return 0; }
return -1;
```
into:
```c
if (cond) { ... return 0; }
else { ... return 0; }
```
The `return -1` in the first variant can never happen.
-rw-r--r-- | toxcore/group.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/toxcore/group.c b/toxcore/group.c index 543b1f0a..2186aa73 100644 --- a/toxcore/group.c +++ b/toxcore/group.c | |||
@@ -2218,10 +2218,9 @@ static unsigned int lossy_packet_not_received(Group_c *g, int peer_index, uint16 | |||
2218 | g->group[peer_index].top_lossy_number = message_number; | 2218 | g->group[peer_index].top_lossy_number = message_number; |
2219 | g->group[peer_index].bottom_lossy_number = (message_number - MAX_LOSSY_COUNT) + 1; | 2219 | g->group[peer_index].bottom_lossy_number = (message_number - MAX_LOSSY_COUNT) + 1; |
2220 | g->group[peer_index].recv_lossy[message_number % MAX_LOSSY_COUNT] = 1; | 2220 | g->group[peer_index].recv_lossy[message_number % MAX_LOSSY_COUNT] = 1; |
2221 | return 0; | ||
2222 | } | ||
2223 | 2221 | ||
2224 | if (top_distance < MAX_LOSSY_COUNT) { | 2222 | return 0; |
2223 | } else { // top_distance < MAX_LOSSY_COUNT | ||
2225 | unsigned int i; | 2224 | unsigned int i; |
2226 | 2225 | ||
2227 | for (i = g->group[peer_index].bottom_lossy_number; i != (g->group[peer_index].bottom_lossy_number + top_distance); | 2226 | for (i = g->group[peer_index].bottom_lossy_number; i != (g->group[peer_index].bottom_lossy_number + top_distance); |
@@ -2232,10 +2231,9 @@ static unsigned int lossy_packet_not_received(Group_c *g, int peer_index, uint16 | |||
2232 | g->group[peer_index].top_lossy_number = message_number; | 2231 | g->group[peer_index].top_lossy_number = message_number; |
2233 | g->group[peer_index].bottom_lossy_number = (message_number - MAX_LOSSY_COUNT) + 1; | 2232 | g->group[peer_index].bottom_lossy_number = (message_number - MAX_LOSSY_COUNT) + 1; |
2234 | g->group[peer_index].recv_lossy[message_number % MAX_LOSSY_COUNT] = 1; | 2233 | g->group[peer_index].recv_lossy[message_number % MAX_LOSSY_COUNT] = 1; |
2234 | |||
2235 | return 0; | 2235 | return 0; |
2236 | } | 2236 | } |
2237 | |||
2238 | return -1; | ||
2239 | } | 2237 | } |
2240 | 2238 | ||
2241 | static int handle_lossy(void *object, int friendcon_id, const uint8_t *data, uint16_t length, void *userdata) | 2239 | static int handle_lossy(void *object, int friendcon_id, const uint8_t *data, uint16_t length, void *userdata) |