Remove new_nonce function in favour of random_nonce.

`new_nonce` has been an alias for `random_nonce` for a while now. Having
two names for the same operation is confusing. `random_nonce` better
expresses the intent. The documentation for `new_nonce` talks about
guaranteeing that the nonce is different from previous ones, which is
incorrect, it's just quite likely to be different.

1 files changed, 1 insertions, 1 deletions

diff --git a/auto_tests/onion_test.c b/auto_tests/onion_test.c
index ee9df7a0..d84c3991 100644
--- a/auto_tests/onion_test.c
+++ b/auto_tests/onion_test.c
@@ -225,7 +225,7 @@ START_TEST(test_basic)
     Onion *onion3 = new_onion(new_DHT(NULL, new_networking(NULL, ip, 34569)));
     ck_assert_msg((onion3 != NULL), "Onion failed initializing.");
 
-    new_nonce(nonce);
+    random_nonce(nonce);
     ret = send_data_request(onion3->net, &path, nodes[3].ip_port, onion1->dht->self_public_key,
                             onion1->dht->self_public_key,
                             nonce, (const uint8_t *)"Install gentoo", sizeof("Install gentoo"));