Run Clang global static analysis on Travis.

This uses a single .cc file containing almost all the code in the
repository to perform whole program analysis.

7 files changed, 28 insertions, 323 deletions

diff --git a/auto_tests/BUILD.bazel b/auto_tests/BUILD.bazel
index 21c403ab..a5ef7645 100644
--- a/auto_tests/BUILD.bazel
+++ b/auto_tests/BUILD.bazel
@@ -25,32 +25,10 @@ test_sizes = {
     deps = [
         ":check_compat",
         ":run_auto_test",
-        "//c-toxcore/other:monolith",
         "//c-toxcore/testing:misc_tools",
         "//c-toxcore/toxav",
         "//c-toxcore/toxcore",
+        "//c-toxcore/toxcore:DHT_srcs",
         "//c-toxcore/toxencryptsave",
     ],
 ) for src in glob(["*_test.c"])]
-
-cc_library(
-    name = "monolith",
-    hdrs = glob([
-        "*.c",
-        "*.h",
-    ]),
-)
-
-cc_test(
-    name = "monolith_test",
-    size = "small",
-    srcs = ["monolith_test.cc"],
-    copts = ["-Wno-sign-compare"],
-    deps = [
-        ":check_compat",
-        ":monolith",
-        ":run_auto_test",
-        "//c-toxcore/other:monolith",
-        "//c-toxcore/testing:misc_tools",
-    ],
-)
diff --git a/auto_tests/conference_peer_nick_test.c b/auto_tests/conference_peer_nick_test.c
index 4d54f1fb..e99d3b79 100644
--- a/auto_tests/conference_peer_nick_test.c
+++ b/auto_tests/conference_peer_nick_test.c
@@ -65,7 +65,7 @@ static void rebuild_peer_list(Tox *tox)
             ck_assert_msg(err == TOX_ERR_CONFERENCE_PEER_QUERY_OK,
                           "failed to get conference peer %u's name size (conference = %u): err = %d", peer_number, conference_number, err);
 
-            uint8_t *const name = malloc(size);
+            uint8_t *const name = (uint8_t *)malloc(size);
             tox_conference_peer_get_name(tox, conference_number, peer_number, name, &err);
             ck_assert_msg(err == TOX_ERR_CONFERENCE_PEER_QUERY_OK,
                           "failed to get conference peer %u's name (conference = %u): err = %d", peer_number, conference_number, err);
diff --git a/auto_tests/conference_test.c b/auto_tests/conference_test.c
index 92e805c9..2bdee78f 100644
--- a/auto_tests/conference_test.c
+++ b/auto_tests/conference_test.c
@@ -234,7 +234,7 @@ static void test_many_group(void)
         uint32_t peer_count = tox_conference_peer_count(toxes[i], 0, nullptr);
 
         ck_assert_msg(peer_count == NUM_GROUP_TOX, "\n\tBad number of group peers (pre check)."
-                      "\n\t\t\tExpected: %u but tox_instance(%u)  only has: %u\n\n",
+                      "\n\t\t\tExpected: %d but tox_instance(%u)  only has: %u\n\n",
                       NUM_GROUP_TOX, i, (unsigned)peer_count);
 
         uint8_t title[2048];
diff --git a/auto_tests/file_transfer_test.c b/auto_tests/file_transfer_test.c
index a6e45431..94bdb42f 100644
--- a/auto_tests/file_transfer_test.c
+++ b/auto_tests/file_transfer_test.c
@@ -140,20 +140,18 @@ static void tox_file_chunk_request(Tox *tox, uint32_t friend_number, uint32_t fi
         m_send_reached = 1;
     }
 
-    TOX_ERR_FILE_SEND_CHUNK error;
     VLA(uint8_t, f_data, length);
     memset(f_data, sending_num, length);
 
-    if (tox_file_send_chunk(tox, friend_number, file_number, position, f_data, length, &error)) {
-        ++sending_num;
-        sending_pos += length;
-    } else {
-        ck_abort_msg("Could not send chunk, error num=%d pos=%d len=%d", (int)error, (int)position, (int)length);
-    }
+    TOX_ERR_FILE_SEND_CHUNK error;
+    tox_file_send_chunk(tox, friend_number, file_number, position, f_data, length, &error);
 
     if (error != TOX_ERR_FILE_SEND_CHUNK_OK) {
-        ck_abort_msg("Wrong error code");
+        ck_abort_msg("Could not send chunk, error num=%d pos=%d len=%d", (int)error, (int)position, (int)length);
     }
+
+    ++sending_num;
+    sending_pos += length;
 }
 
 
diff --git a/auto_tests/monolith_test.cc b/auto_tests/monolith_test.cc
deleted file mode 100644
index 5b1b910d..00000000
--- a/auto_tests/monolith_test.cc
+++ /dev/null
@@ -1,254 +0,0 @@
-/* Nop-test, just to make sure our code compiles as C++.
- */
-
-#ifdef __FreeBSD__
-// Include this here, because _XOPEN_SOURCE hides symbols we need.
-//
-// https://lists.freebsd.org/pipermail/freebsd-standards/2004-March/000474.html.
-#include <net/if.h>
-#endif
-
-#ifdef __APPLE__
-#define _DARWIN_C_SOURCE
-#endif
-
-#ifdef HAVE_CONFIG_H
-#include "config.h"
-#endif
-
-#include "../other/monolith.h"
-#define DHT_C_INCLUDED
-
-#include "../testing/misc_tools.c"
-#include "check_compat.h"
-
-#include <ctype.h>
-
-namespace TCP_test {
-int main(void);
-#include "TCP_test.c"
-}  // namespace TCP_test
-namespace bootstrap_test {
-int main(void);
-#include "bootstrap_test.c"
-}  // namespace bootstrap_test
-namespace conference_simple_test {
-int main(void);
-#include "conference_simple_test.c"
-}  // namespace conference_simple_test
-namespace conference_test {
-int main(void);
-#include "conference_test.c"
-}  // namespace conference_test
-namespace crypto_test {
-int main(void);
-#include "crypto_test.c"
-}  // namespace crypto_test
-namespace dht_test {
-int main(void);
-#include "dht_test.c"
-}  // namespace dht_test
-namespace encryptsave_test {
-int main(void);
-#include "encryptsave_test.c"
-}  // namespace encryptsave_test
-namespace file_saving_test {
-int main(void);
-#include "file_saving_test.c"
-}  // namespace file_saving_test
-namespace friend_request_test {
-int main(void);
-#include "friend_request_test.c"
-}  // namespace friend_request_test
-namespace lan_discovery_test {
-int main(void);
-#include "lan_discovery_test.c"
-}  // namespace lan_discovery_test
-namespace lossless_packet_test {
-int main(void);
-#include "lossless_packet_test.c"
-}  // namespace lossless_packet_test
-namespace lossy_packet_test {
-int main(void);
-#include "lossy_packet_test.c"
-}  // namespace lossy_packet_test
-namespace messenger_test {
-int main(void);
-#include "messenger_test.c"
-}  // namespace messenger_test
-namespace network_test {
-int main(void);
-#include "network_test.c"
-}  // namespace network_test
-namespace onion_test {
-int main(void);
-#include "onion_test.c"
-}  // namespace onion_test
-namespace save_friend_test {
-int main(void);
-#include "save_friend_test.c"
-}  // namespace save_friend_test
-namespace save_load_test {
-int main(void);
-#include "save_load_test.c"
-}  // namespace save_load_test
-namespace send_message_test {
-int main(void);
-#include "send_message_test.c"
-}  // namespace send_message_test
-namespace set_name_test {
-int main(void);
-#include "set_name_test.c"
-}  // namespace set_name_test
-namespace set_status_message_test {
-int main(void);
-#include "set_status_message_test.c"
-}  // namespace set_status_message_test
-namespace skeleton_test {
-int main(void);
-#include "skeleton_test.c"
-}  // namespace skeleton_test
-namespace toxav_basic_test {
-int main(void);
-#include "toxav_basic_test.c"
-}  // namespace toxav_basic_test
-namespace toxav_many_test {
-int main(void);
-#include "toxav_many_test.c"
-}  // namespace toxav_many_test
-namespace tox_many_tcp_test {
-int main(void);
-#include "tox_many_tcp_test.c"
-}  // namespace tox_many_tcp_test
-namespace tox_many_test {
-int main(void);
-#include "tox_many_test.c"
-}  // namespace tox_many_test
-namespace tox_one_test {
-int main(void);
-#include "tox_one_test.c"
-}  // namespace tox_one_test
-namespace tox_strncasecmp_test {
-int main(void);
-#include "tox_strncasecmp_test.c"
-}  // namespace tox_strncasecmp_test
-namespace typing_test {
-int main(void);
-#include "typing_test.c"
-}  // namespace typing_test
-namespace version_test {
-int main(void);
-#include "version_test.c"
-}  // namespace version_test
-
-#define PRINT_SIZE 0
-
-template <typename T, size_t Expected, size_t Actual = sizeof(T)>
-void check_size(char const *type) {
-#if PRINT_SIZE
-  printf("CHECK_SIZE(%s, %zu);\n", type, Actual);
-#else
-  static_assert(Actual == Expected, "Bad sizeof - see template expansion errors for details");
-#endif
-}
-
-#define CHECK_SIZE(TYPE, SIZE) check_size<TYPE, SIZE>(#TYPE)
-
-/**
- * The main function static-asserts that we are aware of all the sizes of all
- * the structs it toxcore. If you find this failing after you make a change,
- * switch on the PRINT_SIZE above and copy the number into this function.
- */
-int main(int argc, char *argv[]) {
-  static_assert(sizeof(uint64_t) >= sizeof(size_t),
-                "Assumption violated: size_t is more than 64 bits wide");
-
-#if defined(__x86_64__) && defined(__LP64__)
-  // toxcore/DHT
-  CHECK_SIZE(Client_data, 496);
-  CHECK_SIZE(Cryptopacket_Handler, 16);
-  CHECK_SIZE(DHT, 676528);
-  CHECK_SIZE(DHT_Friend, 5104);
-  CHECK_SIZE(Hardening, 144);
-  CHECK_SIZE(IPPTs, 40);
-  CHECK_SIZE(IPPTsPng, 232);
-  CHECK_SIZE(NAT, 48);
-  CHECK_SIZE(Node_format, 64);
-  CHECK_SIZE(Shared_Key, 80);
-  CHECK_SIZE(Shared_Keys, 81920);
-  // toxcore/friend_connection
-  CHECK_SIZE(Friend_Conn, 1784);
-  CHECK_SIZE(Friend_Connections, 72);
-  // toxcore/friend_requests
-  CHECK_SIZE(Friend_Requests, 1080);
-  // toxcore/group
-  CHECK_SIZE(Group_c, 728);
-  CHECK_SIZE(Group_Chats, 2120);
-  CHECK_SIZE(Group_Peer, 480);
-  // toxcore/list
-  CHECK_SIZE(BS_List, 32);
-  // toxcore/logger
-  CHECK_SIZE(Logger, 24);
-  // toxcore/Messenger
-  CHECK_SIZE(File_Transfers, 72);
-  CHECK_SIZE(Friend, 39264);
-  CHECK_SIZE(Messenger, 2008);
-  CHECK_SIZE(Messenger_Options, 72);
-  CHECK_SIZE(Receipts, 16);
-  // toxcore/net_crypto
-#ifdef __linux__
-  CHECK_SIZE(Crypto_Connection, 525392);
-  CHECK_SIZE(Net_Crypto, 272);
-#endif
-  CHECK_SIZE(New_Connection, 168);
-  CHECK_SIZE(Packet_Data, 1384);
-  CHECK_SIZE(Packets_Array, 262152);
-  // toxcore/network
-  CHECK_SIZE(IP, 24);
-  CHECK_SIZE(IP4, 4);
-#if USE_IPV6
-  CHECK_SIZE(IP6, 16);
-#endif
-  CHECK_SIZE(IP_Port, 32);
-  CHECK_SIZE(Networking_Core, 4112);
-  CHECK_SIZE(Packet_Handler, 16);
-  // toxcore/onion_announce
-  CHECK_SIZE(Cmp_data, 296);
-  CHECK_SIZE(Onion_Announce, 128048);
-  CHECK_SIZE(Onion_Announce_Entry, 288);
-  // toxcore/onion_client
-  CHECK_SIZE(Last_Pinged, 40);
-  CHECK_SIZE(Onion_Client, 15816);
-  CHECK_SIZE(Onion_Client_Cmp_data, 176);
-  CHECK_SIZE(Onion_Client_Paths, 2520);
-  CHECK_SIZE(Onion_Friend, 1936);
-  CHECK_SIZE(Onion_Friend, 1936);
-  CHECK_SIZE(Onion_Node, 168);
-  // toxcore/onion
-  CHECK_SIZE(Onion, 245832);
-  CHECK_SIZE(Onion_Path, 392);
-  // toxcore/ping_array
-  CHECK_SIZE(Ping_Array, 24);
-  CHECK_SIZE(Ping_Array_Entry, 32);
-  // toxcore/ping
-  CHECK_SIZE(Ping, 2072);
-  // toxcore/TCP_client
-  CHECK_SIZE(TCP_Client_Connection, 12064);
-  CHECK_SIZE(TCP_Proxy_Info, 40);
-  // toxcore/TCP_connection
-  CHECK_SIZE(TCP_con, 112);
-  CHECK_SIZE(TCP_Connections, 200);
-  CHECK_SIZE(TCP_Connection_to, 112);
-  // toxcore/TCP_server
-  CHECK_SIZE(TCP_Priority_List, 16);
-  CHECK_SIZE(TCP_Secure_Connection, 11816);
-#ifdef TCP_SERVER_USE_EPOLL
-  CHECK_SIZE(TCP_Server, 6049968);  // 6MB!
-#else
-  CHECK_SIZE(TCP_Server, 6049952);  // 6MB!
-#endif
-  // toxcore/tox
-  CHECK_SIZE(Tox_Options, 64);
-#endif
-  return 0;
-}
diff --git a/auto_tests/tox_many_test.c b/auto_tests/tox_many_test.c
index ff217e87..49933234 100644
--- a/auto_tests/tox_many_test.c
+++ b/auto_tests/tox_many_test.c
@@ -24,16 +24,16 @@ static void accept_friend_request(Tox *m, const uint8_t *public_key, const uint8
 }
 
 
-#define NUM_TOXES 90
-#define NUM_FRIENDS 50
+#define TCP_TEST_NUM_TOXES 90
+#define TCP_TEST_NUM_FRIENDS 50
 
 static void test_many_clients(void)
 {
     time_t cur_time = time(nullptr);
-    Tox *toxes[NUM_TOXES];
-    uint32_t index[NUM_TOXES];
+    Tox *toxes[TCP_TEST_NUM_TOXES];
+    uint32_t index[TCP_TEST_NUM_TOXES];
 
-    for (uint32_t i = 0; i < NUM_TOXES; ++i) {
+    for (uint32_t i = 0; i < TCP_TEST_NUM_TOXES; ++i) {
         index[i] = i + 1;
         toxes[i] = tox_new_log(nullptr, nullptr, &index[i]);
         ck_assert_msg(toxes[i] != nullptr, "failed to create tox instances %u", i);
@@ -43,22 +43,22 @@ static void test_many_clients(void)
     struct {
         uint16_t tox1;
         uint16_t tox2;
-    } pairs[NUM_FRIENDS];
+    } pairs[TCP_TEST_NUM_FRIENDS];
 
     uint8_t address[TOX_ADDRESS_SIZE];
 
     uint32_t num_f = 0;
 
-    for (uint32_t i = 0; i < NUM_TOXES; ++i) {
+    for (uint32_t i = 0; i < TCP_TEST_NUM_TOXES; ++i) {
         num_f += tox_self_get_friend_list_size(toxes[i]);
     }
 
     ck_assert_msg(num_f == 0, "bad num friends: %u", num_f);
 
-    for (uint32_t i = 0; i < NUM_FRIENDS; ++i) {
+    for (uint32_t i = 0; i < TCP_TEST_NUM_FRIENDS; ++i) {
 loop_top:
-        pairs[i].tox1 = random_u32() % NUM_TOXES;
-        pairs[i].tox2 = (pairs[i].tox1 + random_u32() % (NUM_TOXES - 1) + 1) % NUM_TOXES;
+        pairs[i].tox1 = random_u32() % TCP_TEST_NUM_TOXES;
+        pairs[i].tox2 = (pairs[i].tox1 + random_u32() % (TCP_TEST_NUM_TOXES - 1) + 1) % TCP_TEST_NUM_TOXES;
 
         for (uint32_t j = 0; j < i; ++j) {
             if (pairs[j].tox2 == pairs[i].tox1 && pairs[j].tox1 == pairs[i].tox2) {
@@ -84,18 +84,18 @@ loop_top:
         ck_assert_msg(num != UINT32_MAX && test == TOX_ERR_FRIEND_ADD_OK, "failed to add friend error code: %i", test);
     }
 
-    for (uint32_t i = 0; i < NUM_TOXES; ++i) {
+    for (uint32_t i = 0; i < TCP_TEST_NUM_TOXES; ++i) {
         num_f += tox_self_get_friend_list_size(toxes[i]);
     }
 
-    ck_assert_msg(num_f == NUM_FRIENDS, "bad num friends: %u", num_f);
+    ck_assert_msg(num_f == TCP_TEST_NUM_FRIENDS, "bad num friends: %u", num_f);
 
     uint16_t last_count = 0;
 
     while (1) {
         uint16_t counter = 0;
 
-        for (uint32_t i = 0; i < NUM_TOXES; ++i) {
+        for (uint32_t i = 0; i < TCP_TEST_NUM_TOXES; ++i) {
             for (uint32_t j = 0; j < tox_self_get_friend_list_size(toxes[i]); ++j) {
                 if (tox_friend_get_connection_status(toxes[i], j, nullptr) == TOX_CONNECTION_UDP) {
                     ++counter;
@@ -108,18 +108,18 @@ loop_top:
             last_count = counter;
         }
 
-        if (counter == NUM_FRIENDS * 2) {
+        if (counter == TCP_TEST_NUM_FRIENDS * 2) {
             break;
         }
 
-        for (uint32_t i = 0; i < NUM_TOXES; ++i) {
+        for (uint32_t i = 0; i < TCP_TEST_NUM_TOXES; ++i) {
             tox_iterate(toxes[i], nullptr);
         }
 
         c_sleep(50);
     }
 
-    for (uint32_t i = 0; i < NUM_TOXES; ++i) {
+    for (uint32_t i = 0; i < TCP_TEST_NUM_TOXES; ++i) {
         tox_kill(toxes[i]);
     }
 
diff --git a/auto_tests/tox_one_test.c b/auto_tests/tox_one_test.c
index 69ec4461..28f18c29 100644
--- a/auto_tests/tox_one_test.c
+++ b/auto_tests/tox_one_test.c
@@ -28,7 +28,7 @@ static void set_random_name_and_status_message(Tox *tox, uint8_t *name, uint8_t
     }
 }
 
-START_TEST(test_one)
+static void test_one(void)
 {
     uint8_t name[TOX_MAX_NAME_LENGTH];
     uint8_t status_message[TOX_MAX_STATUS_MESSAGE_LENGTH];
@@ -128,30 +128,13 @@ START_TEST(test_one)
     tox_kill(tox1);
     tox_kill(tox2);
 }
-END_TEST
 
 
-static Suite *tox_suite(void)
-{
-    Suite *s = suite_create("Tox one");
-
-    DEFTESTCASE(one);
-
-    return s;
-}
-
 int main(void)
 {
     setvbuf(stdout, nullptr, _IONBF, 0);
 
-    Suite *tox = tox_suite();
-    SRunner *test_runner = srunner_create(tox);
-
-    int number_failed = 0;
-    srunner_run_all(test_runner, CK_NORMAL);
-    number_failed = srunner_ntests_failed(test_runner);
-
-    srunner_free(test_runner);
+    test_one();
 
-    return number_failed;
+    return 0;
 }