Run Clang global static analysis on Travis.

This uses a single .cc file containing almost all the code in the
repository to perform whole program analysis.

3 files changed, 9 insertions, 10 deletions

diff --git a/other/fun/cracker.c b/other/fun/cracker.c
index 502a8af0..fd9564f6 100644
--- a/other/fun/cracker.c
+++ b/other/fun/cracker.c
@@ -20,7 +20,7 @@
 #include "../../testing/misc_tools.h"
 #include "../../toxcore/ccompat.h"
 
-void print_key(uint8_t *client_id)
+static void print_key(uint8_t *client_id)
 {
     uint32_t j;
 
diff --git a/other/fun/sign.c b/other/fun/sign.c
index 007d19a0..547af311 100644
--- a/other/fun/sign.c
+++ b/other/fun/sign.c
@@ -21,7 +21,7 @@
 #include "../../testing/misc_tools.h" // hex_string_to_bin
 #include "../../toxcore/ccompat.h"
 
-int load_file(char *filename, char **result)
+static int load_file(char *filename, unsigned char **result)
 {
     int size = 0;
     FILE *f = fopen(filename, "rb");
@@ -34,7 +34,7 @@ int load_file(char *filename, char **result)
     fseek(f, 0, SEEK_END);
     size = ftell(f);
     fseek(f, 0, SEEK_SET);
-    *result = (char *)malloc(size + 1);
+    *result = (unsigned char *)malloc(size + 1);
 
     if (size != fread(*result, sizeof(char), size, f)) {
         free(*result);
@@ -72,7 +72,7 @@ int main(int argc, char *argv[])
 
     if (argc == 5 && argv[1][0] == 's') {
         unsigned char *secret_key = hex_string_to_bin(argv[2]);
-        char *data;
+        unsigned char *data;
         int size = load_file(argv[3], &data);
 
         if (size < 0) {
@@ -80,7 +80,7 @@ int main(int argc, char *argv[])
         }
 
         unsigned long long smlen;
-        char *sm = malloc(size + crypto_sign_ed25519_BYTES * 2);
+        unsigned char *sm = (unsigned char *)malloc(size + crypto_sign_ed25519_BYTES * 2);
         crypto_sign_ed25519(sm, &smlen, data, size, secret_key);
         free(secret_key);
 
@@ -106,19 +106,18 @@ int main(int argc, char *argv[])
 
     if (argc == 4 && argv[1][0] == 'c') {
         unsigned char *public_key = hex_string_to_bin(argv[2]);
-        char *data;
+        unsigned char *data;
         int size = load_file(argv[3], &data);
 
         if (size < 0) {
             goto fail;
         }
 
-        char *signe = malloc(size + crypto_sign_ed25519_BYTES);
+        unsigned char *signe = (unsigned char *)malloc(size + crypto_sign_ed25519_BYTES);
         memcpy(signe, data + size - crypto_sign_ed25519_BYTES,
                crypto_sign_ed25519_BYTES); // Move signature from end to beginning of file.
         memcpy(signe + crypto_sign_ed25519_BYTES, data, size - crypto_sign_ed25519_BYTES);
-        unsigned long long smlen;
-        char *m = malloc(size);
+        unsigned char *m = (unsigned char *)malloc(size);
         unsigned long long mlen;
 
         if (crypto_sign_ed25519_open(m, &mlen, signe, size, public_key) == -1) {
diff --git a/other/fun/strkey.c b/other/fun/strkey.c
index ef54a404..d769318a 100644
--- a/other/fun/strkey.c
+++ b/other/fun/strkey.c
@@ -43,7 +43,7 @@
 
 #define PRINT_TRIES_COUNT
 
-void print_key(unsigned char *key)
+static void print_key(unsigned char *key)
 {
     size_t i;