took out several strlen() calls out of the loop; replaced int's with size_t where needed

1 files changed, 6 insertions, 5 deletions

diff --git a/testing/DHT_cryptosendfiletest.c b/testing/DHT_cryptosendfiletest.c
index b06ddea5..5c3a0256 100644
--- a/testing/DHT_cryptosendfiletest.c
+++ b/testing/DHT_cryptosendfiletest.c
@@ -60,14 +60,15 @@ void printip(IP_Port ip_port)
     printf("\nIP: %u.%u.%u.%u Port: %u\n",ip_port.ip.c[0],ip_port.ip.c[1],ip_port.ip.c[2],ip_port.ip.c[3],ntohs(ip_port.port));
 }
 
-/* horrible function from one of my first C programs.
- *only here because I was too lazy to write a proper one. */
+//TODO: rewrite
 unsigned char * hex_string_to_bin(char hex_string[])
 {
-    unsigned char * val = malloc(strlen(hex_string));
+    size_t len = strlen(hex_string);
+    unsigned char * val = malloc(len);
     char * pos = hex_string;
     int i=0;
-    while(i < strlen(hex_string)) {
+    while(i < len)
+    {
         sscanf(pos,"%2hhx",&val[i]);
         pos+=2;
         i++;
@@ -239,4 +240,4 @@ int main(int argc, char *argv[])
     
     shutdown_networking();
     return 0;   
-}
\ No newline at end of file
+}