Style fixes in TCP code; remove MIN and PAIR from util.h.

* Moved PAIR to toxav, where it's used (but really this should die).
* Replace most MIN calls with typed `min_*` calls. Didn't replace the
  ones where the desired semantics are unclear. Moved the MIN macro to
  the one place where it's still used.
* Avoid assignments in `while` loops. Instead, factored out the loop body
  into a separate `bool`-returning function.
* Use named types for callbacks (`_cb` types).
* Avoid assignments in `if` conditions.
* Removed `MAKE_REALLOC` and expanded its two calls. We can't have
  templates in C, and this fake templating is ugly and hard to analyse
  and debug (it expands on a single line).
* Moved epoll system include to the .c file, out of the .h file.
* Avoid assignments in expressions (`a = b = c;`).
* Avoid multiple declarators per struct member declaration.
* Fix naming inconsistencies.
* Replace `net_to_host` macro with function.

1 files changed, 7 insertions, 0 deletions

diff --git a/toxav/BUILD.bazel b/toxav/BUILD.bazel
index dbe57b6c..f6c92b52 100644
--- a/toxav/BUILD.bazel
+++ b/toxav/BUILD.bazel
@@ -55,10 +55,16 @@ cc_test(
 )
 
 cc_library(
+    name = "pair",
+    hdrs = ["pair.h"],
+)
+
+cc_library(
     name = "audio",
     srcs = ["audio.c"],
     hdrs = ["audio.h"],
     deps = [
+        ":pair",
         ":public",
         ":rtp",
         "//c-toxcore/toxcore:network",
@@ -78,6 +84,7 @@ cc_library(
     ],
     deps = [
         ":audio",
+        ":pair",
         ":public",
         "//c-toxcore/toxcore:network",
         "@libvpx",