diff options
author | iphydf <iphydf@users.noreply.github.com> | 2016-09-12 16:48:35 +0100 |
---|---|---|
committer | iphydf <iphydf@users.noreply.github.com> | 2016-09-16 12:06:02 +0100 |
commit | 1494e474dde58ec6e446cdbfad9a8d89f6c4796c (patch) | |
tree | e454a18a0f61468d10833d8e80039d025f94f568 /toxav | |
parent | 37c041f8159f7e89f2585243e9b8073f47d77fd1 (diff) |
Ensure that all TODOs have an owner.
In the future, all TODOs added either need a bug number (TODO(#NN)) or a
person's github user name. By default, I made irungentoo the owner of
all toxcore TODOs, mannol the owner of toxav TODOs, and myself the owner
of API TODOs.
Diffstat (limited to 'toxav')
-rw-r--r-- | toxav/audio.c | 2 | ||||
-rw-r--r-- | toxav/group.c | 4 | ||||
-rw-r--r-- | toxav/toxav.c | 2 | ||||
-rw-r--r-- | toxav/toxav.h | 2 | ||||
-rw-r--r-- | toxav/video.c | 8 |
5 files changed, 10 insertions, 8 deletions
diff --git a/toxav/audio.c b/toxav/audio.c index 0b3db00f..59d1554e 100644 --- a/toxav/audio.c +++ b/toxav/audio.c | |||
@@ -131,7 +131,7 @@ void ac_iterate(ACSession *ac) | |||
131 | return; | 131 | return; |
132 | } | 132 | } |
133 | 133 | ||
134 | /* TODO fix this and jitter buffering */ | 134 | /* TODO(mannol): fix this and jitter buffering */ |
135 | 135 | ||
136 | /* Enough space for the maximum frame size (120 ms 48 KHz stereo audio) */ | 136 | /* Enough space for the maximum frame size (120 ms 48 KHz stereo audio) */ |
137 | int16_t tmp[5760 * 2]; | 137 | int16_t tmp[5760 * 2]; |
diff --git a/toxav/group.c b/toxav/group.c index ea84bf72..66c73572 100644 --- a/toxav/group.c +++ b/toxav/group.c | |||
@@ -552,9 +552,9 @@ int group_send_audio(Group_Chats *g_c, int groupnumber, const int16_t *pcm, unsi | |||
552 | group_av->audio_sample_rate = sample_rate; | 552 | group_av->audio_sample_rate = sample_rate; |
553 | 553 | ||
554 | if (channels == 1) { | 554 | if (channels == 1) { |
555 | group_av->audio_bitrate = 32000; //TODO: add way of adjusting bitrate | 555 | group_av->audio_bitrate = 32000; // TODO(mannol): add way of adjusting bitrate |
556 | } else { | 556 | } else { |
557 | group_av->audio_bitrate = 64000; //TODO: add way of adjusting bitrate | 557 | group_av->audio_bitrate = 64000; // TODO(mannol): add way of adjusting bitrate |
558 | } | 558 | } |
559 | 559 | ||
560 | if (recreate_encoder(group_av) == -1) { | 560 | if (recreate_encoder(group_av) == -1) { |
diff --git a/toxav/toxav.c b/toxav/toxav.c index 81476d32..1ae914e8 100644 --- a/toxav/toxav.c +++ b/toxav/toxav.c | |||
@@ -1033,7 +1033,7 @@ bool audio_bit_rate_invalid(uint32_t bit_rate) | |||
1033 | bool video_bit_rate_invalid(uint32_t bit_rate) | 1033 | bool video_bit_rate_invalid(uint32_t bit_rate) |
1034 | { | 1034 | { |
1035 | (void) bit_rate; | 1035 | (void) bit_rate; |
1036 | /* TODO: If anyone knows the answer to this one please fill it up */ | 1036 | /* TODO(mannol): If anyone knows the answer to this one please fill it up */ |
1037 | return false; | 1037 | return false; |
1038 | } | 1038 | } |
1039 | bool invoke_call_state_callback(ToxAV *av, uint32_t friend_number, uint32_t state) | 1039 | bool invoke_call_state_callback(ToxAV *av, uint32_t friend_number, uint32_t state) |
diff --git a/toxav/toxav.h b/toxav/toxav.h index ea7ee194..38ba354e 100644 --- a/toxav/toxav.h +++ b/toxav/toxav.h | |||
@@ -777,7 +777,7 @@ typedef void toxav_video_receive_frame_cb(ToxAV *av, uint32_t friend_number, uin | |||
777 | void toxav_callback_video_receive_frame(ToxAV *av, toxav_video_receive_frame_cb *callback, void *user_data); | 777 | void toxav_callback_video_receive_frame(ToxAV *av, toxav_video_receive_frame_cb *callback, void *user_data); |
778 | 778 | ||
779 | /** | 779 | /** |
780 | * NOTE Compatibility with old toxav group calls TODO remove | 780 | * NOTE Compatibility with old toxav group calls. TODO(iphydf): remove |
781 | */ | 781 | */ |
782 | /* Create a new toxav group. | 782 | /* Create a new toxav group. |
783 | * | 783 | * |
diff --git a/toxav/video.c b/toxav/video.c index 9aba27ed..de028c7c 100644 --- a/toxav/video.c +++ b/toxav/video.c | |||
@@ -77,9 +77,11 @@ VCSession *vc_new(Logger *log, ToxAV *av, uint32_t friend_number, toxav_video_re | |||
77 | cfg.g_w = 800; | 77 | cfg.g_w = 800; |
78 | cfg.g_h = 600; | 78 | cfg.g_h = 600; |
79 | cfg.g_pass = VPX_RC_ONE_PASS; | 79 | cfg.g_pass = VPX_RC_ONE_PASS; |
80 | /* FIXME If we set error resilience the app will crash due to bug in vp8. | 80 | /* TODO(mannol): If we set error resilience the app will crash due to bug in vp8. |
81 | Perhaps vp9 has solved it?*/ | 81 | Perhaps vp9 has solved it?*/ |
82 | // cfg.g_error_resilient = VPX_ERROR_RESILIENT_DEFAULT | VPX_ERROR_RESILIENT_PARTITIONS; | 82 | #if 0 |
83 | cfg.g_error_resilient = VPX_ERROR_RESILIENT_DEFAULT | VPX_ERROR_RESILIENT_PARTITIONS; | ||
84 | #endif | ||
83 | cfg.g_lag_in_frames = 0; | 85 | cfg.g_lag_in_frames = 0; |
84 | cfg.kf_min_dist = 0; | 86 | cfg.kf_min_dist = 0; |
85 | cfg.kf_max_dist = 48; | 87 | cfg.kf_max_dist = 48; |