Some minor cleanups suggested by cppcheck.

DETECTED=cppcheck

1 files changed, 6 insertions, 8 deletions

diff --git a/toxcore/onion_client.c b/toxcore/onion_client.c
index 650a3dd3..e6743559 100644
--- a/toxcore/onion_client.c
+++ b/toxcore/onion_client.c
@@ -1551,15 +1551,15 @@ static void do_friend(Onion_Client *onion_c, uint16_t friendnum)
         }
     }
 
-    unsigned int i, count = 0;
-    Onion_Node *list_nodes = onion_c->friends_list[friendnum].clients_list;
-
     if (!onion_c->friends_list[friendnum].is_online) {
+        unsigned int count = 0;
+        Onion_Node *list_nodes = onion_c->friends_list[friendnum].clients_list;
+
         // ensure we get a response from some node roughly once per
         // (interval / MAX_ONION_CLIENTS)
         bool ping_random = true;
 
-        for (i = 0; i < MAX_ONION_CLIENTS; ++i) {
+        for (unsigned i = 0; i < MAX_ONION_CLIENTS; ++i) {
             if (!(is_timeout(list_nodes[i].timestamp, interval / MAX_ONION_CLIENTS)
                     && is_timeout(list_nodes[i].last_pinged, ONION_NODE_PING_INTERVAL))) {
                 ping_random = false;
@@ -1567,7 +1567,7 @@ static void do_friend(Onion_Client *onion_c, uint16_t friendnum)
             }
         }
 
-        for (i = 0; i < MAX_ONION_CLIENTS; ++i) {
+        for (unsigned i = 0; i < MAX_ONION_CLIENTS; ++i) {
             if (onion_node_timed_out(&list_nodes[i])) {
                 continue;
             }
@@ -1800,8 +1800,6 @@ unsigned int onion_connection_status(const Onion_Client *onion_c)
 
 void do_onion_client(Onion_Client *onion_c)
 {
-    unsigned int i;
-
     if (onion_c->last_run == unix_time()) {
         return;
     }
@@ -1833,7 +1831,7 @@ void do_onion_client(Onion_Client *onion_c)
                              || get_random_tcp_onion_conn_number(nc_get_tcp_c(onion_c->c)) == -1; /* Check if connected to any TCP relays. */
 
     if (onion_connection_status(onion_c)) {
-        for (i = 0; i < onion_c->num_friends; ++i) {
+        for (unsigned i = 0; i < onion_c->num_friends; ++i) {
             do_friend(onion_c, i);
         }
     }