Main: Eliminate TOX_ENABLE_IPV6 (then always on), CLIENT_ONETOONE_IP (then always off).

Additionally (besides cleanups):

network.h/tox.h:
- WIN32: fix a strange sa_family_t definition
- WIN32: define EWOULDBLOCK to WSAEWOULDBLOCK
- WIN32: kill macro for an existing function (IN6_ADDR_EQUAL)

network.c:
- use EWOULDBLOCK instead of EAGAIN (same value, but EWOULDBLOCK is more "popular")
- new_networking(): only try to enable IPv4-in-IPv6 if it's not already enabled per default
- inet_ntop()/inet_pton(): WIN32: remove partial initializers in favor of a simple memset()
- ip_equal(): WIN32: use an existing function
- logging: networking_wait_execute(): only dump result if not timeout
- logging: loglogdata(): kill an unused variable

LAN_discovery.c:
- send_broadcasts(): re-enabled, can only support IPv4 by principle, split into fetch_broadcast_info() (to fetch the addresses once) and send_broadcasts() (actual sending)

DHT.c:
- DHT_load_state_callback(): enclosed a fprintf(stderr, ...) into #ifdef DEBUG

Lossless_UDP.c:
- change_handshake(): harden against strange sa_family_t definitions

Messenger.c:
- logging: fix ID to string conversion

util.c:
- logging: eliminate a signed-warning

1 files changed, 6 insertions, 25 deletions

diff --git a/toxcore/tox.h b/toxcore/tox.h
index 39832073..bcc89ce1 100644
--- a/toxcore/tox.h
+++ b/toxcore/tox.h
@@ -36,7 +36,9 @@
 #include <windows.h>
 #include <ws2tcpip.h>
 
-typedef INT sa_family_t;
+/* sa_family_t is the sockaddr_in / sockaddr_in6 family field */
+typedef short sa_family_t;
+
 #ifndef true
 #define true 1
 #endif
@@ -69,7 +71,6 @@ typedef union {
     uint32_t i;
 } tox_IP4;
 
-
 typedef union {
     uint8_t uint8[16];
     uint16_t uint16[8];
@@ -83,36 +84,16 @@ typedef struct {
         tox_IP4 ip4;
         tox_IP6 ip6;
     };
-} tox_IPAny;
-
-typedef union {
-    struct {
-        tox_IP4  ip;
-        uint16_t port;
-        /* Not used for anything right now. */
-        uint16_t padding;
-    };
-    uint8_t uint8[8];
-} tox_IP4_Port;
+} tox_IP;
 
 /* will replace IP_Port as soon as the complete infrastructure is in place
  * removed the unused union and padding also */
 typedef struct {
-    tox_IPAny ip;
+    tox_IP    ip;
     uint16_t  port;
-} tox_IPAny_Port;
+} tox_IP_Port;
 
-/* #undef TOX_ENABLE_IPV6 */
-#define TOX_ENABLE_IPV6
-#ifdef TOX_ENABLE_IPV6
 #define TOX_ENABLE_IPV6_DEFAULT 1
-typedef tox_IPAny tox_IP;
-typedef tox_IPAny_Port tox_IP_Port;
-#else
-#define TOX_ENABLE_IPV6_DEFAULT 0
-typedef tox_IP4 tox_IP;
-typedef tox_IP4_Port tox_IP_Port;
-#endif
 
 
 /* Errors for m_addfriend