Style fixes in TCP code; remove MIN and PAIR from util.h.

* Moved PAIR to toxav, where it's used (but really this should die).
* Replace most MIN calls with typed `min_*` calls. Didn't replace the
  ones where the desired semantics are unclear. Moved the MIN macro to
  the one place where it's still used.
* Avoid assignments in `while` loops. Instead, factored out the loop body
  into a separate `bool`-returning function.
* Use named types for callbacks (`_cb` types).
* Avoid assignments in `if` conditions.
* Removed `MAKE_REALLOC` and expanded its two calls. We can't have
  templates in C, and this fake templating is ugly and hard to analyse
  and debug (it expands on a single line).
* Moved epoll system include to the .c file, out of the .h file.
* Avoid assignments in expressions (`a = b = c;`).
* Avoid multiple declarators per struct member declaration.
* Fix naming inconsistencies.
* Replace `net_to_host` macro with function.

1 files changed, 10 insertions, 0 deletions

diff --git a/toxcore/util.c b/toxcore/util.c
index 5ab092ce..f349e8fe 100644
--- a/toxcore/util.c
+++ b/toxcore/util.c
@@ -66,6 +66,11 @@ void host_to_net(uint8_t *num, uint16_t numbytes)
 #endif
 }
 
+void net_to_host(uint8_t *num, uint16_t numbytes)
+{
+    host_to_net(num, numbytes);
+}
+
 int create_recursive_mutex(pthread_mutex_t *mutex)
 {
     pthread_mutexattr_t attr;
@@ -95,6 +100,11 @@ int32_t max_s32(int32_t a, int32_t b)
     return a > b ? a : b;
 }
 
+uint32_t min_u32(uint32_t a, uint32_t b)
+{
+    return a < b ? a : b;
+}
+
 uint64_t min_u64(uint64_t a, uint64_t b)
 {
     return a < b ? a : b;