add NAT hole punching level to Tox API

7 files changed, 32 insertions, 3 deletions

diff --git a/toxcore/DHT.c b/toxcore/DHT.c
index 9a6996b2..5185353e 100644
--- a/toxcore/DHT.c
+++ b/toxcore/DHT.c
@@ -2088,6 +2088,10 @@ static uint16_t NAT_getports(uint16_t *portlist, IP_Port *ip_portlist, uint16_t
 
 static void punch_holes(DHT *dht, IP ip, uint16_t *port_list, uint16_t numports, uint16_t friend_num)
 {
+    if (!dht->hole_punching_enabled) {
+        return;
+    }
+
     if (numports > MAX_FRIEND_CLIENTS || numports == 0) {
         return;
     }
@@ -2577,7 +2581,7 @@ static int cryptopacket_handle(void *object, IP_Port source, const uint8_t *pack
 
 /*----------------------------------------------------------------------------------*/
 
-DHT *new_DHT(Logger *log, Networking_Core *net)
+DHT *new_DHT(Logger *log, Networking_Core *net, bool holepunching_enabled)
 {
     /* init time */
     unix_time_update();
@@ -2594,6 +2598,9 @@ DHT *new_DHT(Logger *log, Networking_Core *net)
 
     dht->log = log;
     dht->net = net;
+
+    dht->hole_punching_enabled = holepunching_enabled;
+
     dht->ping = new_ping(dht);
 
     if (dht->ping == NULL) {
diff --git a/toxcore/DHT.h b/toxcore/DHT.h
index 54ab9121..db05fecc 100644
--- a/toxcore/DHT.h
+++ b/toxcore/DHT.h
@@ -238,6 +238,8 @@ typedef struct {
     Logger *log;
     Networking_Core *net;
 
+    bool hole_punching_enabled;
+
     Client_data    close_clientlist[LCLIENT_LIST];
     uint64_t       close_lastgetnodes;
     uint32_t       close_bootstrap_times;
@@ -435,7 +437,7 @@ void DHT_save(DHT *dht, uint8_t *data);
 int DHT_load(DHT *dht, const uint8_t *data, uint32_t length);
 
 /* Initialize DHT. */
-DHT *new_DHT(Logger *log, Networking_Core *net);
+DHT *new_DHT(Logger *log, Networking_Core *net, bool holepunching_enabled);
 
 void kill_DHT(DHT *dht);
 
diff --git a/toxcore/Messenger.c b/toxcore/Messenger.c
index d4c4526e..be311fa1 100644
--- a/toxcore/Messenger.c
+++ b/toxcore/Messenger.c
@@ -1934,7 +1934,7 @@ Messenger *new_messenger(Messenger_Options *options, unsigned int *error)
         return NULL;
     }
 
-    m->dht = new_DHT(m->log, m->net);
+    m->dht = new_DHT(m->log, m->net, options->hole_punching_enabled);
 
     if (m->dht == NULL) {
         kill_networking(m->net);
diff --git a/toxcore/Messenger.h b/toxcore/Messenger.h
index 23bd0009..8f9a83a9 100644
--- a/toxcore/Messenger.h
+++ b/toxcore/Messenger.h
@@ -77,6 +77,8 @@ typedef struct {
     uint16_t port_range[2];
     uint16_t tcp_server_port;
 
+    uint8_t hole_punching_enabled;
+
     logger_cb *log_callback;
     void *log_user_data;
 } Messenger_Options;
diff --git a/toxcore/tox.api.h b/toxcore/tox.api.h
index 40031830..33481cce 100644
--- a/toxcore/tox.api.h
+++ b/toxcore/tox.api.h
@@ -519,6 +519,11 @@ static class options {
      */
     uint16_t tcp_port;
 
+    /**
+     * Enables or disables UDP hole-punching in toxcore. (Default: enabled).
+     */
+    bool hole_punching_enabled;
+
     namespace savedata {
       /**
        * The type of savedata to load from.
diff --git a/toxcore/tox.c b/toxcore/tox.c
index c7d90871..6317d126 100644
--- a/toxcore/tox.c
+++ b/toxcore/tox.c
@@ -131,6 +131,7 @@ ACCESSORS(uint16_t, proxy_ , port)
 ACCESSORS(uint16_t, , start_port)
 ACCESSORS(uint16_t, , end_port)
 ACCESSORS(uint16_t, , tcp_port)
+ACCESSORS(bool, , hole_punching_enabled)
 ACCESSORS(TOX_SAVEDATA_TYPE, savedata_, type)
 ACCESSORS(size_t, savedata_, length)
 ACCESSORS(tox_log_cb *, log_, callback)
@@ -155,6 +156,7 @@ void tox_options_default(struct Tox_Options *options)
         options->ipv6_enabled = 1;
         options->udp_enabled = 1;
         options->proxy_type = TOX_PROXY_TYPE_NONE;
+        options->hole_punching_enabled = true;
     }
 }
 
@@ -219,6 +221,7 @@ Tox *tox_new(const struct Tox_Options *options, TOX_ERR_NEW *error)
         m_options.port_range[0] = options->start_port;
         m_options.port_range[1] = options->end_port;
         m_options.tcp_server_port = options->tcp_port;
+        m_options.hole_punching_enabled = options->hole_punching_enabled;
 
         m_options.log_callback = (logger_cb *)options->log_callback;
         m_options.log_user_data = options->log_user_data;
diff --git a/toxcore/tox.h b/toxcore/tox.h
index ef738422..d6f6fb2f 100644
--- a/toxcore/tox.h
+++ b/toxcore/tox.h
@@ -576,6 +576,12 @@ struct Tox_Options {
 
 
     /**
+     * Enables or disables UDP hole-punching in toxcore. (Default: enabled).
+     */
+    bool hole_punching_enabled;
+
+
+    /**
      * The type of savedata to load from.
      */
     TOX_SAVEDATA_TYPE savedata_type;
@@ -642,6 +648,10 @@ uint16_t tox_options_get_tcp_port(const struct Tox_Options *options);
 
 void tox_options_set_tcp_port(struct Tox_Options *options, uint16_t tcp_port);
 
+bool tox_options_get_hole_punching_enabled(const struct Tox_Options *options);
+
+void tox_options_set_hole_punching_enabled(struct Tox_Options *options, bool hole_punching_enabled);
+
 TOX_SAVEDATA_TYPE tox_options_get_savedata_type(const struct Tox_Options *options);
 
 void tox_options_set_savedata_type(struct Tox_Options *options, TOX_SAVEDATA_TYPE type);