4 files changed, 105 insertions, 210 deletions

diff --git a/toxcore/DHT.c b/toxcore/DHT.c
index 46db6e76..dc21575e 100644
--- a/toxcore/DHT.c
+++ b/toxcore/DHT.c
@@ -281,7 +281,7 @@ void get_shared_key(const Mono_Time *mono_time, Shared_Keys *shared_keys, uint8_
 
     if (num != UINT32_MAX) {
         Shared_Key *const key = &shared_keys->keys[curr];
-        key->stored = 1;
+        key->stored = true;
         key->times_requested = 1;
         memcpy(key->public_key, public_key, CRYPTO_PUBLIC_KEY_SIZE);
         memcpy(key->shared_key, shared_key, CRYPTO_SHARED_KEY_SIZE);
@@ -491,7 +491,7 @@ static int dht_create_packet(const uint8_t public_key[CRYPTO_PUBLIC_KEY_SIZE],
  * Return size of unpacked ip_port on success.
  * Return -1 on failure.
  */
-int unpack_ip_port(IP_Port *ip_port, const uint8_t *data, uint16_t length, uint8_t tcp_enabled)
+int unpack_ip_port(IP_Port *ip_port, const uint8_t *data, uint16_t length, bool tcp_enabled)
 {
     if (data == nullptr) {
         return -1;
@@ -589,7 +589,7 @@ int pack_nodes(uint8_t *data, uint16_t length, const Node_format *nodes, uint16_
  * return -1 on failure.
  */
 int unpack_nodes(Node_format *nodes, uint16_t max_num_nodes, uint16_t *processed_data_len, const uint8_t *data,
-                 uint16_t length, uint8_t tcp_enabled)
+                 uint16_t length, bool tcp_enabled)
 {
     uint32_t num = 0, len_processed = 0;
 
diff --git a/toxcore/DHT.h b/toxcore/DHT.h
index bb17b3ea..ef3fd0b0 100644
--- a/toxcore/DHT.h
+++ b/toxcore/DHT.h
@@ -174,7 +174,7 @@ int pack_ip_port(uint8_t *data, uint16_t length, const IP_Port *ip_port);
  * Return size of unpacked ip_port on success.
  * Return -1 on failure.
  */
-int unpack_ip_port(IP_Port *ip_port, const uint8_t *data, uint16_t length, uint8_t tcp_enabled);
+int unpack_ip_port(IP_Port *ip_port, const uint8_t *data, uint16_t length, bool tcp_enabled);
 
 /* Pack number of nodes into data of maxlength length.
  *
@@ -191,7 +191,7 @@ int pack_nodes(uint8_t *data, uint16_t length, const Node_format *nodes, uint16_
  * return -1 on failure.
  */
 int unpack_nodes(Node_format *nodes, uint16_t max_num_nodes, uint16_t *processed_data_len, const uint8_t *data,
-                 uint16_t length, uint8_t tcp_enabled);
+                 uint16_t length, bool tcp_enabled);
 
 
 /*----------------------------------------------------------------------------------*/
@@ -203,7 +203,7 @@ typedef struct Shared_Key {
     uint8_t public_key[CRYPTO_PUBLIC_KEY_SIZE];
     uint8_t shared_key[CRYPTO_SHARED_KEY_SIZE];
     uint32_t times_requested;
-    uint8_t  stored; /* 0 if not, 1 if is */
+    bool stored;
     uint64_t time_last_requested;
 } Shared_Key;
 
diff --git a/toxcore/network.c b/toxcore/network.c
index efc7f7e4..917556ac 100644
--- a/toxcore/network.c
+++ b/toxcore/network.c
@@ -346,12 +346,7 @@ bool net_family_is_tox_tcp_ipv6(Family family)
     return family.value == net_family_tox_tcp_ipv6.value;
 }
 
-/* Check if socket is valid.
- *
- * return 1 if valid
- * return 0 if not valid
- */
-int sock_valid(Socket sock)
+bool sock_valid(Socket sock)
 {
     return sock.socket != net_invalid_socket.socket;
 }
@@ -367,60 +362,40 @@ void kill_sock(Socket sock)
 #endif
 }
 
-/* Set socket as nonblocking
- *
- * return 1 on success
- * return 0 on failure
- */
-int set_socket_nonblock(Socket sock)
+bool set_socket_nonblock(Socket sock)
 {
 #ifdef OS_WIN32
     u_long mode = 1;
-    return (ioctlsocket(sock.socket, FIONBIO, &mode) == 0);
+    return ioctlsocket(sock.socket, FIONBIO, &mode) == 0;
 #else
-    return (fcntl(sock.socket, F_SETFL, O_NONBLOCK, 1) == 0);
+    return fcntl(sock.socket, F_SETFL, O_NONBLOCK, 1) == 0;
 #endif
 }
 
-/* Set socket to not emit SIGPIPE
- *
- * return 1 on success
- * return 0 on failure
- */
-int set_socket_nosigpipe(Socket sock)
+bool set_socket_nosigpipe(Socket sock)
 {
 #if defined(__APPLE__)
     int set = 1;
     return setsockopt(sock.socket, SOL_SOCKET, SO_NOSIGPIPE, (const char *)&set, sizeof(int)) == 0;
 #else
-    return 1;
+    return true;
 #endif
 }
 
-/* Enable SO_REUSEADDR on socket.
- *
- * return 1 on success
- * return 0 on failure
- */
-int set_socket_reuseaddr(Socket sock)
+bool set_socket_reuseaddr(Socket sock)
 {
     int set = 1;
     return setsockopt(sock.socket, SOL_SOCKET, SO_REUSEADDR, (const char *)&set, sizeof(set)) == 0;
 }
 
-/* Set socket to dual (IPv4 + IPv6 socket)
- *
- * return 1 on success
- * return 0 on failure
- */
-int set_socket_dualstack(Socket sock)
+bool set_socket_dualstack(Socket sock)
 {
     int ipv6only = 0;
     socklen_t optsize = sizeof(ipv6only);
     int res = getsockopt(sock.socket, IPPROTO_IPV6, IPV6_V6ONLY, (char *)&ipv6only, &optsize);
 
     if ((res == 0) && (ipv6only == 0)) {
-        return 1;
+        return true;
     }
 
     ipv6only = 0;
@@ -973,16 +948,10 @@ void kill_networking(Networking_Core *net)
 }
 
 
-/* ip_equal
- *  compares two IPAny structures
- *  unset means unequal
- *
- * returns 0 when not equal or when uninitialized
- */
-int ip_equal(const IP *a, const IP *b)
+bool ip_equal(const IP *a, const IP *b)
 {
     if (!a || !b) {
-        return 0;
+        return false;
     }
 
     /* same family */
@@ -1000,7 +969,7 @@ int ip_equal(const IP *a, const IP *b)
                    a->ip.v6.uint64[1] == b->ip.v6.uint64[1];
         }
 
-        return 0;
+        return false;
     }
 
     /* different family: check on the IPv6 one if it is the IPv4 one embedded */
@@ -1018,23 +987,17 @@ int ip_equal(const IP *a, const IP *b)
         }
     }
 
-    return 0;
+    return false;
 }
 
-/* ipport_equal
- *  compares two IPAny_Port structures
- *  unset means unequal
- *
- * returns 0 when not equal or when uninitialized
- */
-int ipport_equal(const IP_Port *a, const IP_Port *b)
+bool ipport_equal(const IP_Port *a, const IP_Port *b)
 {
     if (!a || !b) {
-        return 0;
+        return false;
     }
 
     if (!a->port || (a->port != b->port)) {
-        return 0;
+        return false;
     }
 
     return ip_equal(&a->ip, &b->ip);
@@ -1153,25 +1116,10 @@ const char *ip_ntoa(const IP *ip, char *ip_str, size_t length)
     return ip_str;
 }
 
-/*
- * ip_parse_addr
- *  parses IP structure into an address string
- *
- * input
- *  ip: ip of TOX_AF_INET or TOX_AF_INET6 families
- *  length: length of the address buffer
- *          Must be at least INET_ADDRSTRLEN for TOX_AF_INET
- *          and INET6_ADDRSTRLEN for TOX_AF_INET6
- *
- * output
- *  address: dotted notation (IPv4: quad, IPv6: 16) or colon notation (IPv6)
- *
- * returns 1 on success, 0 on failure
- */
-int ip_parse_addr(const IP *ip, char *address, size_t length)
+bool ip_parse_addr(const IP *ip, char *address, size_t length)
 {
     if (!address || !ip) {
-        return 0;
+        return false;
     }
 
     if (net_family_is_ipv4(ip->family)) {
@@ -1184,26 +1132,13 @@ int ip_parse_addr(const IP *ip, char *address, size_t length)
         return inet_ntop(make_family(ip->family), addr, address, length) != nullptr;
     }
 
-    return 0;
+    return false;
 }
 
-/*
- * addr_parse_ip
- *  directly parses the input into an IP structure
- *  tries IPv4 first, then IPv6
- *
- * input
- *  address: dotted notation (IPv4: quad, IPv6: 16) or colon notation (IPv6)
- *
- * output
- *  IP: family and the value is set on success
- *
- * returns 1 on success, 0 on failure
- */
-int addr_parse_ip(const char *address, IP *to)
+bool addr_parse_ip(const char *address, IP *to)
 {
     if (!address || !to) {
-        return 0;
+        return false;
     }
 
     struct in_addr addr4;
@@ -1211,7 +1146,7 @@ int addr_parse_ip(const char *address, IP *to)
     if (inet_pton(AF_INET, address, &addr4) == 1) {
         to->family = net_family_ipv4;
         get_ip4(&to->ip.v4, &addr4);
-        return 1;
+        return true;
     }
 
     struct in6_addr addr6;
@@ -1219,29 +1154,12 @@ int addr_parse_ip(const char *address, IP *to)
     if (inet_pton(AF_INET6, address, &addr6) == 1) {
         to->family = net_family_ipv6;
         get_ip6(&to->ip.v6, &addr6);
-        return 1;
+        return true;
     }
 
-    return 0;
+    return false;
 }
 
-/*
- * addr_resolve():
- *  uses getaddrinfo to resolve an address into an IP address
- *  uses the first IPv4/IPv6 addresses returned by getaddrinfo
- *
- * input
- *  address: a hostname (or something parseable to an IP address)
- *  to: to.family MUST be initialized, either set to a specific IP version
- *     (TOX_AF_INET/TOX_AF_INET6) or to the unspecified AF_UNSPEC (= 0), if both
- *     IP versions are acceptable
- *  extra can be NULL and is only set in special circumstances, see returns
- *
- * returns in *to a valid IPAny (v4/v6),
- *     prefers v6 if ip.family was AF_UNSPEC and both available
- * returns in *extra an IPv4 address, if family was AF_UNSPEC and *to is TOX_AF_INET6
- * returns 0 on failure, TOX_ADDR_RESOLVE_* on success.
- */
 int addr_resolve(const char *address, IP *to, IP *extra)
 {
     if (!address || !to) {
@@ -1332,30 +1250,15 @@ int addr_resolve(const char *address, IP *to, IP *extra)
     return result;
 }
 
-/*
- * addr_resolve_or_parse_ip
- *  resolves string into an IP address
- *
- *  address: a hostname (or something parseable to an IP address)
- *  to: to.family MUST be initialized, either set to a specific IP version
- *     (TOX_AF_INET/TOX_AF_INET6) or to the unspecified AF_UNSPEC (= 0), if both
- *     IP versions are acceptable
- *  extra can be NULL and is only set in special circumstances, see returns
- *
- *  returns in *tro a matching address (IPv6 or IPv4)
- *  returns in *extra, if not NULL, an IPv4 address, if to->family was AF_UNSPEC
- *  returns 1 on success
- *  returns 0 on failure
- */
-int addr_resolve_or_parse_ip(const char *address, IP *to, IP *extra)
+bool addr_resolve_or_parse_ip(const char *address, IP *to, IP *extra)
 {
     if (!addr_resolve(address, to, extra)) {
         if (!addr_parse_ip(address, to)) {
-            return 0;
+            return false;
         }
     }
 
-    return 1;
+    return true;
 }
 
 int net_connect(Socket sock, IP_Port ip_port)
@@ -1466,10 +1369,7 @@ void net_freeipport(IP_Port *ip_ports)
     free(ip_ports);
 }
 
-/* return 1 on success
- * return 0 on failure
- */
-int bind_to_port(Socket sock, Family family, uint16_t port)
+bool bind_to_port(Socket sock, Family family, uint16_t port)
 {
     struct sockaddr_storage addr = {0};
     size_t addrsize;
@@ -1487,7 +1387,7 @@ int bind_to_port(Socket sock, Family family, uint16_t port)
         addr6->sin6_family = AF_INET6;
         addr6->sin6_port = net_htons(port);
     } else {
-        return 0;
+        return false;
     }
 
     return bind(sock.socket, (struct sockaddr *)&addr, addrsize) == 0;
diff --git a/toxcore/network.h b/toxcore/network.h
index 08be6f10..6c5b6781 100644
--- a/toxcore/network.h
+++ b/toxcore/network.h
@@ -64,12 +64,12 @@ typedef struct Socket {
 
 Socket net_socket(Family domain, int type, int protocol);
 
-/* Check if socket is valid.
+/**
+ * Check if socket is valid.
  *
- * return 1 if valid
- * return 0 if not valid
+ * @return true if valid, false otherwise.
  */
-int sock_valid(Socket sock);
+bool sock_valid(Socket sock);
 
 extern const Socket net_invalid_socket;
 
@@ -235,53 +235,49 @@ bool ipv6_ipv4_in_v6(IP6 a);
 #define IP_NTOA_LEN 96 // TODO(irungentoo): magic number. Why not INET6_ADDRSTRLEN ?
 const char *ip_ntoa(const IP *ip, char *ip_str, size_t length);
 
-/*
- * ip_parse_addr
- *  parses IP structure into an address string
+/**
+ * Parses IP structure into an address string.
  *
- * input
- *  ip: ip of TOX_AF_INET or TOX_AF_INET6 families
- *  length: length of the address buffer
- *          Must be at least TOX_INET_ADDRSTRLEN for TOX_AF_INET
- *          and TOX_INET6_ADDRSTRLEN for TOX_AF_INET6
+ * @param ip IP of TOX_AF_INET or TOX_AF_INET6 families.
+ * @param length length of the address buffer.
+ *   Must be at least TOX_INET_ADDRSTRLEN for TOX_AF_INET
+ *   and TOX_INET6_ADDRSTRLEN for TOX_AF_INET6
  *
- * output
- *  address: dotted notation (IPv4: quad, IPv6: 16) or colon notation (IPv6)
+ * @param address dotted notation (IPv4: quad, IPv6: 16) or colon notation (IPv6).
  *
- * returns 1 on success, 0 on failure
+ * @return true on success, false on failure.
  */
-int ip_parse_addr(const IP *ip, char *address, size_t length);
+bool ip_parse_addr(const IP *ip, char *address, size_t length);
 
-/*
- * addr_parse_ip
- *  directly parses the input into an IP structure
- *  tries IPv4 first, then IPv6
+/**
+ * Directly parses the input into an IP structure.
  *
- * input
- *  address: dotted notation (IPv4: quad, IPv6: 16) or colon notation (IPv6)
+ * Tries IPv4 first, then IPv6.
  *
- * output
- *  IP: family and the value is set on success
+ * @param address dotted notation (IPv4: quad, IPv6: 16) or colon notation (IPv6).
+ * @param to family and the value is set on success.
  *
- * returns 1 on success, 0 on failure
+ * @return true on success, false on failure.
  */
-int addr_parse_ip(const char *address, IP *to);
+bool addr_parse_ip(const char *address, IP *to);
 
-/* ip_equal
- *  compares two IPAny structures
- *  unset means unequal
+/**
+ * Compares two IPAny structures.
  *
- * returns 0 when not equal or when uninitialized
+ * Unset means unequal.
+ *
+ * @return false when not equal or when uninitialized.
  */
-int ip_equal(const IP *a, const IP *b);
+bool ip_equal(const IP *a, const IP *b);
 
-/* ipport_equal
- *  compares two IPAny_Port structures
- *  unset means unequal
+/**
+ * Compares two IPAny_Port structures.
+ *
+ * Unset means unequal.
  *
- * returns 0 when not equal or when uninitialized
+ * @return false when not equal or when uninitialized.
  */
-int ipport_equal(const IP_Port *a, const IP_Port *b);
+bool ipport_equal(const IP_Port *a, const IP_Port *b);
 
 /* nulls out ip */
 void ip_reset(IP *ip);
@@ -296,41 +292,40 @@ void ip_copy(IP *target, const IP *source);
 /* copies an ip_port structure */
 void ipport_copy(IP_Port *target, const IP_Port *source);
 
-/*
- * addr_resolve():
- *  uses getaddrinfo to resolve an address into an IP address
- *  uses the first IPv4/IPv6 addresses returned by getaddrinfo
+/**
+ * Uses getaddrinfo to resolve an address into an IP address.
  *
- * input
- *  address: a hostname (or something parseable to an IP address)
- *  to: to.family MUST be initialized, either set to a specific IP version
+ * Uses the first IPv4/IPv6 addresses returned by getaddrinfo.
+ *
+ * @param address a hostname (or something parseable to an IP address)
+ * @param to to.family MUST be initialized, either set to a specific IP version
  *     (TOX_AF_INET/TOX_AF_INET6) or to the unspecified TOX_AF_UNSPEC (= 0), if both
  *     IP versions are acceptable
- *  extra can be NULL and is only set in special circumstances, see returns
+ * @param extra can be NULL and is only set in special circumstances, see returns
  *
  * returns in *to a valid IPAny (v4/v6),
  *     prefers v6 if ip.family was TOX_AF_UNSPEC and both available
  * returns in *extra an IPv4 address, if family was TOX_AF_UNSPEC and *to is TOX_AF_INET6
- * returns 0 on failure
+ *
+ * @return 0 on failure, TOX_ADDR_RESOLVE_* on success.
  */
 int addr_resolve(const char *address, IP *to, IP *extra);
 
-/*
- * addr_resolve_or_parse_ip
- *  resolves string into an IP address
+/**
+ * Resolves string into an IP address
  *
- *  address: a hostname (or something parseable to an IP address)
- *  to: to.family MUST be initialized, either set to a specific IP version
+ * @param address a hostname (or something parseable to an IP address)
+ * @param to to.family MUST be initialized, either set to a specific IP version
  *     (TOX_AF_INET/TOX_AF_INET6) or to the unspecified TOX_AF_UNSPEC (= 0), if both
  *     IP versions are acceptable
- *  extra can be NULL and is only set in special circumstances, see returns
+ * @param extra can be NULL and is only set in special circumstances, see returns
+ *
+ * returns in *tro a matching address (IPv6 or IPv4)
+ * returns in *extra, if not NULL, an IPv4 address, if to->family was TOX_AF_UNSPEC
  *
- *  returns in *tro a matching address (IPv6 or IPv4)
- *  returns in *extra, if not NULL, an IPv4 address, if to->family was TOX_AF_UNSPEC
- *  returns 1 on success
- *  returns 0 on failure
+ * @return true on success, false on failure
  */
-int addr_resolve_or_parse_ip(const char *address, IP *to, IP *extra);
+bool addr_resolve_or_parse_ip(const char *address, IP *to, IP *extra);
 
 /* Function to receive data, ip and port of sender is put into ip_port.
  * Packet data is put into data.
@@ -354,33 +349,33 @@ int networking_at_startup(void);
  */
 void kill_sock(Socket sock);
 
-/* Set socket as nonblocking
+/**
+ * Set socket as nonblocking
  *
- * return 1 on success
- * return 0 on failure
+ * @return true on success, false on failure.
  */
-int set_socket_nonblock(Socket sock);
+bool set_socket_nonblock(Socket sock);
 
-/* Set socket to not emit SIGPIPE
+/**
+ * Set socket to not emit SIGPIPE
  *
- * return 1 on success
- * return 0 on failure
+ * @return true on success, false on failure.
  */
-int set_socket_nosigpipe(Socket sock);
+bool set_socket_nosigpipe(Socket sock);
 
-/* Enable SO_REUSEADDR on socket.
+/**
+ * Enable SO_REUSEADDR on socket.
  *
- * return 1 on success
- * return 0 on failure
+ * @return true on success, false on failure.
  */
-int set_socket_reuseaddr(Socket sock);
+bool set_socket_reuseaddr(Socket sock);
 
-/* Set socket to dual (IPv4 + IPv6 socket)
+/**
+ * Set socket to dual (IPv4 + IPv6 socket)
  *
- * return 1 on success
- * return 0 on failure
+ * @return true on success, false on failure.
  */
-int set_socket_dualstack(Socket sock);
+bool set_socket_dualstack(Socket sock);
 
 /* Basic network functions: */
 
@@ -413,10 +408,10 @@ int32_t net_getipport(const char *node, IP_Port **res, int tox_type);
  */
 void net_freeipport(IP_Port *ip_ports);
 
-/* return 1 on success
- * return 0 on failure
+/**
+ * @return true on success, false on failure.
  */
-int bind_to_port(Socket sock, Family family, uint16_t port);
+bool bind_to_port(Socket sock, Family family, uint16_t port);
 
 /* Get the last networking error code.
  *