Fix all -Wall suggestion

4 files changed, 15 insertions, 14 deletions

diff --git a/src/Data/Torrent/Client.hs b/src/Data/Torrent/Client.hs
index f21a5e92..122f779d 100644
--- a/src/Data/Torrent/Client.hs
+++ b/src/Data/Torrent/Client.hs
@@ -20,6 +20,7 @@
 --   capabilities (such as supported enchancements), this should be
 --   done using 'Network.BitTorrent.Extension'!
 --
+{-# OPTIONS -fno-warn-orphans #-}
 module Data.Torrent.Client
        ( ClientImpl (..)
        , ClientInfo (..)
@@ -29,9 +30,7 @@ module Data.Torrent.Client
 import Data.Default
 import Data.List as L
 import Data.List.Split as L
-import Data.Monoid
 import Data.String
-import Data.Text as T
 import Data.Version
 import Text.PrettyPrint hiding ((<>))
 import Text.PrettyPrint.Class
@@ -194,7 +193,7 @@ libClientInfo = ClientInfo IlibHSbittorrent version
 {-----------------------------------------------------------------------
 --  For torrent file
 -----------------------------------------------------------------------}
-
+{-
 renderImpl :: ClientImpl -> Text
 renderImpl = T.pack . L.tail . show
 
@@ -206,7 +205,7 @@ renderClientInfo ClientInfo {..} = renderImpl ciImpl <> "/" <> renderVersion ciV
 
 parseClientInfo :: Text -> ClientImpl
 parseClientInfo t = undefined
-
+-}
 {-
 -- code used for generation; remove it later on
 
diff --git a/src/Data/Torrent/Magnet.hs b/src/Data/Torrent/Magnet.hs
index daa09fbb..887e8379 100644
--- a/src/Data/Torrent/Magnet.hs
+++ b/src/Data/Torrent/Magnet.hs
@@ -18,6 +18,7 @@
 {-# LANGUAGE MultiParamTypeClasses #-}
 {-# LANGUAGE TypeSynonymInstances  #-}
 {-# LANGUAGE DeriveDataTypeable    #-}
+{-# OPTIONS -fno-warn-orphans      #-}
 module Data.Torrent.Magnet
        ( -- * Magnet
          Magnet(..)
diff --git a/src/Network/BitTorrent/Core/PeerAddr.hs b/src/Network/BitTorrent/Core/PeerAddr.hs
index b145c0d9..e58aaa89 100644
--- a/src/Network/BitTorrent/Core/PeerAddr.hs
+++ b/src/Network/BitTorrent/Core/PeerAddr.hs
@@ -35,7 +35,6 @@ import Network.Socket
 import Text.PrettyPrint
 import Text.PrettyPrint.Class
 
-import Data.Torrent.Client
 import Network.BitTorrent.Core.PeerId
 
 
diff --git a/src/Network/BitTorrent/Tracker/Message.hs b/src/Network/BitTorrent/Tracker/Message.hs
index 9ce2e67b..046f7e57 100644
--- a/src/Network/BitTorrent/Tracker/Message.hs
+++ b/src/Network/BitTorrent/Tracker/Message.hs
@@ -46,11 +46,10 @@ module Network.BitTorrent.Tracker.Message
        where
 
 import Control.Applicative
-import Control.Exception
 import Control.Monad
 import Data.Aeson (ToJSON(..), FromJSON(..))
 import Data.Aeson.TH
-import Data.BEncode as BE
+import Data.BEncode as BE hiding (Result)
 import Data.BEncode.BDict as BE
 import Data.ByteString as BS
 import Data.ByteString.Char8 as BC
@@ -59,7 +58,6 @@ import Data.Convertible
 import Data.List as L
 import Data.Map  as M
 import Data.Maybe
-import Data.Monoid
 import Data.Serialize as S hiding (Result)
 import Data.Text (Text)
 import Data.Text.Encoding
@@ -70,7 +68,6 @@ import Network.HTTP.Types.QueryLike
 import Network.HTTP.Types.URI hiding (urlEncode)
 import Network.HTTP.Types.Status
 import Network.Socket
-import Network.URI
 import Text.Read (readMaybe)
 
 import Data.Torrent.InfoHash
@@ -232,7 +229,7 @@ renderAnnounceQuery = filterMaybes . toQuery
     filterMaybes :: [(a, Maybe b)] -> [(a, b)]
     filterMaybes = catMaybes . L.map f
       where
-        f (a, Nothing) = Nothing
+        f (_, Nothing) = Nothing
         f (a, Just b ) = Just (a, b)
 
 data QueryParam
@@ -289,18 +286,23 @@ instance FromParam Event where
     Nothing      -> Nothing
     Just (x, xs) -> readMaybe $ BC.unpack $ BC.cons (Char.toUpper x) xs
 
+type Result = Either ParamParseFailure
+
+withError :: ParamParseFailure -> Maybe a -> Result a
 withError e = maybe (Left e) Right
 
+reqParam :: FromParam a => QueryParam -> SimpleQuery -> Result a
 reqParam param xs = do
   val <- withError (Missing param) $ L.lookup (paramName param) xs
   withError (Invalid param val) (fromParam val)
 
+optParam :: FromParam a => QueryParam -> SimpleQuery -> Result (Maybe a)
 optParam param ps
   | Just x <- L.lookup (paramName param) ps
   = pure <$> withError (Invalid param x) (fromParam x)
   | otherwise = pure Nothing
 
-parseProgress :: SimpleQuery -> Either ParamParseFailure Progress
+parseProgress :: SimpleQuery -> Result Progress
 parseProgress params = Progress
   <$> reqParam ParamDownloaded params
   <*> reqParam ParamLeft       params
@@ -318,7 +320,7 @@ parseAnnounceQuery params = AnnounceQuery
   <*> optParam ParamEvent    params
 
 -- TODO add extension datatype
-type AnnounceRequest = ()
+--type AnnounceRequest = ()
 
 {-----------------------------------------------------------------------
 --  Announce response
@@ -471,8 +473,8 @@ parseFailureMessage e = BS.concat $ case e of
 parseFailureStatus :: ParamParseFailure -> Status
 parseFailureStatus = mkStatus <$> parseFailureCode <*> parseFailureMessage
 
-type AnnounceResponse = Either Status AnnounceInfo -- TODO
-type TrackerResponse = () -- TODO
+--type AnnounceResponse = Either Status AnnounceInfo -- TODO
+--type TrackerResponse = () -- TODO
 
 {-----------------------------------------------------------------------
   Scrape message