Refactoring.

1 files changed, 18 insertions, 18 deletions

diff --git a/dht/Presence/Presence.hs b/dht/Presence/Presence.hs
index dcc76c5b..926ee3c2 100644
--- a/dht/Presence/Presence.hs
+++ b/dht/Presence/Presence.hs
@@ -54,6 +54,7 @@ import Network.Tox.NodeId (key2id,parseNoSpamId,nospam64,NoSpamId(..),ToxProgres
 import Crypto.Tox (decodeSecret)
 import DPut
 import DebugTag
+import Codec.AsciiKey256
 
 {-
 isPeerKey :: ClientAddress -> Bool
@@ -251,12 +252,12 @@ chooseResourceName state k (Remote addr) clientsNameForMe desired = do
     flgs <- atomically $ newTVar 0
     profile <- fmap (fromMaybe ".")
         $ forM ((,) <$> clientsNameForMe <*> toxManager state) $ \(wanted_profile0,toxman) ->
-        case splitLast4 wanted_profile0 of
-            ("*",".tox") -> do
+        case stripSuffix ".tox" wanted_profile0 of
+            Just "*" -> do
                 dput XMisc $ "TODO: Match single tox key profile or generate first."
                 -- TODO: Match single tox key profile or generate first.
                 _todo
-            (pub,".tox") -> do
+            Just pub -> do
                 cdir <- ConfigFiles.configPath (L.fromChunks [Text.encodeUtf8 user]) "." ""
 #if !MIN_VERSION_directory(1,2,5)
                 let listDirectory path = filter (`notElem` [".",".."]) <$> getDirectoryContents path
@@ -361,7 +362,7 @@ rosterGetStuff what state k = forClient state k (return [])
       PresenceState { server = sv } -> do
         let conns = manager state $ clientProfile client
         -- Grok peers to associate with from the roster:
-        let isTox = do (me  , ".tox") <- Just $ splitLast4 (clientProfile client)
+        let isTox = do me <- stripSuffix ".tox" (clientProfile client)
                        return me
             noToxUsers (u,h,r)
                 | Text.isSuffixOf ".tox" h = unsplitJID (Nothing,h,r)
@@ -373,8 +374,9 @@ rosterGetStuff what state k = forClient state k (return [])
             let policySetter = fromMaybe (Connection.setPolicy conns host) $ do
                     isTox
                     toxman <- toxManager state
-                    (them, ".tox") <- Just $ splitLast4 host
-                    meid <- readMaybe $ Text.unpack $ Text.dropEnd 4 (clientProfile client)
+                    them <- stripSuffix ".tox" host
+                    prof <- stripSuffix ".tox" (clientProfile client)
+                    meid   <- readMaybe $ Text.unpack prof
                     themid <- readMaybe $ Text.unpack them
                     return $ Connection.setPolicy (toxConnections toxman)
                                                   (ToxContact meid themid)
@@ -547,9 +549,9 @@ eofConn state saddr cdta = do
         Right (k,_) -> do
             forClient state k (return ()) $ \client -> do
             forM_ (toxManager state) $ \toxman -> do
-                case splitLast4 (clientProfile client) of
-                    (pub,".tox") -> deactivateAccount toxman k (clientProfile client)
-                    _            -> return ()
+                case stripSuffix ".tox" (clientProfile client) of
+                    Just pub -> deactivateAccount toxman k (clientProfile client)
+                    _        -> return ()
             stanza <- makePresenceStanza "jabber:server" Nothing Offline
             informClientPresence state k stanza
             atomically $ do
@@ -665,12 +667,12 @@ deliverMessage state fail msg =
                          -- In case the client sends us a lower-cased version of the base64
                          -- tox key hostname, we resolve it by comparing it with roster entries.
                          xs <- getBuddiesAndSolicited state (clientProfile client) $ \case
-                            rh | (_,".tox") <- splitLast4 rh
+                            rh | Just _ <- stripSuffix ".tox" rh
                                , Text.toLower rh == Text.toLower th
                                -> return True
                             _ -> return False
                          fmap join $ forM (listToMaybe xs) $ \(_,rmu,_,h) -> do
-                             let (them,_) = splitLast4 h
+                             let them = fromMaybe h $ stripSuffix ".tox" h
                              maddr <- resolveToxPeer toxman me them
                              let to' = unsplitJID (mu,h,rsc)
                              return $ fmap (to',) maddr
@@ -1168,21 +1170,19 @@ clientSubscriptionRequest state fail k stanza chan = do
                                      (connChan con)
         let policySetter = fromMaybe (Connection.setPolicy conns h) $ do
                 (toxman,_,_) <- weAreTox state client h
-                meid <- readMaybe $ Text.unpack $ case splitLast4 (clientProfile client) of
-                            (h,".tox") -> h
-                            _          -> clientProfile client
+                meid <- readMaybe $ Text.unpack $ case stripSuffix ".tox" (clientProfile client) of
+                            Just h -> h
+                            _      -> clientProfile client
                 themid <- readMaybe $ Text.unpack h
                 Just $ Connection.setPolicy (toxConnections toxman) (ToxContact meid themid)
         -- Add peer if we are not already associated ...
         policySetter Connection.TryingToConnect
 
-splitLast4 h = Text.splitAt (Text.length h - 4) h
-
 weAreTox :: PresenceState stat -> ClientState -> Text -> Maybe (ToxManager ClientAddress,Text{- me -},Text{- them -})
 weAreTox state client h = do
     toxman <- toxManager state
-    (me  , ".tox") <- Just $ splitLast4 (clientProfile client)
-    (them, ".tox") <- Just $ splitLast4 h
+    me   <- stripSuffix ".tox" (clientProfile client)
+    them <- stripSuffix ".tox" h
     return (toxman,me,them)
 
 resolvedFromRoster