Remove byteStringToPeerId to simplify API

2 files changed, 13 insertions, 10 deletions

diff --git a/src/Network/BitTorrent/Core/PeerId.hs b/src/Network/BitTorrent/Core/PeerId.hs
index 8bd175e5..148f550d 100644
--- a/src/Network/BitTorrent/Core/PeerId.hs
+++ b/src/Network/BitTorrent/Core/PeerId.hs
@@ -12,10 +12,11 @@
 --  /peer handshakes/ and used in DHT queries.
 --
 {-# LANGUAGE GeneralizedNewtypeDeriving #-}
+{-# LANGUAGE MultiParamTypeClasses      #-}
+{-# LANGUAGE DeriveDataTypeable         #-}
 module Network.BitTorrent.Core.PeerId
        ( -- * PeerId
          PeerId
-       , byteStringToPeerId
 
          -- * Generation
        , genPeerId
@@ -40,6 +41,7 @@ import Data.ByteString.Internal as BS
 import Data.ByteString.Char8 as BC
 import qualified Data.ByteString.Lazy as BL
 import qualified Data.ByteString.Lazy.Builder as BS
+import Data.Convertible
 import Data.Default
 import Data.Foldable    (foldMap)
 import Data.List as L
@@ -51,6 +53,7 @@ import Data.Serialize as S
 import Data.String
 import Data.Time.Clock  (getCurrentTime)
 import Data.Time.Format (formatTime)
+import Data.Typeable
 import Data.Version     (Version(Version), versionBranch)
 import Network.HTTP.Types.QueryLike
 import System.Entropy   (getEntropy)
@@ -65,7 +68,7 @@ import Data.Torrent.Client
 
 -- | Peer identifier is exactly 20 bytes long bytestring.
 newtype PeerId = PeerId { getPeerId :: ByteString }
-                 deriving (Show, Eq, Ord, BEncode, ToJSON, FromJSON)
+  deriving (Show, Eq, Ord, BEncode, ToJSON, FromJSON, Typeable)
 
 peerIdLen :: Int
 peerIdLen = 20
@@ -92,10 +95,10 @@ instance IsString PeerId where
 instance Pretty PeerId where
   pretty = text . BC.unpack . getPeerId
 
-byteStringToPeerId :: BS.ByteString -> Maybe PeerId
-byteStringToPeerId bs
-  | BS.length bs == peerIdLen = Just (PeerId bs)
-  |          otherwise        = Nothing
+instance Convertible BS.ByteString PeerId where
+  safeConvert bs
+    | BS.length bs == peerIdLen = pure (PeerId bs)
+    |          otherwise        = convError "invalid length" bs
 
 {-----------------------------------------------------------------------
 --  Encoding
diff --git a/src/Network/BitTorrent/Tracker/Message.hs b/src/Network/BitTorrent/Tracker/Message.hs
index 046f7e57..9999d128 100644
--- a/src/Network/BitTorrent/Tracker/Message.hs
+++ b/src/Network/BitTorrent/Tracker/Message.hs
@@ -267,7 +267,7 @@ instance FromParam InfoHash where
   fromParam = either (const Nothing) pure . safeConvert
 
 instance FromParam PeerId where
-  fromParam = byteStringToPeerId
+  fromParam = either (const Nothing) pure . safeConvert
 
 instance FromParam Word32 where
   fromParam = readMaybe . BC.unpack
@@ -282,9 +282,9 @@ instance FromParam PortNumber where
   fromParam bs = fromIntegral <$> (fromParam bs :: Maybe Word32)
 
 instance FromParam Event where
-  fromParam bs = case BC.uncons bs of
-    Nothing      -> Nothing
-    Just (x, xs) -> readMaybe $ BC.unpack $ BC.cons (Char.toUpper x) xs
+  fromParam bs = do
+    (x, xs) <- BC.uncons bs
+    readMaybe $ BC.unpack $ BC.cons (Char.toUpper x) xs
 
 type Result = Either ParamParseFailure