Make SignaturePacket opaque, emit trailer

Instead of the Put instance emitting the actual packet header, it emits
the start of the trailer data (which is the same bytes as the packet
header).

SignaturePacket is opaque and there is a smart constructor,
signaturePacket, that takes all the data *except* the trailer and
auto-generates the trailer, making sure the trailer is always valid, so
that the above becomes possible.

WARNING: SignaturePacket is not *fully* opaque.  You *may* still update
fields directly using record syntax (on an already constructed packet).
This may be useful, but if any of the values that make up the trailer
are changed this will MAKE THE PACKET INVALID.  This trade-off is deemed
acceptable for now, but may change in the future.  Any fields that do not
affect the trailer (unhashed subpackets, etc) may be safely updated in
this way.  Other fields MUST be updated by constructing a new
SignaturePacket with the smart constructor.

This usage is exemplefied by Data.OpenPGP.Crypto

The major upside of this is that it is now possible to re-emit
unmodified (or even modified, if only fields not in the trailer are
modified) SignaturePackets without invalidating the signature.

Closes #11

1 files changed, 34 insertions, 34 deletions

diff --git a/tests/suite.hs b/tests/suite.hs
index 9480c0b..17ab3cb 100644
--- a/tests/suite.hs
+++ b/tests/suite.hs
@@ -63,90 +63,90 @@ tests secring =
                 testGroup "Serialization" [
                         testCase "000001-006.public_key" (testSerialization "000001-006.public_key"),
                         testCase "000002-013.user_id" (testSerialization "000002-013.user_id"),
-                        -- Issue #11 -- testCase "000003-002.sig" (testSerialization "000003-002.sig"),
+                        testCase "000003-002.sig" (testSerialization "000003-002.sig"),
                         testCase "000004-012.ring_trust" (testSerialization "000004-012.ring_trust"),
-                        -- Issue #11 -- testCase "000005-002.sig" (testSerialization "000005-002.sig"),
+                        testCase "000005-002.sig" (testSerialization "000005-002.sig"),
                         testCase "000006-012.ring_trust" (testSerialization "000006-012.ring_trust"),
-                        -- Issue #11 -- testCase "000007-002.sig" (testSerialization "000007-002.sig"),
+                        testCase "000007-002.sig" (testSerialization "000007-002.sig"),
                         testCase "000008-012.ring_trust" (testSerialization "000008-012.ring_trust"),
-                        -- Issue #11 -- testCase "000009-002.sig" (testSerialization "000009-002.sig"),
+                        testCase "000009-002.sig" (testSerialization "000009-002.sig"),
                         testCase "000010-012.ring_trust" (testSerialization "000010-012.ring_trust"),
-                        -- Issue #11 -- testCase "000011-002.sig" (testSerialization "000011-002.sig"),
+                        testCase "000011-002.sig" (testSerialization "000011-002.sig"),
                         testCase "000012-012.ring_trust" (testSerialization "000012-012.ring_trust"),
                         testCase "000013-014.public_subkey" (testSerialization "000013-014.public_subkey"),
-                        -- Issue #11 -- testCase "000014-002.sig" (testSerialization "000014-002.sig"),
+                        testCase "000014-002.sig" (testSerialization "000014-002.sig"),
                         testCase "000015-012.ring_trust" (testSerialization "000015-012.ring_trust"),
                         testCase "000016-006.public_key" (testSerialization "000016-006.public_key"),
-                        -- Issue #11 -- testCase "000017-002.sig" (testSerialization "000017-002.sig"),
+                        testCase "000017-002.sig" (testSerialization "000017-002.sig"),
                         testCase "000018-012.ring_trust" (testSerialization "000018-012.ring_trust"),
                         testCase "000019-013.user_id" (testSerialization "000019-013.user_id"),
-                        -- Issue #11 -- testCase "000020-002.sig" (testSerialization "000020-002.sig"),
+                        testCase "000020-002.sig" (testSerialization "000020-002.sig"),
                         testCase "000021-012.ring_trust" (testSerialization "000021-012.ring_trust"),
-                        -- Issue #11 -- testCase "000022-002.sig" (testSerialization "000022-002.sig"),
+                        testCase "000022-002.sig" (testSerialization "000022-002.sig"),
                         testCase "000023-012.ring_trust" (testSerialization "000023-012.ring_trust"),
                         testCase "000024-014.public_subkey" (testSerialization "000024-014.public_subkey"),
-                        -- Issue #11 -- testCase "000025-002.sig" (testSerialization "000025-002.sig"),
+                        testCase "000025-002.sig" (testSerialization "000025-002.sig"),
                         testCase "000026-012.ring_trust" (testSerialization "000026-012.ring_trust"),
                         testCase "000027-006.public_key" (testSerialization "000027-006.public_key"),
-                        -- Issue #11 -- testCase "000028-002.sig" (testSerialization "000028-002.sig"),
+                        testCase "000028-002.sig" (testSerialization "000028-002.sig"),
                         testCase "000029-012.ring_trust" (testSerialization "000029-012.ring_trust"),
                         testCase "000030-013.user_id" (testSerialization "000030-013.user_id"),
-                        -- Issue #11 -- testCase "000031-002.sig" (testSerialization "000031-002.sig"),
+                        testCase "000031-002.sig" (testSerialization "000031-002.sig"),
                         testCase "000032-012.ring_trust" (testSerialization "000032-012.ring_trust"),
-                        -- Issue #11 -- testCase "000033-002.sig" (testSerialization "000033-002.sig"),
+                        testCase "000033-002.sig" (testSerialization "000033-002.sig"),
                         testCase "000034-012.ring_trust" (testSerialization "000034-012.ring_trust"),
                         testCase "000035-006.public_key" (testSerialization "000035-006.public_key"),
                         testCase "000036-013.user_id" (testSerialization "000036-013.user_id"),
-                        -- Issue #11 -- testCase "000037-002.sig" (testSerialization "000037-002.sig"),
+                        testCase "000037-002.sig" (testSerialization "000037-002.sig"),
                         testCase "000038-012.ring_trust" (testSerialization "000038-012.ring_trust"),
-                        -- Issue #11 -- testCase "000039-002.sig" (testSerialization "000039-002.sig"),
+                        testCase "000039-002.sig" (testSerialization "000039-002.sig"),
                         testCase "000040-012.ring_trust" (testSerialization "000040-012.ring_trust"),
                         testCase "000041-017.attribute" (testSerialization "000041-017.attribute"),
-                        -- Issue #11 -- testCase "000042-002.sig" (testSerialization "000042-002.sig"),
+                        testCase "000042-002.sig" (testSerialization "000042-002.sig"),
                         testCase "000043-012.ring_trust" (testSerialization "000043-012.ring_trust"),
                         testCase "000044-014.public_subkey" (testSerialization "000044-014.public_subkey"),
-                        -- Issue #11 -- testCase "000045-002.sig" (testSerialization "000045-002.sig"),
+                        testCase "000045-002.sig" (testSerialization "000045-002.sig"),
                         testCase "000046-012.ring_trust" (testSerialization "000046-012.ring_trust"),
                         testCase "000047-005.secret_key" (testSerialization "000047-005.secret_key"),
                         testCase "000048-013.user_id" (testSerialization "000048-013.user_id"),
-                        -- Issue #11 -- testCase "000049-002.sig" (testSerialization "000049-002.sig"),
+                        testCase "000049-002.sig" (testSerialization "000049-002.sig"),
                         testCase "000050-012.ring_trust" (testSerialization "000050-012.ring_trust"),
                         testCase "000051-007.secret_subkey" (testSerialization "000051-007.secret_subkey"),
-                        -- Issue #11 -- testCase "000052-002.sig" (testSerialization "000052-002.sig"),
+                        testCase "000052-002.sig" (testSerialization "000052-002.sig"),
                         testCase "000053-012.ring_trust" (testSerialization "000053-012.ring_trust"),
                         testCase "000054-005.secret_key" (testSerialization "000054-005.secret_key"),
-                        -- Issue #11 -- testCase "000055-002.sig" (testSerialization "000055-002.sig"),
+                        testCase "000055-002.sig" (testSerialization "000055-002.sig"),
                         testCase "000056-012.ring_trust" (testSerialization "000056-012.ring_trust"),
                         testCase "000057-013.user_id" (testSerialization "000057-013.user_id"),
-                        -- Issue #11 -- testCase "000058-002.sig" (testSerialization "000058-002.sig"),
+                        testCase "000058-002.sig" (testSerialization "000058-002.sig"),
                         testCase "000059-012.ring_trust" (testSerialization "000059-012.ring_trust"),
                         testCase "000060-007.secret_subkey" (testSerialization "000060-007.secret_subkey"),
-                        -- Issue #11 -- testCase "000061-002.sig" (testSerialization "000061-002.sig"),
+                        testCase "000061-002.sig" (testSerialization "000061-002.sig"),
                         testCase "000062-012.ring_trust" (testSerialization "000062-012.ring_trust"),
                         testCase "000063-005.secret_key" (testSerialization "000063-005.secret_key"),
-                        -- Issue #11 -- testCase "000064-002.sig" (testSerialization "000064-002.sig"),
+                        testCase "000064-002.sig" (testSerialization "000064-002.sig"),
                         testCase "000065-012.ring_trust" (testSerialization "000065-012.ring_trust"),
                         testCase "000066-013.user_id" (testSerialization "000066-013.user_id"),
-                        -- Issue #11 -- testCase "000067-002.sig" (testSerialization "000067-002.sig"),
+                        testCase "000067-002.sig" (testSerialization "000067-002.sig"),
                         testCase "000068-012.ring_trust" (testSerialization "000068-012.ring_trust"),
                         testCase "000069-005.secret_key" (testSerialization "000069-005.secret_key"),
                         testCase "000070-013.user_id" (testSerialization "000070-013.user_id"),
-                        -- Issue #11 -- testCase "000071-002.sig" (testSerialization "000071-002.sig"),
+                        testCase "000071-002.sig" (testSerialization "000071-002.sig"),
                         testCase "000072-012.ring_trust" (testSerialization "000072-012.ring_trust"),
                         testCase "000073-017.attribute" (testSerialization "000073-017.attribute"),
-                        -- Issue #11 -- testCase "000074-002.sig" (testSerialization "000074-002.sig"),
+                        testCase "000074-002.sig" (testSerialization "000074-002.sig"),
                         testCase "000075-012.ring_trust" (testSerialization "000075-012.ring_trust"),
                         testCase "000076-007.secret_subkey" (testSerialization "000076-007.secret_subkey"),
-                        -- Issue #11 -- testCase "000077-002.sig" (testSerialization "000077-002.sig"),
+                        testCase "000077-002.sig" (testSerialization "000077-002.sig"),
                         testCase "000078-012.ring_trust" (testSerialization "000078-012.ring_trust"),
-                        -- Issue #11 -- testCase "pubring.gpg" (testSerialization "pubring.gpg"),
                         -- Issue #11 -- testCase "secring.gpg" (testSerialization "secring.gpg"),
-                        -- Issue #11 -- testCase "compressedsig.gpg" (testSerialization "compressedsig.gpg"),
-                        -- Issue #11 -- testCase "compressedsig-zlib.gpg" (testSerialization "compressedsig-zlib.gpg"),
-                        -- Issue #11 -- testCase "compressedsig-bzip2.gpg" (testSerialization "compressedsig-bzip2.gpg"),
-                        testCase "onepass_sig" (testSerialization "onepass_sig")
-                        -- Issue #11 -- testCase "uncompressed-ops-dsa.gpg" (testSerialization "uncompressed-ops-dsa.gpg"),
-                        -- Issue #11 -- testCase "uncompressed-ops-rsa.gpg" (testSerialization "uncompressed-ops-rsa.gpg"),
+                        testCase "pubring.gpg" (testSerialization "pubring.gpg"),
+                        testCase "compressedsig.gpg" (testSerialization "compressedsig.gpg"),
+                        testCase "compressedsig-zlib.gpg" (testSerialization "compressedsig-zlib.gpg"),
+                        testCase "compressedsig-bzip2.gpg" (testSerialization "compressedsig-bzip2.gpg"),
+                        testCase "onepass_sig" (testSerialization "onepass_sig"),
+                        testCase "uncompressed-ops-dsa.gpg" (testSerialization "uncompressed-ops-dsa.gpg"),
+                        testCase "uncompressed-ops-rsa.gpg" (testSerialization "uncompressed-ops-rsa.gpg")
                 ],
                 testGroup "Fingerprint" [
                         testCase "000001-006.public_key" (testFingerprint "000001-006.public_key" "421F28FEAAD222F856C8FFD5D4D54EA16F87040E"),