diff options
author | Darren Tucker <dtucker@dtucker.net> | 2020-07-28 19:40:30 +1000 |
---|---|---|
committer | Darren Tucker <dtucker@dtucker.net> | 2020-07-28 19:40:30 +1000 |
commit | 89fc3f414be0ce4e8008332a9739a7d721269e50 (patch) | |
tree | f0ad5a121f8328b5e3487310d624b3b36fe04244 | |
parent | 62c81ef531b0cc7ff655455dd34f5f0c94f48e82 (diff) |
Use argv in OSSH_CHECK_CFLAG_COMPILE test.
configure.ac is not detecting -Wextra in compilers that implement the
option. The problem is that -Wextra implies -Wunused-parameter, and the
C excerpt used by aclocal.m4 does not use argv. Patch from pedro at
ambientworks.net, ok djm@
-rw-r--r-- | aclocal.m4 | 3 | ||||
-rw-r--r-- | configure.ac | 1 |
2 files changed, 4 insertions, 0 deletions
diff --git a/aclocal.m4 b/aclocal.m4 index 0193c3dcc..b70856e43 100644 --- a/aclocal.m4 +++ b/aclocal.m4 | |||
@@ -15,6 +15,7 @@ AC_DEFUN([OSSH_CHECK_CFLAG_COMPILE], [{ | |||
15 | #include <stdlib.h> | 15 | #include <stdlib.h> |
16 | #include <stdio.h> | 16 | #include <stdio.h> |
17 | int main(int argc, char **argv) { | 17 | int main(int argc, char **argv) { |
18 | (void)argv; | ||
18 | /* Some math to catch -ftrapv problems in the toolchain */ | 19 | /* Some math to catch -ftrapv problems in the toolchain */ |
19 | int i = 123 * argc, j = 456 + argc, k = 789 - argc; | 20 | int i = 123 * argc, j = 456 + argc, k = 789 - argc; |
20 | float l = i * 2.1; | 21 | float l = i * 2.1; |
@@ -62,6 +63,7 @@ AC_DEFUN([OSSH_CHECK_CFLAG_LINK], [{ | |||
62 | #include <stdlib.h> | 63 | #include <stdlib.h> |
63 | #include <stdio.h> | 64 | #include <stdio.h> |
64 | int main(int argc, char **argv) { | 65 | int main(int argc, char **argv) { |
66 | (void)argv; | ||
65 | /* Some math to catch -ftrapv problems in the toolchain */ | 67 | /* Some math to catch -ftrapv problems in the toolchain */ |
66 | int i = 123 * argc, j = 456 + argc, k = 789 - argc; | 68 | int i = 123 * argc, j = 456 + argc, k = 789 - argc; |
67 | float l = i * 2.1; | 69 | float l = i * 2.1; |
@@ -100,6 +102,7 @@ AC_DEFUN([OSSH_CHECK_LDFLAG_LINK], [{ | |||
100 | #include <stdlib.h> | 102 | #include <stdlib.h> |
101 | #include <stdio.h> | 103 | #include <stdio.h> |
102 | int main(int argc, char **argv) { | 104 | int main(int argc, char **argv) { |
105 | (void)argv; | ||
103 | /* Some math to catch -ftrapv problems in the toolchain */ | 106 | /* Some math to catch -ftrapv problems in the toolchain */ |
104 | int i = 123 * argc, j = 456 + argc, k = 789 - argc; | 107 | int i = 123 * argc, j = 456 + argc, k = 789 - argc; |
105 | float l = i * 2.1; | 108 | float l = i * 2.1; |
diff --git a/configure.ac b/configure.ac index ff7417354..81a6e31f9 100644 --- a/configure.ac +++ b/configure.ac | |||
@@ -164,6 +164,7 @@ if test "$GCC" = "yes" || test "$GCC" = "egcs"; then | |||
164 | OSSH_CHECK_CFLAG_COMPILE([-Wformat-security]) | 164 | OSSH_CHECK_CFLAG_COMPILE([-Wformat-security]) |
165 | OSSH_CHECK_CFLAG_COMPILE([-Wsizeof-pointer-memaccess]) | 165 | OSSH_CHECK_CFLAG_COMPILE([-Wsizeof-pointer-memaccess]) |
166 | OSSH_CHECK_CFLAG_COMPILE([-Wpointer-sign], [-Wno-pointer-sign]) | 166 | OSSH_CHECK_CFLAG_COMPILE([-Wpointer-sign], [-Wno-pointer-sign]) |
167 | OSSH_CHECK_CFLAG_COMPILE([-Wunused-parameter], [-Wno-unused-parameter]) | ||
167 | OSSH_CHECK_CFLAG_COMPILE([-Wunused-result], [-Wno-unused-result]) | 168 | OSSH_CHECK_CFLAG_COMPILE([-Wunused-result], [-Wno-unused-result]) |
168 | OSSH_CHECK_CFLAG_COMPILE([-Wimplicit-fallthrough]) | 169 | OSSH_CHECK_CFLAG_COMPILE([-Wimplicit-fallthrough]) |
169 | OSSH_CHECK_CFLAG_COMPILE([-fno-strict-aliasing]) | 170 | OSSH_CHECK_CFLAG_COMPILE([-fno-strict-aliasing]) |