summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorColin Watson <cjwatson@debian.org>2014-02-09 16:10:00 +0000
committerColin Watson <cjwatson@debian.org>2015-08-19 16:33:32 +0100
commit8a8bbc66b8eefd7c679d5769f087209188deafe7 (patch)
tree864ad14ef2ee9dfd1e992bbdcf996c2748b74dce
parent4f55e60d2296feba17b473b2146a75debe29993a (diff)
Look for $SHELL on the path for ProxyCommand/LocalCommand
There's some debate on the upstream bug about whether POSIX requires this. I (Colin Watson) agree with Vincent and think it does. Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1494 Bug-Debian: http://bugs.debian.org/492728 Last-Update: 2013-09-14 Patch-Name: shell-path.patch
-rw-r--r--sshconnect.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/sshconnect.c b/sshconnect.c
index 9e515066d..0073c6edc 100644
--- a/sshconnect.c
+++ b/sshconnect.c
@@ -231,7 +231,7 @@ ssh_proxy_connect(const char *host, u_short port, const char *proxy_command)
231 /* Execute the proxy command. Note that we gave up any 231 /* Execute the proxy command. Note that we gave up any
232 extra privileges above. */ 232 extra privileges above. */
233 signal(SIGPIPE, SIG_DFL); 233 signal(SIGPIPE, SIG_DFL);
234 execv(argv[0], argv); 234 execvp(argv[0], argv);
235 perror(argv[0]); 235 perror(argv[0]);
236 exit(1); 236 exit(1);
237 } 237 }
@@ -1470,7 +1470,7 @@ ssh_local_cmd(const char *args)
1470 if (pid == 0) { 1470 if (pid == 0) {
1471 signal(SIGPIPE, SIG_DFL); 1471 signal(SIGPIPE, SIG_DFL);
1472 debug3("Executing %s -c \"%s\"", shell, args); 1472 debug3("Executing %s -c \"%s\"", shell, args);
1473 execl(shell, shell, "-c", args, (char *)NULL); 1473 execlp(shell, shell, "-c", args, (char *)NULL);
1474 error("Couldn't execute %s -c \"%s\": %s", 1474 error("Couldn't execute %s -c \"%s\": %s",
1475 shell, args, strerror(errno)); 1475 shell, args, strerror(errno));
1476 _exit(1); 1476 _exit(1);