summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDarren Tucker <dtucker@zip.com.au>2013-05-17 13:16:59 +1000
committerDarren Tucker <dtucker@zip.com.au>2013-05-17 13:16:59 +1000
commit91af05c5167fe0aa5bd41d2e4a83757d9f627c18 (patch)
tree27e573e42f677c35febb064932d97df2918d103b
parent6e1e60c3c2e16c32bb7ca0876caaa6182a4e4b2c (diff)
- (dtucker) [regress/integrity.sh]. Force fixed Diffie-Hellman key exchange
methods. When the openssl version doesn't support ECDH then next one on the list is DH group exchange, but that causes a bit more traffic which can mean that the tests flip bits in the initial exchange rather than the MACed traffic and we get different errors to what the tests look for.
-rw-r--r--ChangeLog5
-rw-r--r--regress/integrity.sh5
2 files changed, 10 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index 61601f6ba..2f6572779 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -44,6 +44,11 @@
44 add tests for RekeyLimit parsing 44 add tests for RekeyLimit parsing
45 - (dtucker) [regress/bsd.regress.mk] Remove unused file. We've never used it 45 - (dtucker) [regress/bsd.regress.mk] Remove unused file. We've never used it
46 in portable and it's long gone in openbsd. 46 in portable and it's long gone in openbsd.
47 - (dtucker) [regress/integrity.sh]. Force fixed Diffie-Hellman key exchange
48 methods. When the openssl version doesn't support ECDH then next one on
49 the list is DH group exchange, but that causes a bit more traffic which can
50 mean that the tests flip bits in the initial exchange rather than the MACed
51 traffic and we get different errors to what the tests look for.
47 52
4820130516 5320130516
49 - (djm) [contrib/ssh-copy-id] Fix bug that could cause "rm *" to be 54 - (djm) [contrib/ssh-copy-id] Fix bug that could cause "rm *" to be
diff --git a/regress/integrity.sh b/regress/integrity.sh
index 3950b7d1f..2621a0025 100644
--- a/regress/integrity.sh
+++ b/regress/integrity.sh
@@ -21,6 +21,11 @@ config_defined HAVE_EVP_SHA256 &&
21config_defined OPENSSL_HAVE_EVPGCM && \ 21config_defined OPENSSL_HAVE_EVPGCM && \
22 macs="$macs aes128-gcm@openssh.com aes256-gcm@openssh.com" 22 macs="$macs aes128-gcm@openssh.com aes256-gcm@openssh.com"
23 23
24# avoid DH group exchange as the extra traffic makes it harder to get the
25# offset into the stream right.
26echo "KexAlgorithms diffie-hellman-group14-sha1,diffie-hellman-group1-sha1" \
27 >> $OBJ/ssh_proxy
28
24# sshd-command for proxy (see test-exec.sh) 29# sshd-command for proxy (see test-exec.sh)
25cmd="$SUDO sh ${SRC}/sshd-log-wrapper.sh ${SSHD} ${TEST_SSHD_LOGFILE} -i -f $OBJ/sshd_proxy" 30cmd="$SUDO sh ${SRC}/sshd-log-wrapper.sh ${SSHD} ${TEST_SSHD_LOGFILE} -i -f $OBJ/sshd_proxy"
26 31