summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDamien Miller <djm@mindrot.org>2001-07-14 11:55:15 +1000
committerDamien Miller <djm@mindrot.org>2001-07-14 11:55:15 +1000
commit98273e3adeac9aba6851bd74a662a3735fc2448b (patch)
treeeb8702a0e0c338a019a734c7cb8e5d5cc40c15c6
parentc62f1fc3ff9181894095bd505c7d54d0b5411be7 (diff)
- (djm) Revert dirname fix, a better one is on its way.
-rw-r--r--ChangeLog3
-rw-r--r--auth.c6
2 files changed, 3 insertions, 6 deletions
diff --git a/ChangeLog b/ChangeLog
index ce9cf665b..965af4249 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -2,6 +2,7 @@
2 - (djm) Enable /etc/nologin check on PAM systems, as some lack the 2 - (djm) Enable /etc/nologin check on PAM systems, as some lack the
3 pam_nologin module. Report from William Yodlowsky 3 pam_nologin module. Report from William Yodlowsky
4 <bsd@openbsd.rutgers.edu> 4 <bsd@openbsd.rutgers.edu>
5 - (djm) Revert dirname fix, a better one is on its way.
5 6
620010711 720010711
7 - (djm) dirname(3) may modify its argument on glibc and other systems. 8 - (djm) dirname(3) may modify its argument on glibc and other systems.
@@ -5977,4 +5978,4 @@
5977 - Wrote replacements for strlcpy and mkdtemp 5978 - Wrote replacements for strlcpy and mkdtemp
5978 - Released 1.0pre1 5979 - Released 1.0pre1
5979 5980
5980$Id: ChangeLog,v 1.1385 2001/07/14 01:54:05 djm Exp $ 5981$Id: ChangeLog,v 1.1386 2001/07/14 01:55:15 djm Exp $
diff --git a/auth.c b/auth.c
index 436802342..84e0be761 100644
--- a/auth.c
+++ b/auth.c
@@ -368,11 +368,7 @@ secure_filename(FILE *f, const char *file, struct passwd *pw,
368 char *cp; 368 char *cp;
369 struct stat st; 369 struct stat st;
370 370
371 strlcpy(homedir, pw->pw_dir, sizeof(homedir)); 371 strlcpy(homedir, dirname(pw->pw_dir), sizeof(homedir));
372 if ((cp = dirname(homedir)) == NULL)
373 strlcpy(homedir, "/", sizeof(homedir));
374 else
375 memmove(homedir, cp, strlen(cp));
376 372
377 if (realpath(file, buf) == NULL) { 373 if (realpath(file, buf) == NULL) {
378 snprintf(err, errlen, "realpath %s failed: %s", file, 374 snprintf(err, errlen, "realpath %s failed: %s", file,