summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorColin Watson <cjwatson@debian.org>2014-02-09 16:10:00 +0000
committerColin Watson <cjwatson@debian.org>2016-08-07 12:18:43 +0100
commitac283605e244f9dab676b039986f137f86284291 (patch)
treeee2cb1cd0422f2662545f1cf488b8a397feb1f57
parent119936d7b64829f81cbc84c2e81bf23373c6ed37 (diff)
Look for $SHELL on the path for ProxyCommand/LocalCommand
There's some debate on the upstream bug about whether POSIX requires this. I (Colin Watson) agree with Vincent and think it does. Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1494 Bug-Debian: http://bugs.debian.org/492728 Last-Update: 2013-09-14 Patch-Name: shell-path.patch
-rw-r--r--sshconnect.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/sshconnect.c b/sshconnect.c
index 356ec79f0..8b8e7608c 100644
--- a/sshconnect.c
+++ b/sshconnect.c
@@ -232,7 +232,7 @@ ssh_proxy_connect(const char *host, u_short port, const char *proxy_command)
232 /* Execute the proxy command. Note that we gave up any 232 /* Execute the proxy command. Note that we gave up any
233 extra privileges above. */ 233 extra privileges above. */
234 signal(SIGPIPE, SIG_DFL); 234 signal(SIGPIPE, SIG_DFL);
235 execv(argv[0], argv); 235 execvp(argv[0], argv);
236 perror(argv[0]); 236 perror(argv[0]);
237 exit(1); 237 exit(1);
238 } 238 }
@@ -1499,7 +1499,7 @@ ssh_local_cmd(const char *args)
1499 if (pid == 0) { 1499 if (pid == 0) {
1500 signal(SIGPIPE, SIG_DFL); 1500 signal(SIGPIPE, SIG_DFL);
1501 debug3("Executing %s -c \"%s\"", shell, args); 1501 debug3("Executing %s -c \"%s\"", shell, args);
1502 execl(shell, shell, "-c", args, (char *)NULL); 1502 execlp(shell, shell, "-c", args, (char *)NULL);
1503 error("Couldn't execute %s -c \"%s\": %s", 1503 error("Couldn't execute %s -c \"%s\": %s",
1504 shell, args, strerror(errno)); 1504 shell, args, strerror(errno));
1505 _exit(1); 1505 _exit(1);