- markus@cvs.openbsd.org 2002/02/04 12:15:25

     [log.c log.h readconf.c servconf.c]
     add SYSLOG_FACILITY_NOT_SET = -1, SYSLOG_LEVEL_NOT_SET = -1,
     fixes arm/netbsd; based on patch from bjh21@netbsd.org; ok djm@

5 files changed, 27 insertions, 21 deletions

diff --git a/ChangeLog b/ChangeLog
index 2f39d6ed6..d36ec3268 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -85,6 +85,10 @@
      [auth2.c]
      cross checking of announced vs actual pktype in pubkey/hostbaed auth; 
      ok stevesk@
+   - markus@cvs.openbsd.org 2002/02/04 12:15:25
+     [log.c log.h readconf.c servconf.c]
+     add SYSLOG_FACILITY_NOT_SET = -1, SYSLOG_LEVEL_NOT_SET = -1,
+     fixes arm/netbsd; based on patch from bjh21@netbsd.org; ok djm@
 
 20020130
  - (djm) Delay PRNG seeding until we need it in ssh-keygen, from markus@
@@ -7487,4 +7491,4 @@
  - Wrote replacements for strlcpy and mkdtemp
  - Released 1.0pre1
 
-$Id: ChangeLog,v 1.1822 2002/02/05 01:26:03 djm Exp $
+$Id: ChangeLog,v 1.1823 2002/02/05 01:26:34 djm Exp $
diff --git a/log.c b/log.c
index d1d13dd53..5b25b5929 100644
--- a/log.c
+++ b/log.c
@@ -34,7 +34,7 @@
  */
 
 #include "includes.h"
-RCSID("$OpenBSD: log.c,v 1.20 2002/01/17 04:27:37 stevesk Exp $");
+RCSID("$OpenBSD: log.c,v 1.21 2002/02/04 12:15:25 markus Exp $");
 
 #include "log.h"
 #include "xmalloc.h"
@@ -68,7 +68,7 @@ static struct {
         { "LOCAL5",     SYSLOG_FACILITY_LOCAL5 },
         { "LOCAL6",     SYSLOG_FACILITY_LOCAL6 },
         { "LOCAL7",     SYSLOG_FACILITY_LOCAL7 },
-        { NULL, (SyslogFacility)0 }
+        { NULL,         SYSLOG_FACILITY_NOT_SET }
 };
 
 static struct {
@@ -85,7 +85,7 @@ static struct {
         { "DEBUG1",     SYSLOG_LEVEL_DEBUG1 },
         { "DEBUG2",     SYSLOG_LEVEL_DEBUG2 },
         { "DEBUG3",     SYSLOG_LEVEL_DEBUG3 },
-        { NULL, (LogLevel)0 }
+        { NULL,         SYSLOG_LEVEL_NOT_SET }
 };
 
 static void      do_log(LogLevel level, const char *fmt, va_list args);
@@ -98,7 +98,7 @@ log_facility_number(char *name)
                 for (i = 0; log_facilities[i].name; i++)
                         if (strcasecmp(log_facilities[i].name, name) == 0)
                                 return log_facilities[i].val;
-        return (SyslogFacility) - 1;
+        return SYSLOG_FACILITY_NOT_SET;
 }
 
 LogLevel
@@ -109,7 +109,7 @@ log_level_number(char *name)
                 for (i = 0; log_levels[i].name; i++)
                         if (strcasecmp(log_levels[i].name, name) == 0)
                                 return log_levels[i].val;
-        return (LogLevel) - 1;
+        return SYSLOG_LEVEL_NOT_SET;
 }
 /* Fatal messages.  This function never returns. */
 
diff --git a/log.h b/log.h
index 23451f74f..8ab5c0939 100644
--- a/log.h
+++ b/log.h
@@ -1,4 +1,4 @@
-/*      $OpenBSD: log.h,v 1.4 2001/06/26 17:27:24 markus Exp $  */
+/*      $OpenBSD: log.h,v 1.5 2002/02/04 12:15:25 markus Exp $  */
 
 /*
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
@@ -32,7 +32,8 @@ typedef enum {
         SYSLOG_FACILITY_LOCAL4,
         SYSLOG_FACILITY_LOCAL5,
         SYSLOG_FACILITY_LOCAL6,
-        SYSLOG_FACILITY_LOCAL7
+        SYSLOG_FACILITY_LOCAL7,
+        SYSLOG_FACILITY_NOT_SET = -1,
 }       SyslogFacility;
 
 typedef enum {
@@ -43,7 +44,8 @@ typedef enum {
         SYSLOG_LEVEL_VERBOSE,
         SYSLOG_LEVEL_DEBUG1,
         SYSLOG_LEVEL_DEBUG2,
-        SYSLOG_LEVEL_DEBUG3
+        SYSLOG_LEVEL_DEBUG3,
+        SYSLOG_LEVEL_NOT_SET = -1,
 }       LogLevel;
 
 void     log_init(char *, LogLevel, SyslogFacility, int);
diff --git a/readconf.c b/readconf.c
index 650a11994..7920ac86d 100644
--- a/readconf.c
+++ b/readconf.c
@@ -12,7 +12,7 @@
  */
 
 #include "includes.h"
-RCSID("$OpenBSD: readconf.c,v 1.94 2002/01/04 17:59:17 stevesk Exp $");
+RCSID("$OpenBSD: readconf.c,v 1.95 2002/02/04 12:15:25 markus Exp $");
 
 #include "ssh.h"
 #include "xmalloc.h"
@@ -591,10 +591,10 @@ parse_int:
                 intptr = (int *) &options->log_level;
                 arg = strdelim(&s);
                 value = log_level_number(arg);
-                if (value == (LogLevel) - 1)
+                if (value == SYSLOG_LEVEL_NOT_SET)
                         fatal("%.200s line %d: unsupported log level '%s'",
                             filename, linenum, arg ? arg : "<NONE>");
-                if (*activep && (LogLevel) * intptr == -1)
+                if (*activep && (LogLevel) *intptr == SYSLOG_LEVEL_NOT_SET)
                         *intptr = (LogLevel) value;
                 break;
 
@@ -794,7 +794,7 @@ initialize_options(Options * options)
         options->num_local_forwards = 0;
         options->num_remote_forwards = 0;
         options->clear_forwardings = -1;
-        options->log_level = (LogLevel) - 1;
+        options->log_level = SYSLOG_LEVEL_NOT_SET;
         options->preferred_authentications = NULL;
         options->bind_address = NULL;
         options->smartcard_device = NULL;
@@ -911,7 +911,7 @@ fill_default_options(Options * options)
                 options->system_hostfile2 = _PATH_SSH_SYSTEM_HOSTFILE2;
         if (options->user_hostfile2 == NULL)
                 options->user_hostfile2 = _PATH_SSH_USER_HOSTFILE2;
-        if (options->log_level == (LogLevel) - 1)
+        if (options->log_level == SYSLOG_LEVEL_NOT_SET)
                 options->log_level = SYSLOG_LEVEL_INFO;
         if (options->clear_forwardings == 1)
                 clear_forwardings(options);
diff --git a/servconf.c b/servconf.c
index 8273df54c..9bbd994ca 100644
--- a/servconf.c
+++ b/servconf.c
@@ -10,7 +10,7 @@
  */
 
 #include "includes.h"
-RCSID("$OpenBSD: servconf.c,v 1.100 2002/01/29 14:32:03 markus Exp $");
+RCSID("$OpenBSD: servconf.c,v 1.101 2002/02/04 12:15:25 markus Exp $");
 
 #if defined(KRB4) || defined(KRB5)
 #include <krb.h>
@@ -67,8 +67,8 @@ initialize_server_options(ServerOptions *options)
         options->xauth_location = NULL;
         options->strict_modes = -1;
         options->keepalives = -1;
-        options->log_facility = (SyslogFacility) - 1;
-        options->log_level = (LogLevel) - 1;
+        options->log_facility = SYSLOG_FACILITY_NOT_SET;
+        options->log_level = SYSLOG_LEVEL_NOT_SET;
         options->rhosts_authentication = -1;
         options->rhosts_rsa_authentication = -1;
         options->hostbased_authentication = -1;
@@ -168,9 +168,9 @@ fill_default_server_options(ServerOptions *options)
                 options->strict_modes = 1;
         if (options->keepalives == -1)
                 options->keepalives = 1;
-        if (options->log_facility == (SyslogFacility) (-1))
+        if (options->log_facility == SYSLOG_FACILITY_NOT_SET)
                 options->log_facility = SYSLOG_FACILITY_AUTH;
-        if (options->log_level == (LogLevel) (-1))
+        if (options->log_level == SYSLOG_LEVEL_NOT_SET)
                 options->log_level = SYSLOG_LEVEL_INFO;
         if (options->rhosts_authentication == -1)
                 options->rhosts_authentication = 0;
@@ -696,7 +696,7 @@ parse_flag:
                 intptr = (int *) &options->log_facility;
                 arg = strdelim(&cp);
                 value = log_facility_number(arg);
-                if (value == (SyslogFacility) - 1)
+                if (value == SYSLOG_FACILITY_NOT_SET)
                         fatal("%.200s line %d: unsupported log facility '%s'",
                             filename, linenum, arg ? arg : "<NONE>");
                 if (*intptr == -1)
@@ -707,7 +707,7 @@ parse_flag:
                 intptr = (int *) &options->log_level;
                 arg = strdelim(&cp);
                 value = log_level_number(arg);
-                if (value == (LogLevel) - 1)
+                if (value == SYSLOG_LEVEL_NOT_SET)
                         fatal("%.200s line %d: unsupported log level '%s'",
                             filename, linenum, arg ? arg : "<NONE>");
                 if (*intptr == -1)