summaryrefslogtreecommitdiff
path: root/auth.c
diff options
context:
space:
mode:
authorColin Watson <cjwatson@debian.org>2014-02-09 16:09:58 +0000
committerColin Watson <cjwatson@debian.org>2019-06-21 16:14:03 +0100
commit0fc2ac6707abe076cd6b444f73c478eeda54b25f (patch)
treee433ad99222914ffb1e6f666b1bfa3739784e243 /auth.c
parente9dd9cd95fe8fe2da9b114a1546a90634b3ce4be (diff)
Allow harmless group-writability
Allow secure files (~/.ssh/config, ~/.ssh/authorized_keys, etc.) to be group-writable, provided that the group in question contains only the file's owner. Rejected upstream for IMO incorrect reasons (e.g. a misunderstanding about the contents of gr->gr_mem). Given that per-user groups and umask 002 are the default setup in Debian (for good reasons - this makes operating in setgid directories with other groups much easier), we need to permit this by default. Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1060 Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=314347 Last-Update: 2019-06-05 Patch-Name: user-group-modes.patch
Diffstat (limited to 'auth.c')
-rw-r--r--auth.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/auth.c b/auth.c
index f7a23afba..8ffd77662 100644
--- a/auth.c
+++ b/auth.c
@@ -473,8 +473,7 @@ check_key_in_hostfiles(struct passwd *pw, struct sshkey *key, const char *host,
473 user_hostfile = tilde_expand_filename(userfile, pw->pw_uid); 473 user_hostfile = tilde_expand_filename(userfile, pw->pw_uid);
474 if (options.strict_modes && 474 if (options.strict_modes &&
475 (stat(user_hostfile, &st) == 0) && 475 (stat(user_hostfile, &st) == 0) &&
476 ((st.st_uid != 0 && st.st_uid != pw->pw_uid) || 476 !secure_permissions(&st, pw->pw_uid)) {
477 (st.st_mode & 022) != 0)) {
478 logit("Authentication refused for %.100s: " 477 logit("Authentication refused for %.100s: "
479 "bad owner or modes for %.200s", 478 "bad owner or modes for %.200s",
480 pw->pw_name, user_hostfile); 479 pw->pw_name, user_hostfile);