diff options
author | Colin Watson <cjwatson@debian.org> | 2014-02-09 16:09:58 +0000 |
---|---|---|
committer | Colin Watson <cjwatson@debian.org> | 2018-04-03 08:21:37 +0100 |
commit | 9e45701c5d6105444cc2f4f5d6c44b0f69969479 (patch) | |
tree | 9df3ccd6a8eee5c69d410a69d06be927bc7284fd /auth.c | |
parent | 027619c6b05713e3f08a51e7232389383900e5d8 (diff) |
Allow harmless group-writability
Allow secure files (~/.ssh/config, ~/.ssh/authorized_keys, etc.) to be
group-writable, provided that the group in question contains only the file's
owner. Rejected upstream for IMO incorrect reasons (e.g. a misunderstanding
about the contents of gr->gr_mem). Given that per-user groups and umask 002
are the default setup in Debian (for good reasons - this makes operating in
setgid directories with other groups much easier), we need to permit this by
default.
Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1060
Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=314347
Last-Update: 2017-10-04
Patch-Name: user-group-modes.patch
Diffstat (limited to 'auth.c')
-rw-r--r-- | auth.c | 3 |
1 files changed, 1 insertions, 2 deletions
@@ -468,8 +468,7 @@ check_key_in_hostfiles(struct passwd *pw, struct sshkey *key, const char *host, | |||
468 | user_hostfile = tilde_expand_filename(userfile, pw->pw_uid); | 468 | user_hostfile = tilde_expand_filename(userfile, pw->pw_uid); |
469 | if (options.strict_modes && | 469 | if (options.strict_modes && |
470 | (stat(user_hostfile, &st) == 0) && | 470 | (stat(user_hostfile, &st) == 0) && |
471 | ((st.st_uid != 0 && st.st_uid != pw->pw_uid) || | 471 | !secure_permissions(&st, pw->pw_uid)) { |
472 | (st.st_mode & 022) != 0)) { | ||
473 | logit("Authentication refused for %.100s: " | 472 | logit("Authentication refused for %.100s: " |
474 | "bad owner or modes for %.200s", | 473 | "bad owner or modes for %.200s", |
475 | pw->pw_name, user_hostfile); | 474 | pw->pw_name, user_hostfile); |