upstream commit

Remove support for pre-authentication compression. Doing
compression early in the protocol probably seemed reasonable in the 1990s,
but today it's clearly a bad idea in terms of both cryptography (cf. multiple
compression oracle attacks in TLS) and attack surface.

Moreover, to support it across privilege-separation zlib needed
the assistance of a complex shared-memory manager that made the
required attack surface considerably larger.

Prompted by Guido Vranken pointing out a compiler-elided security
check in the shared memory manager found by Stack
(http://css.csail.mit.edu/stack/); ok deraadt@ markus@

NB. pre-auth authentication has been disabled by default in sshd
for >10 years.

Upstream-ID: 32af9771788d45a0779693b41d06ec199d849caf

1 files changed, 0 insertions, 3 deletions

diff --git a/opacket.h b/opacket.h
index 16322ec6f..d2a63a355 100644
--- a/opacket.h
+++ b/opacket.h
@@ -133,9 +133,6 @@ void	packet_disconnect(const char *, ...)
         ssh_packet_get_input(active_state)
 #define packet_get_output() \
         ssh_packet_get_output(active_state)
-#define packet_set_compress_hooks(ctx, allocfunc, freefunc) \
-        ssh_packet_set_compress_hooks(active_state, ctx, \
-            allocfunc, freefunc);
 #define packet_check_eom() \
         ssh_packet_check_eom(active_state)
 #define set_newkeys(mode) \