- djm@cvs.openbsd.org 2014/02/02 03:44:32

     [auth1.c auth2-chall.c auth2-passwd.c authfile.c bufaux.c bufbn.c]
     [buffer.c cipher-3des1.c cipher.c clientloop.c gss-serv.c kex.c]
     [kexdhc.c kexdhs.c kexecdhc.c kexgexc.c kexecdhs.c kexgexs.c key.c]
     [monitor.c monitor_wrap.c packet.c readpass.c rsa.c serverloop.c]
     [ssh-add.c ssh-agent.c ssh-dss.c ssh-ecdsa.c ssh-ed25519.c]
     [ssh-keygen.c ssh-rsa.c sshconnect.c sshconnect1.c sshconnect2.c]
     [sshd.c]
     convert memset of potentially-private data to explicit_bzero()

1 files changed, 8 insertions, 8 deletions

diff --git a/packet.c b/packet.c
index 6cf7edbb8..54c0558f9 100644
--- a/packet.c
+++ b/packet.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: packet.c,v 1.191 2013/12/06 13:34:54 markus Exp $ */
+/* $OpenBSD: packet.c,v 1.192 2014/02/02 03:44:31 djm Exp $ */
 /*
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
  * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@@ -764,9 +764,9 @@ set_newkeys(int mode)
                 mac  = &active_state->newkeys[mode]->mac;
                 comp = &active_state->newkeys[mode]->comp;
                 mac_clear(mac);
-                memset(enc->iv,  0, enc->iv_len);
-                memset(enc->key, 0, enc->key_len);
-                memset(mac->key, 0, mac->key_len);
+                explicit_bzero(enc->iv,  enc->iv_len);
+                explicit_bzero(enc->key, enc->key_len);
+                explicit_bzero(mac->key, mac->key_len);
                 free(enc->name);
                 free(enc->iv);
                 free(enc->key);
@@ -787,9 +787,9 @@ set_newkeys(int mode)
         cipher_init(cc, enc->cipher, enc->key, enc->key_len,
             enc->iv, enc->iv_len, crypt_type);
         /* Deleting the keys does not gain extra security */
-        /* memset(enc->iv,  0, enc->block_size);
-           memset(enc->key, 0, enc->key_len);
-           memset(mac->key, 0, mac->key_len); */
+        /* explicit_bzero(enc->iv,  enc->block_size);
+           explicit_bzero(enc->key, enc->key_len);
+           explicit_bzero(mac->key, mac->key_len); */
         if ((comp->type == COMP_ZLIB ||
             (comp->type == COMP_DELAYED &&
              active_state->after_authentication)) && comp->enabled == 0) {
@@ -928,7 +928,7 @@ packet_send2_wrapped(void)
                 }
         } else {
                 /* clear padding */
-                memset(cp, 0, padlen);
+                explicit_bzero(cp, padlen);
         }
         /* sizeof (packet_len + pad_len + payload + padding) */
         len = buffer_len(&active_state->outgoing_packet);