summaryrefslogtreecommitdiff
path: root/readconf.c
diff options
context:
space:
mode:
authorColin Watson <cjwatson@debian.org>2014-02-09 16:09:58 +0000
committerColin Watson <cjwatson@debian.org>2019-06-21 16:14:03 +0100
commit0fc2ac6707abe076cd6b444f73c478eeda54b25f (patch)
treee433ad99222914ffb1e6f666b1bfa3739784e243 /readconf.c
parente9dd9cd95fe8fe2da9b114a1546a90634b3ce4be (diff)
Allow harmless group-writability
Allow secure files (~/.ssh/config, ~/.ssh/authorized_keys, etc.) to be group-writable, provided that the group in question contains only the file's owner. Rejected upstream for IMO incorrect reasons (e.g. a misunderstanding about the contents of gr->gr_mem). Given that per-user groups and umask 002 are the default setup in Debian (for good reasons - this makes operating in setgid directories with other groups much easier), we need to permit this by default. Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1060 Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=314347 Last-Update: 2019-06-05 Patch-Name: user-group-modes.patch
Diffstat (limited to 'readconf.c')
-rw-r--r--readconf.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/readconf.c b/readconf.c
index 3d0b6ff90..cd60007f8 100644
--- a/readconf.c
+++ b/readconf.c
@@ -1846,8 +1846,7 @@ read_config_file_depth(const char *filename, struct passwd *pw,
1846 1846
1847 if (fstat(fileno(f), &sb) == -1) 1847 if (fstat(fileno(f), &sb) == -1)
1848 fatal("fstat %s: %s", filename, strerror(errno)); 1848 fatal("fstat %s: %s", filename, strerror(errno));
1849 if (((sb.st_uid != 0 && sb.st_uid != getuid()) || 1849 if (!secure_permissions(&sb, getuid()))
1850 (sb.st_mode & 022) != 0))
1851 fatal("Bad owner or permissions on %s", filename); 1850 fatal("Bad owner or permissions on %s", filename);
1852 } 1851 }
1853 1852