diff options
author | Colin Watson <cjwatson@debian.org> | 2014-02-09 16:09:58 +0000 |
---|---|---|
committer | Colin Watson <cjwatson@debian.org> | 2018-04-03 08:21:37 +0100 |
commit | 9e45701c5d6105444cc2f4f5d6c44b0f69969479 (patch) | |
tree | 9df3ccd6a8eee5c69d410a69d06be927bc7284fd /readconf.c | |
parent | 027619c6b05713e3f08a51e7232389383900e5d8 (diff) |
Allow harmless group-writability
Allow secure files (~/.ssh/config, ~/.ssh/authorized_keys, etc.) to be
group-writable, provided that the group in question contains only the file's
owner. Rejected upstream for IMO incorrect reasons (e.g. a misunderstanding
about the contents of gr->gr_mem). Given that per-user groups and umask 002
are the default setup in Debian (for good reasons - this makes operating in
setgid directories with other groups much easier), we need to permit this by
default.
Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1060
Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=314347
Last-Update: 2017-10-04
Patch-Name: user-group-modes.patch
Diffstat (limited to 'readconf.c')
-rw-r--r-- | readconf.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/readconf.c b/readconf.c index 7f2b5c172..50349e238 100644 --- a/readconf.c +++ b/readconf.c | |||
@@ -1741,8 +1741,7 @@ read_config_file_depth(const char *filename, struct passwd *pw, | |||
1741 | 1741 | ||
1742 | if (fstat(fileno(f), &sb) == -1) | 1742 | if (fstat(fileno(f), &sb) == -1) |
1743 | fatal("fstat %s: %s", filename, strerror(errno)); | 1743 | fatal("fstat %s: %s", filename, strerror(errno)); |
1744 | if (((sb.st_uid != 0 && sb.st_uid != getuid()) || | 1744 | if (!secure_permissions(&sb, getuid())) |
1745 | (sb.st_mode & 022) != 0)) | ||
1746 | fatal("Bad owner or permissions on %s", filename); | 1745 | fatal("Bad owner or permissions on %s", filename); |
1747 | } | 1746 | } |
1748 | 1747 | ||