diff options
author | Colin Watson <cjwatson@debian.org> | 2014-02-09 16:09:58 +0000 |
---|---|---|
committer | Colin Watson <cjwatson@debian.org> | 2020-06-07 10:25:35 +0100 |
commit | cb72edd9757c469f3b5dc9cde374715ae8b54509 (patch) | |
tree | 951cb0005a70b702a50b17a59077ac697950264b /readconf.c | |
parent | f2c3eb379d31f24de20dc9a2e0089ed84f52055b (diff) |
Allow harmless group-writability
Allow secure files (~/.ssh/config, ~/.ssh/authorized_keys, etc.) to be
group-writable, provided that the group in question contains only the file's
owner. Rejected upstream for IMO incorrect reasons (e.g. a misunderstanding
about the contents of gr->gr_mem). Given that per-user groups and umask 002
are the default setup in Debian (for good reasons - this makes operating in
setgid directories with other groups much easier), we need to permit this by
default.
Bug: https://bugzilla.mindrot.org/show_bug.cgi?id=1060
Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=314347
Last-Update: 2019-10-09
Patch-Name: user-group-modes.patch
Diffstat (limited to 'readconf.c')
-rw-r--r-- | readconf.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/readconf.c b/readconf.c index 431243193..5bf0afbb4 100644 --- a/readconf.c +++ b/readconf.c | |||
@@ -1926,8 +1926,7 @@ read_config_file_depth(const char *filename, struct passwd *pw, | |||
1926 | 1926 | ||
1927 | if (fstat(fileno(f), &sb) == -1) | 1927 | if (fstat(fileno(f), &sb) == -1) |
1928 | fatal("fstat %s: %s", filename, strerror(errno)); | 1928 | fatal("fstat %s: %s", filename, strerror(errno)); |
1929 | if (((sb.st_uid != 0 && sb.st_uid != getuid()) || | 1929 | if (!secure_permissions(&sb, getuid())) |
1930 | (sb.st_mode & 022) != 0)) | ||
1931 | fatal("Bad owner or permissions on %s", filename); | 1930 | fatal("Bad owner or permissions on %s", filename); |
1932 | } | 1931 | } |
1933 | 1932 | ||