- markus@cvs.openbsd.org 2006/05/17 12:43:34

     [scp.c sftp.c ssh-agent.c ssh-keygen.c sshconnect.c]
     fix leak; coverity via Kylene Jo Hall

1 files changed, 4 insertions, 2 deletions

diff --git a/scp.c b/scp.c
index 2778f8f80..e5332972c 100644
--- a/scp.c
+++ b/scp.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: scp.c,v 1.141 2006/04/01 05:50:29 djm Exp $ */
+/* $OpenBSD: scp.c,v 1.142 2006/05/17 12:43:34 markus Exp $ */
 /*
  * scp - secure remote copy.  This is basically patched BSD rcp which
  * uses ssh to do the data transfer (instead of using rcmd).
@@ -193,7 +193,8 @@ do_cmd(char *host, char *remuser, char *cmd, int *fdin, int *fdout)
          * Reserve two descriptors so that the real pipes won't get
          * descriptors 0 and 1 because that will screw up dup2 below.
          */
-        pipe(reserved);
+        if (pipe(reserved) < 0)
+                fatal("pipe: %s", strerror(errno));
 
         /* Create a socket pair for communicating with ssh. */
         if (pipe(pin) < 0)
@@ -499,6 +500,7 @@ toremote(char *targ, int argc, char **argv)
                         source(1, argv + i);
                 }
         }
+        xfree(arg);
 }
 
 void