upstream: When system calls indicate an error they return -1, not

some arbitrary value < 0.  errno is only updated in this case.  Change all
(most?) callers of syscalls to follow this better, and let's see if this
strictness helps us in the future.

OpenBSD-Commit-ID: 48081f00db7518e3b712a49dca06efc2a5428075

1 files changed, 12 insertions, 12 deletions

diff --git a/scp.c b/scp.c
index 80bc0e8b1..86204d8f1 100644
--- a/scp.c
+++ b/scp.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: scp.c,v 1.204 2019/02/10 11:15:52 djm Exp $ */
+/* $OpenBSD: scp.c,v 1.205 2019/06/28 13:35:04 deraadt Exp $ */
 /*
  * scp - secure remote copy.  This is basically patched BSD rcp which
  * uses ssh to do the data transfer (instead of using rcmd).
@@ -253,13 +253,13 @@ do_cmd(char *host, char *remuser, int port, char *cmd, int *fdin, int *fdout)
          * Reserve two descriptors so that the real pipes won't get
          * descriptors 0 and 1 because that will screw up dup2 below.
          */
-        if (pipe(reserved) < 0)
+        if (pipe(reserved) == -1)
                 fatal("pipe: %s", strerror(errno));
 
         /* Create a socket pair for communicating with ssh. */
-        if (pipe(pin) < 0)
+        if (pipe(pin) == -1)
                 fatal("pipe: %s", strerror(errno));
-        if (pipe(pout) < 0)
+        if (pipe(pout) == -1)
                 fatal("pipe: %s", strerror(errno));
 
         /* Free the reserved descriptors. */
@@ -1075,13 +1075,13 @@ source(int argc, char **argv)
                 len = strlen(name);
                 while (len > 1 && name[len-1] == '/')
                         name[--len] = '\0';
-                if ((fd = open(name, O_RDONLY|O_NONBLOCK, 0)) < 0)
+                if ((fd = open(name, O_RDONLY|O_NONBLOCK, 0)) == -1)
                         goto syserr;
                 if (strchr(name, '\n') != NULL) {
                         strnvis(encname, name, sizeof(encname), VIS_NL);
                         name = encname;
                 }
-                if (fstat(fd, &stb) < 0) {
+                if (fstat(fd, &stb) == -1) {
 syserr:                 run_err("%s: %s", name, strerror(errno));
                         goto next;
                 }
@@ -1155,7 +1155,7 @@ next:			if (fd != -1) {
                 unset_nonblock(remout);
 
                 if (fd != -1) {
-                        if (close(fd) < 0 && !haderr)
+                        if (close(fd) == -1 && !haderr)
                                 haderr = errno;
                         fd = -1;
                 }
@@ -1419,14 +1419,14 @@ sink(int argc, char **argv, const char *src)
                                 /* Handle copying from a read-only
                                    directory */
                                 mod_flag = 1;
-                                if (mkdir(np, mode | S_IRWXU) < 0)
+                                if (mkdir(np, mode | S_IRWXU) == -1)
                                         goto bad;
                         }
                         vect[0] = xstrdup(np);
                         sink(1, vect, src);
                         if (setimes) {
                                 setimes = 0;
-                                if (utimes(vect[0], tv) < 0)
+                                if (utimes(vect[0], tv) == -1)
                                         run_err("%s: set times: %s",
                                             vect[0], strerror(errno));
                         }
@@ -1437,7 +1437,7 @@ sink(int argc, char **argv, const char *src)
                 }
                 omode = mode;
                 mode |= S_IWUSR;
-                if ((ofd = open(np, O_WRONLY|O_CREAT, mode)) < 0) {
+                if ((ofd = open(np, O_WRONLY|O_CREAT, mode)) == -1) {
 bad:                    run_err("%s: %s", np, strerror(errno));
                         continue;
                 }
@@ -1527,7 +1527,7 @@ bad:			run_err("%s: %s", np, strerror(errno));
                         stop_progress_meter();
                 if (setimes && wrerr == NO) {
                         setimes = 0;
-                        if (utimes(np, tv) < 0) {
+                        if (utimes(np, tv) == -1) {
                                 run_err("%s: set times: %s",
                                     np, strerror(errno));
                                 wrerr = DISPLAYED;
@@ -1681,7 +1681,7 @@ allocbuf(BUF *bp, int fd, int blksize)
 #ifdef HAVE_STRUCT_STAT_ST_BLKSIZE
         struct stat stb;
 
-        if (fstat(fd, &stb) < 0) {
+        if (fstat(fd, &stb) == -1) {
                 run_err("fstat: %s", strerror(errno));
                 return (0);
         }