upstream commit

Remove NULL-checks before sshbuf_free().

ok djm@

Upstream-ID: 5ebed00ed5f9f03b119a345085e8774565466917

1 files changed, 3 insertions, 5 deletions

diff --git a/ssh-dss.c b/ssh-dss.c
index 254f2a39b..cc47dcf5f 100644
--- a/ssh-dss.c
+++ b/ssh-dss.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: ssh-dss.c,v 1.33 2015/12/10 17:08:40 mmcc Exp $ */
+/* $OpenBSD: ssh-dss.c,v 1.34 2015/12/11 04:21:12 mmcc Exp $ */
 /*
  * Copyright (c) 2000 Markus Friedl.  All rights reserved.
  *
@@ -122,8 +122,7 @@ ssh_dss_sign(const struct sshkey *key, u_char **sigp, size_t *lenp,
         explicit_bzero(digest, sizeof(digest));
         if (sig != NULL)
                 DSA_SIG_free(sig);
-        if (b != NULL)
-                sshbuf_free(b);
+        sshbuf_free(b);
         return ret;
 }
 
@@ -209,8 +208,7 @@ ssh_dss_verify(const struct sshkey *key,
         explicit_bzero(digest, sizeof(digest));
         if (sig != NULL)
                 DSA_SIG_free(sig);
-        if (b != NULL)
-                sshbuf_free(b);
+        sshbuf_free(b);
         free(ktype);
         if (sigblob != NULL) {
                 explicit_bzero(sigblob, len);