diff options
-rw-r--r-- | log.c | 4 | ||||
-rw-r--r-- | ssh.c | 8 |
2 files changed, 7 insertions, 5 deletions
@@ -1,4 +1,4 @@ | |||
1 | /* $OpenBSD: log.c,v 1.46 2015/07/08 19:04:21 markus Exp $ */ | 1 | /* $OpenBSD: log.c,v 1.47 2016/04/29 08:07:53 djm Exp $ */ |
2 | /* | 2 | /* |
3 | * Author: Tatu Ylonen <ylo@cs.hut.fi> | 3 | * Author: Tatu Ylonen <ylo@cs.hut.fi> |
4 | * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland | 4 | * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland |
@@ -342,7 +342,7 @@ log_change_level(LogLevel new_log_level) | |||
342 | int | 342 | int |
343 | log_is_on_stderr(void) | 343 | log_is_on_stderr(void) |
344 | { | 344 | { |
345 | return log_on_stderr; | 345 | return log_on_stderr && log_stderr_fd == STDERR_FILENO; |
346 | } | 346 | } |
347 | 347 | ||
348 | /* redirect what would usually get written to stderr to specified file */ | 348 | /* redirect what would usually get written to stderr to specified file */ |
@@ -1,4 +1,4 @@ | |||
1 | /* $OpenBSD: ssh.c,v 1.437 2016/03/07 19:02:43 djm Exp $ */ | 1 | /* $OpenBSD: ssh.c,v 1.438 2016/04/29 08:07:53 djm Exp $ */ |
2 | /* | 2 | /* |
3 | * Author: Tatu Ylonen <ylo@cs.hut.fi> | 3 | * Author: Tatu Ylonen <ylo@cs.hut.fi> |
4 | * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland | 4 | * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland |
@@ -1395,7 +1395,7 @@ static void | |||
1395 | control_persist_detach(void) | 1395 | control_persist_detach(void) |
1396 | { | 1396 | { |
1397 | pid_t pid; | 1397 | pid_t pid; |
1398 | int devnull; | 1398 | int devnull, keep_stderr; |
1399 | 1399 | ||
1400 | debug("%s: backgrounding master process", __func__); | 1400 | debug("%s: backgrounding master process", __func__); |
1401 | 1401 | ||
@@ -1426,8 +1426,10 @@ control_persist_detach(void) | |||
1426 | error("%s: open(\"/dev/null\"): %s", __func__, | 1426 | error("%s: open(\"/dev/null\"): %s", __func__, |
1427 | strerror(errno)); | 1427 | strerror(errno)); |
1428 | } else { | 1428 | } else { |
1429 | keep_stderr = log_is_on_stderr() && debug_flag; | ||
1429 | if (dup2(devnull, STDIN_FILENO) == -1 || | 1430 | if (dup2(devnull, STDIN_FILENO) == -1 || |
1430 | dup2(devnull, STDOUT_FILENO) == -1) | 1431 | dup2(devnull, STDOUT_FILENO) == -1 || |
1432 | (!keep_stderr && dup2(devnull, STDERR_FILENO) == -1)) | ||
1431 | error("%s: dup2: %s", __func__, strerror(errno)); | 1433 | error("%s: dup2: %s", __func__, strerror(errno)); |
1432 | if (devnull > STDERR_FILENO) | 1434 | if (devnull > STDERR_FILENO) |
1433 | close(devnull); | 1435 | close(devnull); |